public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mikael at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/93483] ICE in gfc_constructor_copy, at fortran/constructor.c:103
Date: Fri, 14 Oct 2022 19:06:40 +0000	[thread overview]
Message-ID: <bug-93483-4-PrTRNNa4K0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93483-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93483

--- Comment #17 from Mikael Morin <mikael at gcc dot gnu.org> ---
There is the possibility to bail out at the very point where things are about
to go wrong, and hope that at resolution time simplification will happen.
Like this for the first part of the test from the patch:

diff --git a/gcc/fortran/arith.cc b/gcc/fortran/arith.cc
index 9e079e42995..5e96bb9658e 100644
--- a/gcc/fortran/arith.cc
+++ b/gcc/fortran/arith.cc
@@ -1267,6 +1267,9 @@ reduce_unary (arith (*eval) (gfc_expr *, gfc_expr **),
gfc_expr *op,
   if (op->expr_type == EXPR_CONSTANT)
     return eval (op, result);

+  if (op->expr_type != EXPR_ARRAY)
+    return ARITH_INVALID_TYPE;
+
   rc = ARITH_OK;
   head = gfc_constructor_copy (op->value.constructor);
   for (c = gfc_constructor_first (head); c; c = gfc_constructor_next (c))


And something similar for the rest of the test (the binary operators).

  parent reply	other threads:[~2022-10-14 19:07 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93483-4@http.gcc.gnu.org/bugzilla/>
2020-12-06 22:13 ` anlauf at gcc dot gnu.org
2020-12-07 21:52 ` anlauf at gcc dot gnu.org
2022-10-11 16:59 ` gscfq@t-online.de
2022-10-12 19:46 ` anlauf at gcc dot gnu.org
2022-10-13 16:35 ` kargl at gcc dot gnu.org
2022-10-13 18:43 ` anlauf at gcc dot gnu.org
2022-10-13 18:52 ` sgk at troutmask dot apl.washington.edu
2022-10-13 19:09 ` anlauf at gcc dot gnu.org
2022-10-13 19:26 ` sgk at troutmask dot apl.washington.edu
2022-10-13 19:35 ` mikael at gcc dot gnu.org
2022-10-13 19:55 ` anlauf at gcc dot gnu.org
2022-10-13 20:02 ` sgk at troutmask dot apl.washington.edu
2022-10-13 20:29 ` anlauf at gcc dot gnu.org
2022-10-13 20:56 ` anlauf at gcc dot gnu.org
2022-10-13 21:39 ` sgk at troutmask dot apl.washington.edu
2022-10-14 19:06 ` mikael at gcc dot gnu.org [this message]
2022-10-14 19:13 ` mikael at gcc dot gnu.org
2022-10-14 19:14 ` mikael at gcc dot gnu.org
2022-10-14 19:19 ` mikael at gcc dot gnu.org
2022-10-14 19:24 ` anlauf at gcc dot gnu.org
2022-10-14 20:14 ` anlauf at gcc dot gnu.org
2022-10-14 21:21 ` anlauf at gcc dot gnu.org
2022-10-15  9:28 ` mikael at gcc dot gnu.org
2022-10-15 13:55 ` anlauf at gcc dot gnu.org
2022-10-15 13:56 ` anlauf at gcc dot gnu.org
2022-10-15 17:38 ` mikael at gcc dot gnu.org
2022-10-15 19:56 ` anlauf at gcc dot gnu.org
2022-10-17 17:26 ` cvs-commit at gcc dot gnu.org
2022-10-17 17:39 ` anlauf at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93483-4-PrTRNNa4K0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).