public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug c/99275] New: missing space in 'argument missing terminating nul'
@ 2021-02-25 21:46 roland.illig at gmx dot de
2021-02-26 7:14 ` [Bug c/99275] " rguenth at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: roland.illig at gmx dot de @ 2021-02-25 21:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99275
Bug ID: 99275
Summary: missing space in 'argument missing terminating nul'
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: roland.illig at gmx dot de
Target Milestone: ---
builtins.c says:
> warned = warning_at (loc, OPT_Wstringop_overread,
> "%qsargument missing terminating nul",
> fname);
This confused me as the German translator.
First, I thought that fname was a filename, which didn't make sense at all. It
took me some minutes to find out that fname was supposed to be the function
name, I would have expected fnname for that.
Then I wondered why there is no space between %qs and 'argument'.
Then I wondered how this missing space could have passed the test suite, as the
test suite does contain several instances of dg-message for this diagnostic.
The tricky point here is that there are two diagnostics that are almost the
same, the other one uses %qD instead of %qs.
A possible explanation for missing the missing space is that to avoid to test
the varying quotes, that part of the diagnostic is generally not tested. But
shouldn't the quotes in LC_ALL=C always be simple ASCII quotes, making this
simple?
While here, there's a typo in a comment in warn_string_no_nul: "the nuber of
messages" should be "the number of messages".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c/99275] missing space in 'argument missing terminating nul' 2021-02-25 21:46 [Bug c/99275] New: missing space in 'argument missing terminating nul' roland.illig at gmx dot de @ 2021-02-26 7:14 ` rguenth at gcc dot gnu.org 2021-02-26 7:52 ` cvs-commit at gcc dot gnu.org 2021-02-26 7:52 ` rguenth at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: rguenth at gcc dot gnu.org @ 2021-02-26 7:14 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99275 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Keywords| |diagnostic Last reconfirmed| |2021-02-26 Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> --- Confirmed. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c/99275] missing space in 'argument missing terminating nul' 2021-02-25 21:46 [Bug c/99275] New: missing space in 'argument missing terminating nul' roland.illig at gmx dot de 2021-02-26 7:14 ` [Bug c/99275] " rguenth at gcc dot gnu.org @ 2021-02-26 7:52 ` cvs-commit at gcc dot gnu.org 2021-02-26 7:52 ` rguenth at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2021-02-26 7:52 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99275 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>: https://gcc.gnu.org/g:ff7a5154460e2830e244c350cc8f7c35913de70e commit r11-7417-gff7a5154460e2830e244c350cc8f7c35913de70e Author: Richard Biener <rguenther@suse.de> Date: Fri Feb 26 08:50:17 2021 +0100 c/99275 - fix missing space in diagnostic This fixes a missing space as reported by translators. 2021-02-26 Richard Biener <rguenther@suse.de> PR c/99275 * builtins.c (warn_string_no_nul): Fix diagnostic formatting. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c/99275] missing space in 'argument missing terminating nul' 2021-02-25 21:46 [Bug c/99275] New: missing space in 'argument missing terminating nul' roland.illig at gmx dot de 2021-02-26 7:14 ` [Bug c/99275] " rguenth at gcc dot gnu.org 2021-02-26 7:52 ` cvs-commit at gcc dot gnu.org @ 2021-02-26 7:52 ` rguenth at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: rguenth at gcc dot gnu.org @ 2021-02-26 7:52 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99275 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- Fixed. Thanks for the report. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-26 7:52 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-25 21:46 [Bug c/99275] New: missing space in 'argument missing terminating nul' roland.illig at gmx dot de 2021-02-26 7:14 ` [Bug c/99275] " rguenth at gcc dot gnu.org 2021-02-26 7:52 ` cvs-commit at gcc dot gnu.org 2021-02-26 7:52 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).