public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/99928] [OpenMP] reduction variable in combined target construct wrongly mapped as firstprivate
Date: Fri, 04 Jun 2021 10:08:43 +0000	[thread overview]
Message-ID: <bug-99928-4-4ymzMiMevm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99928-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99928

--- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:178191e1dfafd8db149edcdef7a39e9e2c00f216

commit r12-1206-g178191e1dfafd8db149edcdef7a39e9e2c00f216
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Fri Jun 4 12:06:59 2021 +0200

    Fortran/OpenMP: Add omp loop [PR99928]

            PR middle-end/99928

    gcc/fortran/ChangeLog:

            * dump-parse-tree.c (show_omp_clauses): Handle bind clause.
            (show_omp_node): Handle loop directive.
            * frontend-passes.c (gfc_code_walker): Likewise.
            * gfortran.h (enum gfc_statement): Add
            ST_OMP_(END_)(TARGET_)(|PARALLEL_|TEAMS_)LOOP.
            (enum gfc_omp_bind_type): New.
            (gfc_omp_clauses): Use it.
            (enum gfc_exec_op): Add EXEC_OMP_(TARGET_)(|PARALLEL_|TEAMS_)LOOP.
            * match.h (gfc_match_omp_loop, gfc_match_omp_parallel_loop,
            gfc_match_omp_target_parallel_loop,
gfc_match_omp_target_teams_loop,
            gfc_match_omp_teams_loop): New.
            * openmp.c (enum omp_mask1): Add OMP_CLAUSE_BIND.
            (gfc_match_omp_clauses): Handle it.
            (OMP_LOOP_CLAUSES, gfc_match_omp_loop, gfc_match_omp_teams_loop,
            gfc_match_omp_target_teams_loop, gfc_match_omp_parallel_loop,
            gfc_match_omp_target_parallel_loop): New.
            (resolve_omp_clauses, resolve_omp_do, omp_code_to_statement,
            gfc_resolve_omp_directive): Handle omp loop.
            * parse.c (decode_omp_directive case_exec_markers,
gfc_ascii_statement,
            parse_omp_do, parse_executable): Likewise.
            (parse_omp_structured_block): Remove ST_ which use parse_omp_do.
            * resolve.c (gfc_resolve_blocks): Add omp loop.
            * st.c (gfc_free_statement): Likewise.
            * trans-openmp.c (gfc_trans_omp_clauses): Handle bind clause.
            (gfc_trans_omp_do, gfc_trans_omp_parallel_do,
gfc_trans_omp_distribute,
            gfc_trans_omp_teams, gfc_trans_omp_target,
gfc_trans_omp_directive):
            Handle loop directive.
            (gfc_split_omp_clauses): Likewise; fix firstprivate/lastprivate
            and (in_)reduction for taskloop.
            * trans.c (trans_code): Handle omp loop directive.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/gomp/pr99928-3.f90: Add 'default(none)', following
            C/C++ version of the patch.
            * gfortran.dg/gomp/loop-1.f90: New test.
            * gfortran.dg/gomp/loop-2.f90: New test.
            * gfortran.dg/gomp/pr99928-1.f90: New test; based on C/C++ test.
            * gfortran.dg/gomp/pr99928-11.f90: Likewise.
            * gfortran.dg/gomp/pr99928-2.f90: Likewise.
            * gfortran.dg/gomp/pr99928-4.f90: Likewise.
            * gfortran.dg/gomp/pr99928-5.f90: Likewise.
            * gfortran.dg/gomp/pr99928-6.f90: Likewise.
            * gfortran.dg/gomp/pr99928-8.f90: Likewise.
            * gfortran.dg/goacc/omp.f95: Use 'acc kernels loops' instead
            of 'acc loops' to hide unrelated bug for now.
            * gfortran.dg/goacc/omp-fixed.f: Likewise

  parent reply	other threads:[~2021-06-04 10:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  8:39 [Bug middle-end/99928] New: " burnus at gcc dot gnu.org
2021-04-06  9:20 ` [Bug middle-end/99928] " jakub at gcc dot gnu.org
2021-04-10 17:23 ` burnus at gcc dot gnu.org
2021-05-06 15:59 ` jakub at gcc dot gnu.org
2021-05-06 16:23 ` burnus at gcc dot gnu.org
2021-05-06 16:35 ` jakub at gcc dot gnu.org
2021-05-13 15:16 ` cvs-commit at gcc dot gnu.org
2021-05-13 19:39 ` burnus at gcc dot gnu.org
2021-05-13 20:13 ` jakub at gcc dot gnu.org
2021-05-19  7:30 ` cvs-commit at gcc dot gnu.org
2021-05-20  7:20 ` cvs-commit at gcc dot gnu.org
2021-05-21 19:15 ` cvs-commit at gcc dot gnu.org
2021-05-21 19:20 ` cvs-commit at gcc dot gnu.org
2021-05-25  9:08 ` cvs-commit at gcc dot gnu.org
2021-05-28  9:34 ` cvs-commit at gcc dot gnu.org
2021-05-29  8:08 ` cvs-commit at gcc dot gnu.org
2021-06-01 10:48 ` cvs-commit at gcc dot gnu.org
2021-06-02  9:48 ` cvs-commit at gcc dot gnu.org
2021-06-04 10:08 ` cvs-commit at gcc dot gnu.org [this message]
2021-06-04 10:19 ` cvs-commit at gcc dot gnu.org
2021-06-04 12:04 ` burnus at gcc dot gnu.org
2021-06-08  7:52 ` cvs-commit at gcc dot gnu.org
2023-05-03 17:36 ` anlauf at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99928-4-4ymzMiMevm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).