public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/99928] [OpenMP] reduction variable in combined target construct wrongly mapped as firstprivate
Date: Tue, 01 Jun 2021 10:48:23 +0000 [thread overview]
Message-ID: <bug-99928-4-r8EJtmnZ6Q@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99928-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99928
--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:
https://gcc.gnu.org/g:f6bf436d9ab907d090823895abb7a2d5ba7ff50c
commit r12-1139-gf6bf436d9ab907d090823895abb7a2d5ba7ff50c
Author: Tobias Burnus <tobias@codesourcery.com>
Date: Tue Jun 1 12:46:37 2021 +0200
Fortran/OpenMP: Support (parallel) master taskloop (simd) [PR99928]
PR middle-end/99928
gcc/fortran/ChangeLog:
* dump-parse-tree.c (show_omp_node, show_code_node): Handle
(parallel) master taskloop (simd).
* frontend-passes.c (gfc_code_walker): Set in_omp_workshare
to false for parallel master taskloop (simd).
* gfortran.h (enum gfc_statement):
Add ST_OMP_(END_)(PARALLEL_)MASTER_TASKLOOP(_SIMD).
(enum gfc_exec_op): EXEC_OMP_(PARALLEL_)MASTER_TASKLOOP(_SIMD).
* match.h (gfc_match_omp_master_taskloop,
gfc_match_omp_master_taskloop_simd,
gfc_match_omp_parallel_master_taskloop,
gfc_match_omp_parallel_master_taskloop_simd): New prototype.
* openmp.c (gfc_match_omp_parallel_master_taskloop,
gfc_match_omp_parallel_master_taskloop_simd,
gfc_match_omp_master_taskloop,
gfc_match_omp_master_taskloop_simd): New.
(gfc_match_omp_taskloop_simd): Permit 'reduction' clause.
(resolve_omp_clauses): Handle new combined directives; remove
inscan-reduction check to reduce multiple errors; add
task-reduction error for 'taskloop simd'.
(gfc_resolve_omp_parallel_blocks,
resolve_omp_do, omp_code_to_statement,
gfc_resolve_omp_directive): Handle new combined constructs.
* parse.c (decode_omp_directive, next_statement,
gfc_ascii_statement, parse_omp_do, parse_omp_structured_block,
parse_executable): Likewise.
* resolve.c (gfc_resolve_blocks, gfc_resolve_code): Likewise.
* st.c (gfc_free_statement): Likewise.
* trans.c (trans_code): Likewise.
* trans-openmp.c (gfc_split_omp_clauses,
gfc_trans_omp_directive): Likewise.
(gfc_trans_omp_parallel_master): Move after
gfc_trans_omp_master_taskloop;
handle parallel master taskloop (simd) as well.
(gfc_trans_omp_taskloop): Take gfc_exec_op as arg.
(gfc_trans_omp_master_taskloop): New.
gcc/testsuite/ChangeLog:
* gfortran.dg/gomp/reduction5.f90: Remove dg-error; the issue is
now diagnosed with less error output.
* gfortran.dg/gomp/scan-1.f90: Likewise.
* gfortran.dg/gomp/pr99928-3.f90: New test.
* gfortran.dg/gomp/taskloop-1.f90: New test.
next prev parent reply other threads:[~2021-06-01 10:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 8:39 [Bug middle-end/99928] New: " burnus at gcc dot gnu.org
2021-04-06 9:20 ` [Bug middle-end/99928] " jakub at gcc dot gnu.org
2021-04-10 17:23 ` burnus at gcc dot gnu.org
2021-05-06 15:59 ` jakub at gcc dot gnu.org
2021-05-06 16:23 ` burnus at gcc dot gnu.org
2021-05-06 16:35 ` jakub at gcc dot gnu.org
2021-05-13 15:16 ` cvs-commit at gcc dot gnu.org
2021-05-13 19:39 ` burnus at gcc dot gnu.org
2021-05-13 20:13 ` jakub at gcc dot gnu.org
2021-05-19 7:30 ` cvs-commit at gcc dot gnu.org
2021-05-20 7:20 ` cvs-commit at gcc dot gnu.org
2021-05-21 19:15 ` cvs-commit at gcc dot gnu.org
2021-05-21 19:20 ` cvs-commit at gcc dot gnu.org
2021-05-25 9:08 ` cvs-commit at gcc dot gnu.org
2021-05-28 9:34 ` cvs-commit at gcc dot gnu.org
2021-05-29 8:08 ` cvs-commit at gcc dot gnu.org
2021-06-01 10:48 ` cvs-commit at gcc dot gnu.org [this message]
2021-06-02 9:48 ` cvs-commit at gcc dot gnu.org
2021-06-04 10:08 ` cvs-commit at gcc dot gnu.org
2021-06-04 10:19 ` cvs-commit at gcc dot gnu.org
2021-06-04 12:04 ` burnus at gcc dot gnu.org
2021-06-08 7:52 ` cvs-commit at gcc dot gnu.org
2023-05-03 17:36 ` anlauf at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-99928-4-r8EJtmnZ6Q@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).