public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/99928] [OpenMP] reduction variable in combined target construct wrongly mapped as firstprivate
Date: Thu, 06 May 2021 16:35:16 +0000	[thread overview]
Message-ID: <bug-99928-4-GjvYK76uGR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99928-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99928

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Yeah, I've noticed that when looking at combined constructs because otherwise
the  2.14 rule that in_reduction when on target shall be also
map(always,tofrom:) doesn't make any sense.

Anyway, we have some known differences in the handling of the oldest cases
(parallel for, parallel sections).
And we have the stuff I've put into the tarball already compile time covered in
c-c++-common/gomp/clauses-1.c hopefully, but I think it would be finally worth
it to add scan-tree-dump gimple checks on these simplified testcases (with 1 or
2 clauses instead of all possible ones), with xfails for the cases we don't
handle correctly and comments for those xfailed cases.
I'll work on that now.

And your patch is in the review queue, but I think it is better to figure out
what we do wrong and how much first.

  parent reply	other threads:[~2021-05-06 16:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  8:39 [Bug middle-end/99928] New: " burnus at gcc dot gnu.org
2021-04-06  9:20 ` [Bug middle-end/99928] " jakub at gcc dot gnu.org
2021-04-10 17:23 ` burnus at gcc dot gnu.org
2021-05-06 15:59 ` jakub at gcc dot gnu.org
2021-05-06 16:23 ` burnus at gcc dot gnu.org
2021-05-06 16:35 ` jakub at gcc dot gnu.org [this message]
2021-05-13 15:16 ` cvs-commit at gcc dot gnu.org
2021-05-13 19:39 ` burnus at gcc dot gnu.org
2021-05-13 20:13 ` jakub at gcc dot gnu.org
2021-05-19  7:30 ` cvs-commit at gcc dot gnu.org
2021-05-20  7:20 ` cvs-commit at gcc dot gnu.org
2021-05-21 19:15 ` cvs-commit at gcc dot gnu.org
2021-05-21 19:20 ` cvs-commit at gcc dot gnu.org
2021-05-25  9:08 ` cvs-commit at gcc dot gnu.org
2021-05-28  9:34 ` cvs-commit at gcc dot gnu.org
2021-05-29  8:08 ` cvs-commit at gcc dot gnu.org
2021-06-01 10:48 ` cvs-commit at gcc dot gnu.org
2021-06-02  9:48 ` cvs-commit at gcc dot gnu.org
2021-06-04 10:08 ` cvs-commit at gcc dot gnu.org
2021-06-04 10:19 ` cvs-commit at gcc dot gnu.org
2021-06-04 12:04 ` burnus at gcc dot gnu.org
2021-06-08  7:52 ` cvs-commit at gcc dot gnu.org
2023-05-03 17:36 ` anlauf at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99928-4-GjvYK76uGR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).