public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/99928] [OpenMP] reduction variable in combined target construct wrongly mapped as firstprivate Date: Wed, 19 May 2021 07:30:22 +0000 [thread overview] Message-ID: <bug-99928-4-yFsMhL8RQQ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99928-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99928 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:780e5d4a2bac6eb7566c966a265961c99449cb55 commit r12-902-g780e5d4a2bac6eb7566c966a265961c99449cb55 Author: Jakub Jelinek <jakub@redhat.com> Date: Wed May 19 09:21:09 2021 +0200 openmp: Handle lastprivate on combined target correctly [PR99928] This patch deals with 2 issues: 1) the gimplifier couldn't differentiate between #pragma omp parallel master #pragma omp taskloop simd and #pragma omp parallel master taskloop simd when there is a significant difference for clause handling between the two; as master construct doesn't have any clauses, we don't currently represent it during gimplification by an gimplification omp context at all, so this patch makes sure we don't set OMP_PARALLEL_COMBINED on parallel master when not combined further. If we ever add a separate master context during gimplification, we'd use ORT_COMBINED_MASTER vs. ORT_MASTER (or MASKED probably). 2) lastprivate when combined with target should be map(tofrom:) on the target, this change handles it only when not combined with firstprivate though, that will need further work (similarly to linear or reduction). 2021-05-19 Jakub Jelinek <jakub@redhat.com> PR middle-end/99928 gcc/ * tree.h (OMP_MASTER_COMBINED): Define. * gimplify.c (gimplify_scan_omp_clauses): Rewrite lastprivate handling for outer combined/composite constructs to a loop. Handle lastprivate on combined target. (gimplify_expr): Formatting fix. gcc/c/ * c-parser.c (c_parser_omp_master): Set OMP_MASTER_COMBINED on master when combined with taskloop. (c_parser_omp_parallel): Don't set OMP_PARALLEL_COMBINED on parallel master when not combined with taskloop. gcc/cp/ * parser.c (cp_parser_omp_master): Set OMP_MASTER_COMBINED on master when combined with taskloop. (cp_parser_omp_parallel): Don't set OMP_PARALLEL_COMBINED on parallel master when not combined with taskloop. gcc/testsuite/ * c-c++-common/gomp/pr99928-2.c: Remove all xfails. * c-c++-common/gomp/pr99928-12.c: New test.
next prev parent reply other threads:[~2021-05-19 7:30 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-06 8:39 [Bug middle-end/99928] New: " burnus at gcc dot gnu.org 2021-04-06 9:20 ` [Bug middle-end/99928] " jakub at gcc dot gnu.org 2021-04-10 17:23 ` burnus at gcc dot gnu.org 2021-05-06 15:59 ` jakub at gcc dot gnu.org 2021-05-06 16:23 ` burnus at gcc dot gnu.org 2021-05-06 16:35 ` jakub at gcc dot gnu.org 2021-05-13 15:16 ` cvs-commit at gcc dot gnu.org 2021-05-13 19:39 ` burnus at gcc dot gnu.org 2021-05-13 20:13 ` jakub at gcc dot gnu.org 2021-05-19 7:30 ` cvs-commit at gcc dot gnu.org [this message] 2021-05-20 7:20 ` cvs-commit at gcc dot gnu.org 2021-05-21 19:15 ` cvs-commit at gcc dot gnu.org 2021-05-21 19:20 ` cvs-commit at gcc dot gnu.org 2021-05-25 9:08 ` cvs-commit at gcc dot gnu.org 2021-05-28 9:34 ` cvs-commit at gcc dot gnu.org 2021-05-29 8:08 ` cvs-commit at gcc dot gnu.org 2021-06-01 10:48 ` cvs-commit at gcc dot gnu.org 2021-06-02 9:48 ` cvs-commit at gcc dot gnu.org 2021-06-04 10:08 ` cvs-commit at gcc dot gnu.org 2021-06-04 10:19 ` cvs-commit at gcc dot gnu.org 2021-06-04 12:04 ` burnus at gcc dot gnu.org 2021-06-08 7:52 ` cvs-commit at gcc dot gnu.org 2023-05-03 17:36 ` anlauf at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99928-4-yFsMhL8RQQ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).