public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/meissner/heads/work122)] Update ChangeLog.meissner Date: Thu, 8 Jun 2023 16:54:58 +0000 (GMT) [thread overview] Message-ID: <20230608165458.1CABA3858C62@sourceware.org> (raw) https://gcc.gnu.org/g:fb5a0e51cc9f435071cf46090bd8dd0aa99b895a commit fb5a0e51cc9f435071cf46090bd8dd0aa99b895a Author: Michael Meissner <meissner@linux.ibm.com> Date: Thu Jun 8 12:54:54 2023 -0400 Update ChangeLog.meissner Diff: --- gcc/ChangeLog.meissner | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner index 1c40084ce43..63644d60a12 100644 --- a/gcc/ChangeLog.meissner +++ b/gcc/ChangeLog.meissner @@ -1,4 +1,4 @@ -==================== Branch work122, patch #1 ==================== +==================== Branch work122, patch #2 ==================== Fix power10 fusion and -fstack-protector, PR target/105325 @@ -6,10 +6,12 @@ This patch fixes an issue where if you use the -fstack-protector and -mcpu=power10 options and you have a large stack frame, the GCC compiler will generate a LWA instruction with a large offset. -There are several problems: +There are several problems with the current GCC: 1) The prefixed attribute was not checking insns with the type - fused_load_cmpi for being load insns. + fused_load_cmpi for being load insns. This meant if the load + compare + fusion was not split, it would not know that the load should be + prefixed. 2) The recognition of LWA for being prefixed looks at the "sign_extend" attribute and whether the register mode was different than the memory @@ -18,7 +20,7 @@ There are several problems: 3) The constraints in fusion.md (generated by genfusion.pl) use "m" for LWA and LD, when they should use "YZ". - 4) There is a lwa_operand that should be used instead of + 4) There is a lwa_operand predicate that should be used instead of ds_form_mem_operand for the LWA instruction. The main fix is to modify genfusion.pl that it sets the appropriate predicates @@ -33,15 +35,15 @@ I set the "sign_extend" attribute on the cases that generate LWA. I modified the "prefixed" attribute so that it also checks fused_load_cmpi. -2023-06-06 Michael Meissner <meissner@linux.ibm.com> +2023-06-07 Michael Meissner <meissner@linux.ibm.com> gcc/ * config/rs6000/genfusion.pl (gen_ld_cmpi_p10_one): Fix constraints and predicates for LD and LWA. Optimize LWA/CMPDI to generate LWZ/CMPWI if - we don't need the result of the load after the comparison. Change the - name of the insn pattern to reflect whether a DImode or SImode register - is loaded. Set sign_extend attribute for LWA instruction. + we don't need the result of the load after the comparison. Set the + sign_extend attribute for LWA instruction. For LWA where we do not need + the result of the load after the comparison, use LWZ and CMPWI. * config/rs6000/fusion.md: Regenerate. * config/rs6000/rs6000.md (prefixed attribute): Treat fused_load_cmpi insns as being load insns. @@ -52,6 +54,8 @@ gcc/testsuite/ * gcc.target/powerpc/fusion-p10-ldcmpi.c: Adjust names and insn counts for PR target/105325 fix. +==================== Branch work122, patch #1 was reverted ==================== + ==================== Branch work122, baseline ==================== 2023-06-06 Michael Meissner <meissner@linux.ibm.com>
next reply other threads:[~2023-06-08 16:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-08 16:54 Michael Meissner [this message] -- strict thread matches above, loose matches on Subject: below -- 2023-06-13 23:25 Michael Meissner 2023-06-13 17:23 Michael Meissner 2023-06-13 2:58 Michael Meissner 2023-06-09 21:06 Michael Meissner 2023-06-09 6:10 Michael Meissner 2023-06-09 4:18 Michael Meissner 2023-06-09 1:33 Michael Meissner 2023-06-07 20:58 Michael Meissner 2023-06-07 18:57 Michael Meissner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230608165458.1CABA3858C62@sourceware.org \ --to=meissner@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).