public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return
@ 2024-04-23  3:50 Alexandre Oliva
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Oliva @ 2024-04-23  3:50 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:9d8a2a67a84deaaf0645a73d17564d68059b2433

commit 9d8a2a67a84deaaf0645a73d17564d68059b2433
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Apr 23 00:33:04 2024 -0300

    make -freg-struct-return visibly a negative alias of -fpcc-struct-return
    
    The fact that both options accept negative forms suggests that maybe
    they aren't negative forms of each other.  They are, but that isn't
    clear even by examining common.opt.  Use NegativeAlias to make it
    abundantly clear.
    
    
    for  gcc/ChangeLog
    
            * common.opt (freg-struct-return): Make it explicitly
            fpcc-struct-return's NegativeAlias.

Diff:
---
 gcc/common.opt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/common.opt b/gcc/common.opt
index ad348844775..f973d767584 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches)
 Record gcc command line switches in the object file.
 
 freg-struct-return
-Common Var(flag_pcc_struct_return,0) Optimization
+Common NegativeAlias Alias(fpcc_struct_return) Optimization
 Return small aggregates in registers.
 
 fregmove

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return
@ 2024-04-28  5:21 Alexandre Oliva
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Oliva @ 2024-04-28  5:21 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:4c42beadc660572409d3e6f452bf4c0209f320c3

commit 4c42beadc660572409d3e6f452bf4c0209f320c3
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Apr 23 00:33:04 2024 -0300

    make -freg-struct-return visibly a negative alias of -fpcc-struct-return
    
    The fact that both options accept negative forms suggests that maybe
    they aren't negative forms of each other.  They are, but that isn't
    clear even by examining common.opt.  Use NegativeAlias to make it
    abundantly clear.
    
    The 'Optimization' keyword next to freg-struct-return was the only
    thing that caused flag_pcc_struct_return to be a per-function flag,
    and ipa-inline relied on that.  After making it an alias, the
    Optimization keyword was no longer operational.  I'm not sure it was
    sensible or desirable for flag_pcc_struct_return to be a per-function
    setting, but this patch does not intend to change behavior.
    
    
    for  gcc/ChangeLog
    
            * common.opt (freg-struct-return): Make it explicitly
            fpcc-struct-return's NegativeAlias.  Copy Optimization...
            (freg-struct-return): ... here.

Diff:
---
 gcc/common.opt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/common.opt b/gcc/common.opt
index ad348844775..12d93c76a1e 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2406,7 +2406,7 @@ Common RejectNegative Joined UInteger Optimization
 -fpack-struct=<number>	Set initial maximum structure member alignment.
 
 fpcc-struct-return
-Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN)
+Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) Optimization
 Return small aggregates in memory, not registers.
 
 fpeel-loops
@@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches)
 Record gcc command line switches in the object file.
 
 freg-struct-return
-Common Var(flag_pcc_struct_return,0) Optimization
+Common NegativeAlias Alias(fpcc_struct_return) Optimization
 Return small aggregates in registers.
 
 fregmove

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return
@ 2024-04-23  4:20 Alexandre Oliva
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Oliva @ 2024-04-23  4:20 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:ffb3aca361d2b0e9ba415930a0fc61e8219c635c

commit ffb3aca361d2b0e9ba415930a0fc61e8219c635c
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Apr 23 00:33:04 2024 -0300

    make -freg-struct-return visibly a negative alias of -fpcc-struct-return
    
    The fact that both options accept negative forms suggests that maybe
    they aren't negative forms of each other.  They are, but that isn't
    clear even by examining common.opt.  Use NegativeAlias to make it
    abundantly clear.
    
    The 'Optimization' keyword next to freg-struct-return was the only
    thing that caused flag_pcc_struct_return to be a per-function flag,
    and ipa-inline relied on that.  After making it an alias, the
    Optimization keyword was no longer operational.  I'm not sure it was
    sensible or desirable for flag_pcc_struct_return to be a per-function
    setting, but this patch does not intend to change behavior.
    
    
    for  gcc/ChangeLog
    
            * common.opt (freg-struct-return): Make it explicitly
            fpcc-struct-return's NegativeAlias.  Copy Optimization...
            (freg-struct-return): ... here.

Diff:
---
 gcc/common.opt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/common.opt b/gcc/common.opt
index ad348844775..12d93c76a1e 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2406,7 +2406,7 @@ Common RejectNegative Joined UInteger Optimization
 -fpack-struct=<number>	Set initial maximum structure member alignment.
 
 fpcc-struct-return
-Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN)
+Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) Optimization
 Return small aggregates in memory, not registers.
 
 fpeel-loops
@@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches)
 Record gcc command line switches in the object file.
 
 freg-struct-return
-Common Var(flag_pcc_struct_return,0) Optimization
+Common NegativeAlias Alias(fpcc_struct_return) Optimization
 Return small aggregates in registers.
 
 fregmove

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return
@ 2024-04-23  3:59 Alexandre Oliva
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Oliva @ 2024-04-23  3:59 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:60e63cf86f91608df32377f9ffc7c3f3e9f316fd

commit 60e63cf86f91608df32377f9ffc7c3f3e9f316fd
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Apr 23 00:33:04 2024 -0300

    make -freg-struct-return visibly a negative alias of -fpcc-struct-return
    
    The fact that both options accept negative forms suggests that maybe
    they aren't negative forms of each other.  They are, but that isn't
    clear even by examining common.opt.  Use NegativeAlias to make it
    abundantly clear.
    
    
    for  gcc/ChangeLog
    
            * common.opt (freg-struct-return): Make it explicitly
            fpcc-struct-return's NegativeAlias.

Diff:
---
 gcc/common.opt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/common.opt b/gcc/common.opt
index ad348844775..12d93c76a1e 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2406,7 +2406,7 @@ Common RejectNegative Joined UInteger Optimization
 -fpack-struct=<number>	Set initial maximum structure member alignment.
 
 fpcc-struct-return
-Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN)
+Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) Optimization
 Return small aggregates in memory, not registers.
 
 fpeel-loops
@@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches)
 Record gcc command line switches in the object file.
 
 freg-struct-return
-Common Var(flag_pcc_struct_return,0) Optimization
+Common NegativeAlias Alias(fpcc_struct_return) Optimization
 Return small aggregates in registers.
 
 fregmove

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return
@ 2024-04-23  3:48 Alexandre Oliva
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Oliva @ 2024-04-23  3:48 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:e50550cae7e3108d7f7a0ba2f9b8f14c16e29e35

commit e50550cae7e3108d7f7a0ba2f9b8f14c16e29e35
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Apr 23 00:33:04 2024 -0300

    make -freg-struct-return visibly a negative alias of -fpcc-struct-return
    
    The fact that both options accept negative forms suggests that maybe
    they aren't negative forms of each other.  They are, but that isn't
    clear even by examining common.opt.  Use NegativeAlias to make it
    abundantly clear.
    
    
    for  gcc/ChangeLog
    
            * common.opt (freg-struct-return): Make it explicitly
            fpcc-struct-return's NegativeAlias.

Diff:
---
 gcc/common.opt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/common.opt b/gcc/common.opt
index ad348844775..ebef5977451 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches)
 Record gcc command line switches in the object file.
 
 freg-struct-return
-Common Var(flag_pcc_struct_return,0) Optimization
+Common NegativeAlias Alias(pcc_struct_return) Optimization
 Return small aggregates in registers.
 
 fregmove

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-04-28  5:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23  3:50 [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return Alexandre Oliva
  -- strict thread matches above, loose matches on Subject: below --
2024-04-28  5:21 Alexandre Oliva
2024-04-23  4:20 Alexandre Oliva
2024-04-23  3:59 Alexandre Oliva
2024-04-23  3:48 Alexandre Oliva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).