From: 钟居哲 <juzhe.zhong@rivai.ai>
To: pan2.li <pan2.li@intel.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: kito.cheng <kito.cheng@gmail.com>,
rdapp.gcc <rdapp.gcc@gmail.com>, pan2.li <pan2.li@intel.com>
Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1
Date: Mon, 22 Apr 2024 22:04:04 +0800 [thread overview]
Message-ID: <084744A73FEA274D+202404222204040470506@rivai.ai> (raw)
In-Reply-To: <20240422134734.1909499-1-pan2.li@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
lgtm
juzhe.zhong@rivai.ai
From: pan2.li
Date: 2024-04-22 21:47
To: gcc-patches
CC: juzhe.zhong; kito.cheng; rdapp.gcc; Pan Li
Subject: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1
From: Pan Li <pan2.li@intel.com>
After we reverted below 2 commits, the reference to attr need some
adjustment as the group_overlap is no longer available.
* RISC-V: Robostify the W43, W86, W87 constraint enabled attribute
* RISC-V: Rename vconstraint into group_overlap
The below tests are passed for this patch.
* The rv64gcv fully regression tests.
gcc/ChangeLog:
* config/riscv/vector-crypto.md:
Signed-off-by: Pan Li <pan2.li@intel.com>
---
gcc/config/riscv/vector-crypto.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/riscv/vector-crypto.md b/gcc/config/riscv/vector-crypto.md
index 519c6a10d94..23dc549e5b8 100755
--- a/gcc/config/riscv/vector-crypto.md
+++ b/gcc/config/riscv/vector-crypto.md
@@ -322,7 +322,7 @@ (define_insn "@pred_vwsll<mode>_scalar"
"vwsll.v%o4\t%0,%3,%4%p1"
[(set_attr "type" "vwsll")
(set_attr "mode" "<V_DOUBLE_TRUNC>")
- (set_attr "group_overlap" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,none,none")])
+ (set_attr "vconstraint" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,no,no")])
;; vbrev.v vbrev8.v vrev8.v
(define_insn "@pred_v<rev><mode>"
--
2.34.1
next prev parent reply other threads:[~2024-04-22 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:47 pan2.li
2024-04-22 14:04 ` 钟居哲 [this message]
2024-04-22 16:57 ` Palmer Dabbelt
2024-04-22 19:55 ` Patrick O'Neill
2024-04-22 22:06 ` 钟居哲
2024-04-22 23:00 ` Li, Pan2
2024-04-23 0:31 ` Patrick O'Neill
2024-04-23 2:32 ` Li, Pan2
2024-04-23 6:50 ` Li, Pan2
2024-04-23 14:45 ` Patrick O'Neill
2024-04-23 17:00 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=084744A73FEA274D+202404222204040470506@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=pan2.li@intel.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).