RE: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

["Li, Pan2" <pan2.li@intel.com>]

Thanks Patrick.

Turn out that the make report cannot tell the error like below and then the graphite.exp test will never run.
That explains why I missed test failures, will take care of it ASAP.

sorry, unimplemented: Graphite loop optimizations cannot be used (isl is not available)

Pan

-----Original Message-----
From: Patrick O'Neill <patrick@rivosinc.com> 
Sent: Tuesday, April 23, 2024 8:32 AM
To: Li, Pan2 <pan2.li@intel.com>; gcc-patches@gcc.gnu.org
Cc: juzhe.zhong@rivai.ai; kito.cheng@gmail.com; rdapp.gcc@gmail.com
Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

This patch in particular does not cause any more regressions. It's one 
of the other reverts from the weekend.

Before the reverts [1]:
                                             |          gcc |          
g++ |     gfortran |
     rv64gcv/  lp64d/ medlow |   48/    32 |     12/    3|   12 /    2

After the reverts:
                                             |          gcc |          
g++ |     gfortran |
     rv64gcv/  lp64d/ medlow |   50 /    33 |   12 /     3 |   26 /     7 |


gcc new fails:
FAIL: gcc.dg/graphite/pr111878.c (internal compiler error: in 
extract_insn, at recog.cc:2812)
FAIL: gcc.dg/graphite/pr111878.c (test for excess errors)

gfortran new fails:
FAIL: gfortran.dg/graphite/id-27.f90   -O  (internal compiler error: in 
extract_insn, at recog.cc:2812)
FAIL: gfortran.dg/graphite/id-27.f90   -O  (test for excess errors)
FAIL: gfortran.dg/graphite/pr14741.f90   -O  (internal compiler error: 
in extract_insn, at recog.cc:2812)
FAIL: gfortran.dg/graphite/pr14741.f90   -O  (test for excess errors)
FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -fomit-frame-pointer 
-funroll-loops -fpeel-loops -ftracer -finline-functions  (internal 
compiler error: in extract_insn, at recog.cc:2812)
FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -fomit-frame-pointer 
-funroll-loops -fpeel-loops -ftracer -finline-functions  (test for 
excess errors)
FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -g  (internal compiler 
error: in extract_insn, at recog.cc:2812)
FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -g  (test for excess errors)
FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer 
-funroll-loops -fpeel-loops -ftracer -finline-functions  (internal 
compiler error: in extract_insn, at recog.cc:2812)
FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer 
-funroll-loops -fpeel-loops -ftracer -finline-functions  (test for 
excess errors)
FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -g  (internal compiler 
error: in extract_insn, at recog.cc:2812)
FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -g  (test for excess errors)
FAIL: gfortran.dg/graphite/vect-pr40979.f90   -O  (internal compiler 
error: in extract_insn, at recog.cc:2812)
FAIL: gfortran.dg/graphite/vect-pr40979.f90   -O  (test for excess errors)


For future reference, the precommit does not do well with many unrelated 
patches that are dependent on eachother.
In the future sending these as a series would allow precommit to 
properly test them (as always you can see the testing results on 
patchworks).

Thanks,
Patrick

[1] https://github.com/patrick-rivos/gcc-postcommit-ci/issues/801

On 4/22/24 12:55, Patrick O'Neill wrote:
> Hi Pan,
>
> I was running the testsuite for this and noticed an ICE scroll by when 
> this patch is applied to cacc55a4c0be8d0bc7417b6a28924eadbbe428e3 for 
> rv64gcv:
>
> FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer 
> -funroll-loops -fpeel-loops -ftracer -finline-functions  (internal 
> compiler error: in extract_insn, at recog.cc:2812)
>
> I'll send the full list of new failures once the runs finish.
>
> Thanks,
> Patrick
>
> On 4/22/24 06:47, pan2.li@intel.com wrote:
>> From: Pan Li <pan2.li@intel.com>
>>
>> After we reverted below 2 commits, the reference to attr need some
>> adjustment as the group_overlap is no longer available.
>>
>> * RISC-V: Robostify the W43, W86, W87 constraint enabled attribute
>> * RISC-V: Rename vconstraint into group_overlap
>>
>> The below tests are passed for this patch.
>>
>> * The rv64gcv fully regression tests.
>>
>> gcc/ChangeLog:
>>
>>     * config/riscv/vector-crypto.md:
>>
>> Signed-off-by: Pan Li <pan2.li@intel.com>
>> ---
>>   gcc/config/riscv/vector-crypto.md | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/config/riscv/vector-crypto.md 
>> b/gcc/config/riscv/vector-crypto.md
>> index 519c6a10d94..23dc549e5b8 100755
>> --- a/gcc/config/riscv/vector-crypto.md
>> +++ b/gcc/config/riscv/vector-crypto.md
>> @@ -322,7 +322,7 @@ (define_insn "@pred_vwsll<mode>_scalar"
>>     "vwsll.v%o4\t%0,%3,%4%p1"
>>     [(set_attr "type" "vwsll")
>>      (set_attr "mode" "<V_DOUBLE_TRUNC>")
>> -   (set_attr "group_overlap" 
>> "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,none,none")])
>> +   (set_attr "vconstraint" 
>> "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,no,no")])
>>     ;; vbrev.v vbrev8.v vrev8.v
>>   (define_insn "@pred_v<rev><mode>"