public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: pan2.li@intel.com
Cc: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai,
	Kito Cheng <kito.cheng@gmail.com>,
	Robin Dapp <rdapp.gcc@gmail.com>,
	pan2.li@intel.com
Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1
Date: Mon, 22 Apr 2024 09:57:39 -0700 (PDT)	[thread overview]
Message-ID: <mhng-eb5a86e0-8c3a-40c5-96d1-df667c79760d@palmer-ri-x1c9a> (raw)
In-Reply-To: <20240422134734.1909499-1-pan2.li@intel.com>

On Mon, 22 Apr 2024 06:47:34 PDT (-0700), pan2.li@intel.com wrote:
> From: Pan Li <pan2.li@intel.com>
>
> After we reverted below 2 commits, the reference to attr need some
> adjustment as the group_overlap is no longer available.
>
> * RISC-V: Robostify the W43, W86, W87 constraint enabled attribute
> * RISC-V: Rename vconstraint into group_overlap

That landed as cacc55a4c0b ("Revert "RISC-V: Rename vconstraint into 
group_overlap""), but I can't find a review on the lists and the commit 
appears to not even build.

Did I miss the reviews or something?

> The below tests are passed for this patch.
>
> * The rv64gcv fully regression tests.
>
> gcc/ChangeLog:
>
> 	* config/riscv/vector-crypto.md:
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
> ---
>  gcc/config/riscv/vector-crypto.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/vector-crypto.md b/gcc/config/riscv/vector-crypto.md
> index 519c6a10d94..23dc549e5b8 100755
> --- a/gcc/config/riscv/vector-crypto.md
> +++ b/gcc/config/riscv/vector-crypto.md
> @@ -322,7 +322,7 @@ (define_insn "@pred_vwsll<mode>_scalar"
>    "vwsll.v%o4\t%0,%3,%4%p1"
>    [(set_attr "type" "vwsll")
>     (set_attr "mode" "<V_DOUBLE_TRUNC>")
> -   (set_attr "group_overlap" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,none,none")])
> +   (set_attr "vconstraint" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,no,no")])
>
>  ;; vbrev.v vbrev8.v vrev8.v
>  (define_insn "@pred_v<rev><mode>"

  parent reply	other threads:[~2024-04-22 16:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 13:47 pan2.li
2024-04-22 14:04 ` 钟居哲
2024-04-22 16:57 ` Palmer Dabbelt [this message]
2024-04-22 19:55 ` Patrick O'Neill
2024-04-22 22:06   ` 钟居哲
2024-04-22 23:00     ` Li, Pan2
2024-04-23  0:31   ` Patrick O'Neill
2024-04-23  2:32     ` Li, Pan2
2024-04-23  6:50       ` Li, Pan2
2024-04-23 14:45         ` Patrick O'Neill
2024-04-23 17:00           ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-eb5a86e0-8c3a-40c5-96d1-df667c79760d@palmer-ri-x1c9a \
    --to=palmer@dabbelt.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    --cc=pan2.li@intel.com \
    --cc=rdapp.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).