[Patch testsuite obvious] g++.dg/ext/pr57735.C should not run if the testsuite is explicitly passing -mfloat-abi=hard

[Patch testsuite obvious] g++.dg/ext/pr57735.C should not run if the testsuite is explicitly passing -mfloat-abi=hard

[James Greenhalgh]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]


Hi,

g++.dg/ext/pr57735.C is failing for test runs which explicitly pass
-mfloat-abi=hard. Looking at the test, it seems the best fix would be
to check before adding -mfloat-abi=soft that we are not testing some other
float-abi. We also fail to check that it is OK to add -march=armv5te
and -marm.

Fixed using the same mechanisms we use elsewhere in the gcc.target/arm/
tests with the attached, applied as obvious as revision 224280.

Thanks,
James

---
gcc/testsuite/

2015-06-09  James Greenhalgh  <james.greenhalgh@arm.com>

	* g++.dg/ext/pr57735.C: Do not override -mfloat-abi directives
	passed by the testsuite driver.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Patch-testsuite-obvious-g-.dg-ext-pr57735.C-should-n.patch --]
[-- Type: text/x-patch;  name=0001-Patch-testsuite-obvious-g-.dg-ext-pr57735.C-should-n.patch, Size: 593 bytes --]

diff --git a/gcc/testsuite/g++.dg/ext/pr57735.C b/gcc/testsuite/g++.dg/ext/pr57735.C
index 0eb9500..a8f7d05 100644
--- a/gcc/testsuite/g++.dg/ext/pr57735.C
+++ b/gcc/testsuite/g++.dg/ext/pr57735.C
@@ -1,4 +1,7 @@
 /* { dg-do compile { target arm*-*-* } } */
+/* { dg-require-effective-target arm_arch_v5te_ok } */
+/* { dg-require-effective-target arm_arm_ok } */
+/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } {"-mfloat-abi=soft" } } */
 /* { dg-options "-march=armv5te -marm  -mtune=xscale -mfloat-abi=soft -O1" } */
 
 typedef unsigned int size_t;

[Patch testsuite obvious][gcc-5] g++.dg/ext/pr57735.C should not run if the testsuite is explicitly passing -mfloat-abi=hard

[Andre Vieira (lists)]

On 09/06/15 14:07, James Greenhalgh wrote:
> 
> Hi,
> 
> g++.dg/ext/pr57735.C is failing for test runs which explicitly pass
> -mfloat-abi=hard. Looking at the test, it seems the best fix would be
> to check before adding -mfloat-abi=soft that we are not testing some other
> float-abi. We also fail to check that it is OK to add -march=armv5te
> and -marm.
> 
> Fixed using the same mechanisms we use elsewhere in the gcc.target/arm/
> tests with the attached, applied as obvious as revision 224280.
> 
> Thanks,
> James
> 
> ---
> gcc/testsuite/
> 
> 2015-06-09  James Greenhalgh  <james.greenhalgh@arm.com>
> 
> 	* g++.dg/ext/pr57735.C: Do not override -mfloat-abi directives
> 	passed by the testsuite driver.
> 

Thomas committed this on my behalf to gcc-5-branch as obvious as
revision r234326.

Cheers,
Andre