From: Jan Hubicka <hubicka@ucw.cz>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jan Hubicka <hubicka@ucw.cz>, gcc-patches@gcc.gnu.org
Subject: Re: Cgraph alias reorg 15/14 (New infrastructure for same body aliases)
Date: Sun, 12 Jun 2011 17:06:00 -0000 [thread overview]
Message-ID: <20110612163302.GD19441@kam.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTi=dv6ZauuJzSy9vgN713cCLg8ObvA@mail.gmail.com>
> On Sun, Jun 12, 2011 at 7:54 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
> >>
> >> This also pretty much destroyed C++ for ia32:
> >>
> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49378
> >> http://gcc.gnu.org/ml/gcc-regression/2011-06/msg00159.html
> >
> > Hi,
> > It seems somewhat amazing that we hit kernel sensitive miscompilation here.
> > The problem most probably is the fact that thunks and functions with thunks can become
> > local. This is correct since thunks are represented as direct calls now, but this
> > makes i386 to use local ABI when calling or compiling them.
> >
>
> For x86-64, we use the same ABI for local and global. But RAX seems
> used and uninitialized in thunk.
000000000006d270 <_ZN12_GLOBAL__N_121system_error_categoryD0Ev>:
6d270: 48 8d 05 79 d4 27 00 lea 0x27d479(%rip),%rax #
2ea6f0 <_ZTVN12_GLOBAL__N_121system_error_categoryE+0x10>
6d277: 53 push %rbx
6d278: 48 89 fb mov %rdi,%rbx
6d27b: 48 89 07 mov %rax,(%rdi)
6d27e: e8 55 a0 fe ff callq 572d8
<_ZNSt14error_categoryD2Ev@plt>
6d283: 48 89 df mov %rbx,%rdi
6d286: 5b pop %rbx
6d287: e9 2c 9d fe ff jmpq 56fb8 <_ZdlPv@plt>
6d28c: 90 nop
6d28d: 90 nop
6d28e: 90 nop
6d28f: 90 nop
I don't see uinitialized RAX here. It is set by the first LEA
I will commit the patch now to unbreak x86 and work on more proper solution after debugging
the plugin usses.
Thanks for testing!
Honza
>
> --
> H.J.
next prev parent reply other threads:[~2011-06-12 16:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 14:22 Jan Hubicka
2011-06-11 17:31 ` H.J. Lu
2011-06-12 9:02 ` H.J. Lu
2011-06-12 15:08 ` Jan Hubicka
2011-06-12 15:45 ` H.J. Lu
2011-06-12 15:55 ` Jan Hubicka
2011-06-12 16:33 ` H.J. Lu
2011-06-12 16:29 ` H.J. Lu
2011-06-12 17:06 ` Jan Hubicka [this message]
2011-06-12 17:46 ` H.J. Lu
2011-06-12 17:13 ` Jan Hubicka
2011-06-12 18:07 ` H.J. Lu
2011-06-12 22:11 ` Jan Hubicka
2011-06-19 12:52 ` Hans-Peter Nilsson
2011-06-19 12:55 ` Jan Hubicka
2011-06-19 14:04 ` Jan Hubicka
2011-06-20 11:23 ` Richard Guenther
2011-06-20 14:47 ` Hans-Peter Nilsson
2011-06-22 21:54 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110612163302.GD19441@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).