public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jan Hubicka <hubicka@ucw.cz>, gcc-patches@gcc.gnu.org
Subject: Re: Cgraph alias reorg 15/14 (New infrastructure for same body	aliases)
Date: Sun, 12 Jun 2011 22:11:00 -0000	[thread overview]
Message-ID: <20110612174558.GA10123@kam.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTi=meoyZyVVCDz4nXi28YgZHCjGihw@mail.gmail.com>

Hi,
this patch solves the bultin/strlen-3.c LTO linker plugin problem.
While removing alias code I was bit overactive and removed the check that makes us to implicitly
do -fwhole-program when resolution info is around.

It is not quite clear to me why in LTO we need -fwhole-program to get the testcase right.
Bootstrap/regtest in progress, will commit it once it passes.

        * ipa.c (cgraph_exernally_visible_p): Return accidentally removed check
        for LDPR_PREVAILING_DEF_IRONLY.
Index: ipa.c
===================================================================
--- ipa.c       (revision 174955)
+++ ipa.c       (working copy)
@@ -614,6 +614,8 @@
   /* If linker counts on us, we must preserve the function.  */
   if (cgraph_used_from_object_file_p (node))
     return true;
+  if (node->resolution == LDPR_PREVAILING_DEF_IRONLY)
+    return false;
   if (DECL_PRESERVE_P (node->decl))
     return true;
   if (lookup_attribute ("externally_visible", DECL_ATTRIBUTES (node->decl)))

  reply	other threads:[~2011-06-12 17:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11 14:22 Jan Hubicka
2011-06-11 17:31 ` H.J. Lu
2011-06-12  9:02   ` H.J. Lu
2011-06-12 15:08     ` Jan Hubicka
2011-06-12 15:45       ` H.J. Lu
2011-06-12 15:55         ` Jan Hubicka
2011-06-12 16:33         ` H.J. Lu
2011-06-12 16:29       ` H.J. Lu
2011-06-12 17:06         ` Jan Hubicka
2011-06-12 17:46           ` H.J. Lu
2011-06-12 17:13         ` Jan Hubicka
2011-06-12 18:07           ` H.J. Lu
2011-06-12 22:11             ` Jan Hubicka [this message]
2011-06-19 12:52 ` Hans-Peter Nilsson
2011-06-19 12:55   ` Jan Hubicka
2011-06-19 14:04     ` Jan Hubicka
2011-06-20 11:23       ` Richard Guenther
2011-06-20 14:47         ` Hans-Peter Nilsson
2011-06-22 21:54       ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110612174558.GA10123@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).