public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Cgraph alias reorg 15/14 (New infrastructure for same body aliases)
Date: Wed, 22 Jun 2011 21:54:00 -0000	[thread overview]
Message-ID: <alpine.BSF.2.00.1106221734390.37880@dair.pair.com> (raw)
In-Reply-To: <20110619125142.GA22865@kam.mff.cuni.cz>

On Sun, 19 Jun 2011, Jan Hubicka wrote:
> > > On Sat, 11 Jun 2011, Jan Hubicka wrote:
> > >
> > > > Hi,
> > > > this patch complettes the same body alias rework by removing the old same body
> > > > alias code and adding new representation.  Same body aliases are now separate
> > > > function nodes that have IPA_REF_ALIAS reference to the node they are alias of.
> > > >
> > > > I am still getting one failure:
> > > > FAIL: g++.dg/torture/pr43879-1_1.C
> > > >
> > > > It tests IPA PTA in presence of same body aliases.  I honestly have no idea
> > > > what is wrong there.  I decided to go ahead with the patch anyway, given the
> > > > current state of affair of aliases and IPA-PTA. Hope Richard will help me
> > > > fixing this on Monday.
> > >
> > > Still there, see again PR49373.  Anything better than a xfail in the works?
> >
> > Yes, we discussed the problem with Richi and the issue is that ipa-pta gets
> > confused by inliner redirecting edge from alias to the real inline clone.
> > The proper fix is to teach passmanager to do small ipa passes before final
> > compilation.  I am currently at the GCC gathering, so I plan to implement
> > this day after tomorrow after returning.
> But for sure we can xfail it.

Ok, done:

	PR middle-end/49373
	* g++.dg/torture/pr43879-1_1.C: Xfail for -O1 and above, except -flto.

Index: g++.dg/torture/pr43879-1_1.C
===================================================================
--- g++.dg/torture/pr43879-1_1.C	(revision 174961)
+++ g++.dg/torture/pr43879-1_1.C	(working copy)
@@ -1,6 +1,7 @@
 /* { dg-do run } */
 /* { dg-options "-fipa-pta" } */
 /* { dg-additional-sources "pr43879-1_0.C" } */
+/* { dg-xfail-run-if "PR49373" { *-*-* } { -O1 -O2 -O3 -Os } { -flto } } */

 struct A {
     int *i;

brgds, H-P

      parent reply	other threads:[~2011-06-22 21:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11 14:22 Jan Hubicka
2011-06-11 17:31 ` H.J. Lu
2011-06-12  9:02   ` H.J. Lu
2011-06-12 15:08     ` Jan Hubicka
2011-06-12 15:45       ` H.J. Lu
2011-06-12 15:55         ` Jan Hubicka
2011-06-12 16:33         ` H.J. Lu
2011-06-12 16:29       ` H.J. Lu
2011-06-12 17:06         ` Jan Hubicka
2011-06-12 17:46           ` H.J. Lu
2011-06-12 17:13         ` Jan Hubicka
2011-06-12 18:07           ` H.J. Lu
2011-06-12 22:11             ` Jan Hubicka
2011-06-19 12:52 ` Hans-Peter Nilsson
2011-06-19 12:55   ` Jan Hubicka
2011-06-19 14:04     ` Jan Hubicka
2011-06-20 11:23       ` Richard Guenther
2011-06-20 14:47         ` Hans-Peter Nilsson
2011-06-22 21:54       ` Hans-Peter Nilsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.00.1106221734390.37880@dair.pair.com \
    --to=hp@bitrange.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).