From: Segher Boessenkool <segher@kernel.crashing.org>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"Kewen.Lin" <linkw@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH, rs6000] Cleanup some vstrir define_expand naming inconsistencies
Date: Wed, 13 Jul 2022 14:39:07 -0500 [thread overview]
Message-ID: <20220713193907.GU25951@gate.crashing.org> (raw)
In-Reply-To: <6da1e35def9d282bcf87483e78cf578fff604723.camel@vnet.ibm.com>
Hi!
On Wed, Jul 13, 2022 at 01:18:29PM -0500, will schmidt wrote:
> This cleans up some of the naming around the vstrir and vstril
> instruction definitions, with some cosmetic changes for consistency.
> gcc/
> * config/rs6000/altivec.md (vstrir_code_<mode>): Rename
> to vstrir_internal_<mode>.
> (vstrir_p_code_<mode>): Rename to vstrir_p_internal_<mode>.
> (vstril_code_<mode>): Rename to vstril_internal_<mode>.
> (vstril_p_code_<mode>): Rename to vstril_p_internal_<mode>.
It doesn't show the new names on the lhs this way. One way to do
better
is to write e.g.
(vstril_code_<mode>): Rename to...
(vstril_internal_<mode>): ... this.
It often is a good idea to say "...<mode> for VIshort" and similar btw.
I'm not a fan of "internal" either, it doesn't say anything. At least
put it at the very end of the names please?
Okay for trunk with that changed. Thanks!
Segher
next prev parent reply other threads:[~2022-07-13 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 18:18 will schmidt
2022-07-13 19:39 ` Segher Boessenkool [this message]
2022-07-13 21:14 ` will schmidt
2022-07-13 21:26 ` Segher Boessenkool
2022-07-19 20:14 ` [PATCH, rs6000, v2] " will schmidt
2022-07-20 22:15 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713193907.GU25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).