Re: [PATCH, rs6000] Cleanup some vstrir define_expand naming inconsistencies

[will schmidt <will_schmidt@vnet.ibm.com>]

On Wed, 2022-07-13 at 14:39 -0500, Segher Boessenkool wrote:
> Hi!
> 
> On Wed, Jul 13, 2022 at 01:18:29PM -0500, will schmidt wrote:
> >   This cleans up some of the naming around the vstrir and vstril
> > instruction definitions, with some cosmetic changes for
> > consistency.
> > gcc/
> > 	* config/rs6000/altivec.md (vstrir_code_<mode>): Rename
> > 	to vstrir_internal_<mode>.
> > 	(vstrir_p_code_<mode>): Rename to vstrir_p_internal_<mode>.
> > 	(vstril_code_<mode>): Rename to vstril_internal_<mode>.
> > 	(vstril_p_code_<mode>): Rename to vstril_p_internal_<mode>.
> 
> It doesn't show the new names on the lhs this way.  One way to do
> better
> is to write e.g.
> 	(vstril_code_<mode>): Rename to...
> 	(vstril_internal_<mode>): ... this.

Ok.

> 
> It often is a good idea to say "...<mode> for VIshort" and similar
> btw.

Ok. 

> 
> I'm not a fan of "internal" either, it doesn't say anything.  At
> least
> put it at the very end of the names please?
I'm easily convinced. ;-)  I wonder if I should just drop "_internal"
entirely and go with "vstrir_<mode>".  Otherwise I'll rework to be
"vstrir_<mode>_internal".
At a glance I see we do have some other existing define_insn entries
with _internal at the tail and a few others embedded in the middle. 
I'll leave a note and perhaps review those after.  :-)

Thanks,
-Will

> 
> Okay for trunk with that changed.  Thanks!
> 
> 
> Segher