From: Segher Boessenkool <segher@kernel.crashing.org>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"Kewen.Lin" <linkw@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH, rs6000] Cleanup some vstrir define_expand naming inconsistencies
Date: Wed, 13 Jul 2022 16:26:30 -0500 [thread overview]
Message-ID: <20220713212630.GV25951@gate.crashing.org> (raw)
In-Reply-To: <683bc5104bb58cf5e28e3ae8b3560a1ba9bf6cd1.camel@vnet.ibm.com>
On Wed, Jul 13, 2022 at 04:14:11PM -0500, will schmidt wrote:
> On Wed, 2022-07-13 at 14:39 -0500, Segher Boessenkool wrote:
> > I'm not a fan of "internal" either, it doesn't say anything. At
> > least
> > put it at the very end of the names please?
> I'm easily convinced. ;-) I wonder if I should just drop "_internal"
> entirely and go with "vstrir_<mode>". Otherwise I'll rework to be
> "vstrir_<mode>_internal".
The define_expand already uses that name. Some other patterns in
altivec.md use *_direct, maybe that is nicer?
> At a glance I see we do have some other existing define_insn entries
> with _internal at the tail and a few others embedded in the middle.
> I'll leave a note and perhaps review those after. :-)
Thanks :-)
Segher
next prev parent reply other threads:[~2022-07-13 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 18:18 will schmidt
2022-07-13 19:39 ` Segher Boessenkool
2022-07-13 21:14 ` will schmidt
2022-07-13 21:26 ` Segher Boessenkool [this message]
2022-07-19 20:14 ` [PATCH, rs6000, v2] " will schmidt
2022-07-20 22:15 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713212630.GV25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).