From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Andreas Krebbel <krebbel@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH] PR106342 - IBM zSystems: Provide vsel for all vector modes
Date: Wed, 3 Aug 2022 12:20:39 +0200 [thread overview]
Message-ID: <20220803102039.514517-1-iii@linux.ibm.com> (raw)
Bootstrapped and regtested on s390x-redhat-linux. Ok for master?
dg.exp=pr104612.c fails with an ICE on s390x, because copysignv2sf3
produces an insn that vsel<mode> is supposed to recognize, but can't,
because it's not defined for V2SF. Fix by defining it for all vector
modes supported by copysign<mode>3.
gcc/ChangeLog:
* config/s390/vector.md (V_HW_FT): New iterator.
* config/s390/vx-builtins.md (vsel<mode>): Use V instead of
V_HW.
---
gcc/config/s390/vector.md | 6 ++++++
gcc/config/s390/vx-builtins.md | 12 ++++++------
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md
index a6c4b4eb974..624729814af 100644
--- a/gcc/config/s390/vector.md
+++ b/gcc/config/s390/vector.md
@@ -63,6 +63,12 @@
V1DF V2DF
(V1TF "TARGET_VXE") (TF "TARGET_VXE")])
+; All modes present in V_HW and VFT.
+(define_mode_iterator V_HW_FT [V16QI V8HI V4SI V2DI (V1TI "TARGET_VXE") V1DF
+ V2DF (V1SF "TARGET_VXE") (V2SF "TARGET_VXE")
+ (V4SF "TARGET_VXE") (V1TF "TARGET_VXE")
+ (TF "TARGET_VXE")])
+
; FP vector modes directly supported by the HW. This does not include
; vector modes using only part of a vector register and should be used
; for instructions which might trigger IEEE exceptions.
diff --git a/gcc/config/s390/vx-builtins.md b/gcc/config/s390/vx-builtins.md
index d5130799804..98ee08b2683 100644
--- a/gcc/config/s390/vx-builtins.md
+++ b/gcc/config/s390/vx-builtins.md
@@ -517,12 +517,12 @@
; swapped in s390-c.cc when we get here.
(define_insn "vsel<mode>"
- [(set (match_operand:V_HW 0 "register_operand" "=v")
- (ior:V_HW
- (and:V_HW (match_operand:V_HW 1 "register_operand" "v")
- (match_operand:V_HW 3 "register_operand" "v"))
- (and:V_HW (not:V_HW (match_dup 3))
- (match_operand:V_HW 2 "register_operand" "v"))))]
+ [(set (match_operand:V_HW_FT 0 "register_operand" "=v")
+ (ior:V_HW_FT
+ (and:V_HW_FT (match_operand:V_HW_FT 1 "register_operand" "v")
+ (match_operand:V_HW_FT 3 "register_operand" "v"))
+ (and:V_HW_FT (not:V_HW_FT (match_dup 3))
+ (match_operand:V_HW_FT 2 "register_operand" "v"))))]
"TARGET_VX"
"vsel\t%v0,%1,%2,%3"
[(set_attr "op_type" "VRR")])
--
2.35.3
next reply other threads:[~2022-08-03 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 10:20 Ilya Leoshkevich [this message]
2022-08-03 13:41 ` Andreas Krebbel
2022-08-10 11:42 ` Ilya Leoshkevich
2022-08-11 5:45 ` Andreas Krebbel
2022-08-17 13:01 ` Ilya Leoshkevich
2022-08-18 6:44 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803102039.514517-1-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=krebbel@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).