From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Andreas Krebbel <krebbel@linux.ibm.com>,
Jakub Jelinek <jakub@redhat.com>,
Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR106342 - IBM zSystems: Provide vsel for all vector modes
Date: Wed, 17 Aug 2022 15:01:54 +0200 [thread overview]
Message-ID: <b58d7c605539a759126e0daf28b8270573b30ea8.camel@linux.ibm.com> (raw)
In-Reply-To: <bb054111-e218-3254-902b-03bdf78a5487@linux.ibm.com>
On Thu, 2022-08-11 at 07:45 +0200, Andreas Krebbel wrote:
> On 8/10/22 13:42, Ilya Leoshkevich wrote:
> > On Wed, 2022-08-03 at 12:20 +0200, Ilya Leoshkevich wrote:
> > > Bootstrapped and regtested on s390x-redhat-linux. Ok for master?
> > >
> > >
> > >
> > > dg.exp=pr104612.c fails with an ICE on s390x, because
> > > copysignv2sf3
> > > produces an insn that vsel<mode> is supposed to recognize, but
> > > can't,
> > > because it's not defined for V2SF. Fix by defining it for all
> > > vector
> > > modes supported by copysign<mode>3.
> > >
> > > gcc/ChangeLog:
> > >
> > > * config/s390/vector.md (V_HW_FT): New iterator.
> > > * config/s390/vx-builtins.md (vsel<mode>): Use V instead
> > > of
> > > V_HW.
> > > ---
> > > gcc/config/s390/vector.md | 6 ++++++
> > > gcc/config/s390/vx-builtins.md | 12 ++++++------
> > > 2 files changed, 12 insertions(+), 6 deletions(-)
> >
> > Jakub pointed out that this is broken in gcc-12 as well.
> > The patch applies cleanly, and I started a bootstrap/regtest.
> > Ok for gcc-12?
>
> Yes. Thanks!
>
> Andreas
Hi,
I've committed this today without realizing that gcc-12 branch is
closed. Sorry! Please let me know if I should revert this.
Best regards,
Ilya
next prev parent reply other threads:[~2022-08-17 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 10:20 Ilya Leoshkevich
2022-08-03 13:41 ` Andreas Krebbel
2022-08-10 11:42 ` Ilya Leoshkevich
2022-08-11 5:45 ` Andreas Krebbel
2022-08-17 13:01 ` Ilya Leoshkevich [this message]
2022-08-18 6:44 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b58d7c605539a759126e0daf28b8270573b30ea8.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=krebbel@linux.ibm.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).