Re: [PATCH] PR106342 - IBM zSystems: Provide vsel for all vector modes

[Richard Biener <rguenther@suse.de>]

On Wed, 17 Aug 2022, Ilya Leoshkevich wrote:

> On Thu, 2022-08-11 at 07:45 +0200, Andreas Krebbel wrote:
> > On 8/10/22 13:42, Ilya Leoshkevich wrote:
> > > On Wed, 2022-08-03 at 12:20 +0200, Ilya Leoshkevich wrote:
> > > > Bootstrapped and regtested on s390x-redhat-linux.  Ok for master?
> > > > 
> > > > 
> > > > 
> > > > dg.exp=pr104612.c fails with an ICE on s390x, because
> > > > copysignv2sf3
> > > > produces an insn that vsel<mode> is supposed to recognize, but
> > > > can't,
> > > > because it's not defined for V2SF.  Fix by defining it for all
> > > > vector
> > > > modes supported by copysign<mode>3.
> > > > 
> > > > gcc/ChangeLog:
> > > > 
> > > >         * config/s390/vector.md (V_HW_FT): New iterator.
> > > >         * config/s390/vx-builtins.md (vsel<mode>): Use V instead
> > > > of
> > > >         V_HW.
> > > > ---
> > > >  gcc/config/s390/vector.md      |  6 ++++++
> > > >  gcc/config/s390/vx-builtins.md | 12 ++++++------
> > > >  2 files changed, 12 insertions(+), 6 deletions(-)
> > > 
> > > Jakub pointed out that this is broken in gcc-12 as well.
> > > The patch applies cleanly, and I started a bootstrap/regtest.
> > > Ok for gcc-12?
> > 
> > Yes. Thanks!
> > 
> > Andreas
> 
> Hi,
> 
> I've committed this today without realizing that gcc-12 branch is
> closed.  Sorry!  Please let me know if I should revert this.

It doesn't look too risky, so leave it in.

Richard.