* [PATCH] Add --without-makeinfo
@ 2022-10-04 15:21 Tom de Vries
2022-10-09 17:02 ` Eric Gallager
2022-10-09 17:27 ` Andreas Schwab
0 siblings, 2 replies; 3+ messages in thread
From: Tom de Vries @ 2022-10-04 15:21 UTC (permalink / raw)
To: gcc-patches
Hi,
Currently, we cannot build gdb without makeinfo installed.
It would be convenient to work around this by using the configure flag
MAKEINFO=/usr/bin/true or some such, but that doesn't work because top-level
configure requires a makeinfo of at least version 4.7, and that version check
fails for /usr/bin/true, so we end up with MAKEINFO=missing instead.
What does work is this:
...
$ ./configure
$ make MAKEINFO=/usr/bin/true
...
but the drawback is that it'll have to be specified for each make invocation.
Fix this by adding support for --without-makeinfo in top-level configure.
Tested by building gdb on x86_64-linux, and verifying that no .info files
were generated.
OK for trunk?
Thanks,
- Tom
Add --without-makeinfo
ChangeLog:
2022-09-05 Tom de Vries <tdevries@suse.de>
* configure.ac: Add --without-makeinfo.
* configure: Regenerate.
---
configure | 4 ++++
configure.ac | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/configure b/configure
index f14e0efd675..eb84add60cb 100755
--- a/configure
+++ b/configure
@@ -8399,6 +8399,9 @@ fi
done
test -n "$MAKEINFO" || MAKEINFO="$MISSING makeinfo"
+if test $with_makeinfo = "no"; then
+MAKEINFO=true
+else
case " $build_configdirs " in
*" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;;
*)
@@ -8414,6 +8417,7 @@ case " $build_configdirs " in
;;
esac
+fi
# FIXME: expect and dejagnu may become build tools?
diff --git a/configure.ac b/configure.ac
index 0152c69292e..e4a2c076674 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3441,6 +3441,9 @@ case " $build_configdirs " in
esac
AC_CHECK_PROGS([MAKEINFO], makeinfo, [$MISSING makeinfo])
+if test $with_makeinfo = "no"; then
+MAKEINFO=true
+else
case " $build_configdirs " in
*" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;;
*)
@@ -3456,6 +3459,7 @@ changequote(,)
;;
changequote([,])
esac
+fi
# FIXME: expect and dejagnu may become build tools?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add --without-makeinfo
2022-10-04 15:21 [PATCH] Add --without-makeinfo Tom de Vries
@ 2022-10-09 17:02 ` Eric Gallager
2022-10-09 17:27 ` Andreas Schwab
1 sibling, 0 replies; 3+ messages in thread
From: Eric Gallager @ 2022-10-09 17:02 UTC (permalink / raw)
To: Tom de Vries; +Cc: gcc-patches
On Tue, Oct 4, 2022 at 11:22 AM Tom de Vries via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> Currently, we cannot build gdb without makeinfo installed.
>
> It would be convenient to work around this by using the configure flag
> MAKEINFO=/usr/bin/true or some such, but that doesn't work because top-level
> configure requires a makeinfo of at least version 4.7, and that version check
> fails for /usr/bin/true, so we end up with MAKEINFO=missing instead.
>
> What does work is this:
> ...
> $ ./configure
> $ make MAKEINFO=/usr/bin/true
> ...
> but the drawback is that it'll have to be specified for each make invocation.
>
> Fix this by adding support for --without-makeinfo in top-level configure.
>
> Tested by building gdb on x86_64-linux, and verifying that no .info files
> were generated.
>
> OK for trunk?
>
> Thanks,
> - Tom
>
> Add --without-makeinfo
>
> ChangeLog:
>
> 2022-09-05 Tom de Vries <tdevries@suse.de>
>
> * configure.ac: Add --without-makeinfo.
> * configure: Regenerate.
>
> ---
> configure | 4 ++++
> configure.ac | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/configure b/configure
> index f14e0efd675..eb84add60cb 100755
> --- a/configure
> +++ b/configure
> @@ -8399,6 +8399,9 @@ fi
> done
> test -n "$MAKEINFO" || MAKEINFO="$MISSING makeinfo"
>
> +if test $with_makeinfo = "no"; then
> +MAKEINFO=true
> +else
> case " $build_configdirs " in
> *" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;;
> *)
> @@ -8414,6 +8417,7 @@ case " $build_configdirs " in
> ;;
>
> esac
> +fi
>
> # FIXME: expect and dejagnu may become build tools?
>
> diff --git a/configure.ac b/configure.ac
> index 0152c69292e..e4a2c076674 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3441,6 +3441,9 @@ case " $build_configdirs " in
> esac
>
> AC_CHECK_PROGS([MAKEINFO], makeinfo, [$MISSING makeinfo])
A new configure flag starting with the "--with-" prefix should use the
AC_ARG_WITH autoconf macro, along with the AS_HELP_STRING macro so
that it shows up in `./configure --help`. Check other places where
AC_ARG_WITH is used in configure.ac to see how it's done. Also, the
new option should be documented in install.texi as well.
> +if test $with_makeinfo = "no"; then
> +MAKEINFO=true
> +else
> case " $build_configdirs " in
> *" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;;
> *)
> @@ -3456,6 +3459,7 @@ changequote(,)
> ;;
> changequote([,])
> esac
> +fi
>
> # FIXME: expect and dejagnu may become build tools?
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add --without-makeinfo
2022-10-04 15:21 [PATCH] Add --without-makeinfo Tom de Vries
2022-10-09 17:02 ` Eric Gallager
@ 2022-10-09 17:27 ` Andreas Schwab
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Schwab @ 2022-10-09 17:27 UTC (permalink / raw)
To: Tom de Vries via Gcc-patches; +Cc: Tom de Vries
On Okt 04 2022, Tom de Vries via Gcc-patches wrote:
> diff --git a/configure.ac b/configure.ac
> index 0152c69292e..e4a2c076674 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3441,6 +3441,9 @@ case " $build_configdirs " in
> esac
>
> AC_CHECK_PROGS([MAKEINFO], makeinfo, [$MISSING makeinfo])
> +if test $with_makeinfo = "no"; then
Quoting is backwards. You should quote the variable substitution, not
the literal.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-09 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 15:21 [PATCH] Add --without-makeinfo Tom de Vries
2022-10-09 17:02 ` Eric Gallager
2022-10-09 17:27 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).