From: Jeff Law <jeffreyalaw@gmail.com>
To: Yixuan Chen <chenyixuan@iscas.ac.cn>, gcc-patches@gcc.gnu.org
Cc: kito.cheng@gmail.com, andrew@sifive.com, oriachiuan@gmail.com
Subject: Re: [PATCH] Ver.2: Add compile option "-msmall-data-limit=0" to avoid using .srodata section for riscv.
Date: Thu, 17 Nov 2022 14:50:00 -0700 [thread overview]
Message-ID: <36c502d5-a556-ab12-5466-32c112a2242f@gmail.com> (raw)
In-Reply-To: <20221117095355.1928564-1-chenyixuan@iscas.ac.cn>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On 11/17/22 02:53, Yixuan Chen wrote:
> 2022-11-17 Yixuan Chen <chenyixuan@iscas.ac.cn>
>
> * gcc/testsuite/gcc.dg/pr25521.c: Add compile option "-msmall-data-limit=0" to avoid using .srodata section for riscv.
> ---
> gcc/testsuite/gcc.dg/pr25521.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c
> index 74fe2ae6626..628ddf1a761 100644
> --- a/gcc/testsuite/gcc.dg/pr25521.c
> +++ b/gcc/testsuite/gcc.dg/pr25521.c
> @@ -2,7 +2,8 @@
> sections.
>
> { dg-require-effective-target elf }
> - { dg-do compile } */
> + { dg-do compile }
> + { dg-options "-msmall-data-limit=0" { target { riscv*-*-* } } } */
>
> const volatile int foo = 30;
>
Wouldn't this be better? It avoids a target specific conditional by
instead extending what we look for to cover [s]rodata sections.
Thoughts?
Jeff
[-- Attachment #2: P --]
[-- Type: text/plain, Size: 344 bytes --]
diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c
index 74fe2ae6626..63363a03b9f 100644
--- a/gcc/testsuite/gcc.dg/pr25521.c
+++ b/gcc/testsuite/gcc.dg/pr25521.c
@@ -7,4 +7,4 @@
const volatile int foo = 30;
-/* { dg-final { scan-assembler "\\.rodata" } } */
+/* { dg-final { scan-assembler "\\.s\?rodata" } } */
next prev parent reply other threads:[~2022-11-17 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 9:53 Yixuan Chen
2022-11-17 21:50 ` Jeff Law [this message]
2022-11-17 23:59 ` Palmer Dabbelt
2022-11-18 3:30 ` Oria Chiuan
2022-11-18 5:02 ` Palmer Dabbelt
2022-11-18 5:21 ` Oria Chiuan
2022-11-18 5:52 ` 陈逸轩
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c502d5-a556-ab12-5466-32c112a2242f@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew@sifive.com \
--cc=chenyixuan@iscas.ac.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=oriachiuan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).