From: Vineet Gupta <vineetg@rivosinc.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@gmail.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
philipp.tomsich@vrull.eu, christoph.muellner@vrull.eu,
collison@rivosinc.com, gnu-toolchain@rivosinc.com
Subject: Re: [PATCH 2/2] RISC-V: remove CM_PIC as it doesn't do much
Date: Wed, 31 Aug 2022 13:39:45 -0700 [thread overview]
Message-ID: <376353ac-6bfc-05c9-cb32-85e87eec177d@rivosinc.com> (raw)
In-Reply-To: <mhng-74ad288d-c4ac-46d1-905a-fe1f83752c7a@palmer-mbp2014>
On 8/31/22 07:57, Palmer Dabbelt wrote:
>> if (flag_pic)
>> - riscv_cmodel = CM_PIC;
>> + riscv_cmodel = CM_MEDANY;
>>
>> /* We get better code with explicit relocs for CM_MEDLOW, but
>> worse code for the others (for now). Pick the best default. */
>
> I'm fine either way on this one: having CM_PIC gone makes it a bit
> more likely to confuse CM_MEDANY with PIC, but flag_pic is overriding
> riscv_cmodel anyway so this isn't really used and deleting code is
> always a plus.
Indeed this was the most contentious part of removing CM_PIC, but it
seems this is the way fwd. I'll add Kito's comment from [1] in code to
make it more explicit.
[1]https://github.com/riscv-non-isa/riscv-c-api-doc/pull/11#issuecomment-686385585
Thx,
-Vineett
next prev parent reply other threads:[~2022-08-31 20:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 17:48 [PATCH 0/2] PIC cleanup Vineet Gupta
2022-08-30 17:48 ` [PATCH 1/2] RISC-V: remove deprecate pic code model macro Vineet Gupta
2022-08-31 14:57 ` Palmer Dabbelt
2022-08-31 15:35 ` Kito Cheng
2022-09-02 20:33 ` [PATCH v2] " Vineet Gupta
2022-09-02 21:03 ` Andreas Schwab
2022-09-02 21:05 ` [PATCH v3] " Vineet Gupta
2022-09-23 18:07 ` Vineet Gupta
2022-10-05 2:24 ` Kito Cheng
2022-10-05 3:33 ` Vineet Gupta
2022-08-31 20:36 ` [PATCH 1/2] " Vineet Gupta
2022-08-30 17:48 ` [PATCH 2/2] RISC-V: remove CM_PIC as it doesn't do much Vineet Gupta
2022-08-31 14:57 ` Palmer Dabbelt
2022-08-31 20:39 ` Vineet Gupta [this message]
2022-09-02 20:38 ` Vineet Gupta
2022-09-02 23:08 ` [PATCH] RISC-V: make USE_LOAD_ADDRESS_MACRO easier to understand Vineet Gupta
2022-09-23 16:01 ` Kito Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=376353ac-6bfc-05c9-cb32-85e87eec177d@rivosinc.com \
--to=vineetg@rivosinc.com \
--cc=christoph.muellner@vrull.eu \
--cc=collison@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@rivosinc.com \
--cc=philipp.tomsich@vrull.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).