From: Kito Cheng <kito.cheng@gmail.com>
To: Vineet Gupta <vineetg@rivosinc.com>
Cc: gcc-patches@gcc.gnu.org,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
gnu-toolchain@rivosinc.com
Subject: Re: [PATCH v3] RISC-V: remove deprecate pic code model macro
Date: Wed, 5 Oct 2022 10:24:04 +0800 [thread overview]
Message-ID: <CA+yXCZDC_Z-vxdS3Y-vTsaitVHAf+OxzDjs4D-NLC2yD=-jMZA@mail.gmail.com> (raw)
In-Reply-To: <1236ab56-3823-124b-1c91-63b1dbc94aa7@rivosinc.com>
Committed, and added ChangeLog, remember to add that next time :)
On Sat, Sep 24, 2022 at 2:08 AM Vineet Gupta <vineetg@rivosinc.com> wrote:
>
> On 9/2/22 14:05, Vineet Gupta wrote:
> > Came across this deprecated symbol when looking around for
> > -mexplicit-relocs handling in code
> >
> > Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
>
> No rush but looks like this got lost in the bigger thread about
> LOAD_ADDRESS_MACRO.
>
> Thx,
> -Vineet
>
> > ---
> > gcc/config/riscv/riscv-c.cc | 5 -----
> > gcc/testsuite/gcc.target/riscv/predef-1.c | 3 ---
> > gcc/testsuite/gcc.target/riscv/predef-2.c | 3 ---
> > gcc/testsuite/gcc.target/riscv/predef-3.c | 3 ---
> > gcc/testsuite/gcc.target/riscv/predef-4.c | 3 ---
> > gcc/testsuite/gcc.target/riscv/predef-5.c | 3 ---
> > gcc/testsuite/gcc.target/riscv/predef-6.c | 3 ---
> > gcc/testsuite/gcc.target/riscv/predef-7.c | 3 ---
> > gcc/testsuite/gcc.target/riscv/predef-8.c | 3 ---
> > 9 files changed, 29 deletions(-)
> >
> > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc
> > index eb7ef09297e9..8d55ad598a9c 100644
> > --- a/gcc/config/riscv/riscv-c.cc
> > +++ b/gcc/config/riscv/riscv-c.cc
> > @@ -93,11 +93,6 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile)
> > break;
> >
> > case CM_PIC:
> > - /* __riscv_cmodel_pic is deprecated, and will removed in next GCC release.
> > - see https://github.com/riscv/riscv-c-api-doc/pull/11 */
> > - builtin_define ("__riscv_cmodel_pic");
> > - /* FALLTHROUGH. */
> > -
> > case CM_MEDANY:
> > builtin_define ("__riscv_cmodel_medany");
> > break;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-1.c b/gcc/testsuite/gcc.target/riscv/predef-1.c
> > index 2e57ce6b3954..9dddc1849635 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-1.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-1.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medlow"
> > -#endif
> > -#if defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_medlow"
> > #endif
> >
> > return 0;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-2.c b/gcc/testsuite/gcc.target/riscv/predef-2.c
> > index c85b3c9fd32a..755fe4ef7d8a 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-2.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-2.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if !defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medlow"
> > -#endif
> > -#if defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_medlow"
> > #endif
> >
> > return 0;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-3.c b/gcc/testsuite/gcc.target/riscv/predef-3.c
> > index 82a89d415809..513645351c09 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-3.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-3.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if !defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medany"
> > -#endif
> > -#if !defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_pic"
> > #endif
> >
> > return 0;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-4.c b/gcc/testsuite/gcc.target/riscv/predef-4.c
> > index 5868d39eb67a..76b6feec6b6f 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-4.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-4.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medlow"
> > -#endif
> > -#if defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_medlow"
> > #endif
> >
> > return 0;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-5.c b/gcc/testsuite/gcc.target/riscv/predef-5.c
> > index 4b2bd3835061..54a51508afbd 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-5.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-5.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if !defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medlow"
> > -#endif
> > -#if defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_medlow"
> > #endif
> >
> > return 0;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-6.c b/gcc/testsuite/gcc.target/riscv/predef-6.c
> > index 8e5ea366bd5e..f61709f7bf32 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-6.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-6.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if !defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medany"
> > -#endif
> > -#if !defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_medpic"
> > #endif
> >
> > return 0;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-7.c b/gcc/testsuite/gcc.target/riscv/predef-7.c
> > index 0bde299aef1a..41217554c4db 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-7.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-7.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medlow"
> > -#endif
> > -#if defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_medlow"
> > #endif
> >
> > return 0;
> > diff --git a/gcc/testsuite/gcc.target/riscv/predef-8.c b/gcc/testsuite/gcc.target/riscv/predef-8.c
> > index 18aa591a6039..982056a53438 100644
> > --- a/gcc/testsuite/gcc.target/riscv/predef-8.c
> > +++ b/gcc/testsuite/gcc.target/riscv/predef-8.c
> > @@ -57,9 +57,6 @@ int main () {
> > #endif
> > #if !defined(__riscv_cmodel_medany)
> > #error "__riscv_cmodel_medlow"
> > -#endif
> > -#if defined(__riscv_cmodel_pic)
> > -#error "__riscv_cmodel_medlow"
> > #endif
> >
> > return 0;
>
next prev parent reply other threads:[~2022-10-05 2:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 17:48 [PATCH 0/2] PIC cleanup Vineet Gupta
2022-08-30 17:48 ` [PATCH 1/2] RISC-V: remove deprecate pic code model macro Vineet Gupta
2022-08-31 14:57 ` Palmer Dabbelt
2022-08-31 15:35 ` Kito Cheng
2022-09-02 20:33 ` [PATCH v2] " Vineet Gupta
2022-09-02 21:03 ` Andreas Schwab
2022-09-02 21:05 ` [PATCH v3] " Vineet Gupta
2022-09-23 18:07 ` Vineet Gupta
2022-10-05 2:24 ` Kito Cheng [this message]
2022-10-05 3:33 ` Vineet Gupta
2022-08-31 20:36 ` [PATCH 1/2] " Vineet Gupta
2022-08-30 17:48 ` [PATCH 2/2] RISC-V: remove CM_PIC as it doesn't do much Vineet Gupta
2022-08-31 14:57 ` Palmer Dabbelt
2022-08-31 20:39 ` Vineet Gupta
2022-09-02 20:38 ` Vineet Gupta
2022-09-02 23:08 ` [PATCH] RISC-V: make USE_LOAD_ADDRESS_MACRO easier to understand Vineet Gupta
2022-09-23 16:01 ` Kito Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZDC_Z-vxdS3Y-vTsaitVHAf+OxzDjs4D-NLC2yD=-jMZA@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=philipp.tomsich@vrull.eu \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).