From: Jeff Law <jeffreyalaw@gmail.com>
To: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
gcc-patches <gcc-patches@gcc.gnu.org>
Cc: "kito.cheng" <kito.cheng@gmail.com>,
"kito.cheng" <kito.cheng@sifive.com>,
"cooper.joshua" <cooper.joshua@linux.alibaba.com>,
Robin Dapp <rdapp.gcc@gmail.com>
Subject: Re: RISC-V: Support XTheadVector extensions
Date: Fri, 17 Nov 2023 09:47:07 -0700 [thread overview]
Message-ID: <534975f1-c062-49d5-a9e8-794260a0aba3@gmail.com> (raw)
In-Reply-To: <086123810F5FEA3C+202311171939484236058@rivai.ai>
On 11/17/23 04:39, juzhe.zhong@rivai.ai wrote:
> 90% theadvector extension reusing current RVV 1.0 instructions patterns:
> Just change ASM, For example:
>
> @@ -2923,7 +2923,7 @@ (define_insn "*pred_mulh<v_su><mode>_scalar"
> (match_operand:VFULLI_D 3 "register_operand" "vr,vr, vr, vr")] VMULH)
> (match_operand:VFULLI_D 2 "vector_merge_operand" "vu, 0, vu, 0")))]
> "TARGET_VECTOR"
> - "vmulh<v_su>.vx\t%0,%3,%z4%p1"
> + "%^vmulh<v_su>.vx\t%0,%3,%z4%p1"
> [(set_attr "type" "vimul")
> (set_attr "mode" "<MODE>")])
>
> + if (letter == '^')
> + {
> + if (TARGET_XTHEADVECTOR)
> + fputs ("th.", file);
> + return;
> + }
I assume this hunk is meant for riscv_output_operand in riscv.cc. We
may also need to add '^' to the punct_valid_p hook. But yes, this is
the preferred way to go when all we need to do is prefix the instruction
with "th.".
>
> Btw, stage 1 will close soon. So I will review this patch on GCC-15 as
> long as all other RISC-V maintainers agree.
I *think* it's a gcc-15 issue. Philipp T. and I briefly spoke about
this at the RVI summit a couple weeks back and he indicated the thead
vector work was targeting gcc-15.
Jeff
next prev parent reply other threads:[~2023-11-17 16:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 11:39 juzhe.zhong
2023-11-17 16:47 ` Jeff Law [this message]
2023-11-18 9:45 ` Philipp Tomsich
2023-11-18 10:32 ` Kito Cheng
2023-11-18 15:16 ` 钟居哲
2023-11-20 3:04 ` juzhe.zhong
2023-11-20 16:58 ` Jason Kridner
2023-11-30 12:01 ` 回复:RISC-V: " joshua
2023-11-17 17:11 ` RISC-V: " Palmer Dabbelt
2023-11-17 23:16 ` 钟居哲
2023-11-18 0:01 ` Jeff Law
2023-11-18 0:04 ` 钟居哲
2023-11-28 19:45 ` Palmer Dabbelt
2023-11-28 22:14 ` Jeff Law
2023-11-18 9:11 ` Christoph Müllner
[not found] <202311171939484236058@rivai.ai>
2023-11-17 13:41 ` juzhe.zhong
2023-11-22 10:07 ` Christoph Müllner
2023-11-22 13:52 ` 钟居哲
2023-11-22 14:24 ` Christoph Müllner
2023-11-22 22:27 ` Jeff Law
2023-11-22 22:48 ` Kito Cheng
2023-11-22 23:37 ` Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534975f1-c062-49d5-a9e8-794260a0aba3@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=cooper.joshua@linux.alibaba.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).