From: Qing Zhao <qing.zhao@oracle.com>
To: Alexander Monakov <amonakov@ispras.ru>
Cc: Jose Marchesi <jose.marchesi@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH V2] Disable sched1 in functions that call setjmp
Date: Fri, 23 Dec 2022 19:21:24 +0000 [thread overview]
Message-ID: <5FA6D04C-0D5F-4E51-A05D-A2D9370958B0@oracle.com> (raw)
In-Reply-To: <3183d104-b852-eb38-d5ba-9578594015bd@ispras.ru>
Then, sched2 still can move insn across calls?
So does sched2 have the same issue of incorrectly moving the insn across a call which has unknown control flow?
Qing
> On Dec 23, 2022, at 12:31 PM, Alexander Monakov <amonakov@ispras.ru> wrote:
>
>
> On Fri, 23 Dec 2022, Jose E. Marchesi wrote:
>
>>> (scheduling across calls in sched2 is somewhat dubious as well, but
>>> it doesn't risk register pressure issues, and on VLIW CPUs it at least
>>> can result in better VLIW packing)
>>
>> Does sched2 actually schedule across calls? All the comments in the
>> source code stress the fact that the second scheduler pass (after
>> register allocation) works in regions that correspond to basic blocks:
>> "(after reload, each region is of one block)".
>
> A call instruction does not end a basic block.
>
> (also, with -fsched2-use-superblocks sched2 works on regions like sched1)
>
> Alexander
next prev parent reply other threads:[~2022-12-23 19:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 17:32 Jose E. Marchesi
2022-12-22 17:56 ` Alexander Monakov
2022-12-22 19:28 ` Qing Zhao
2022-12-23 7:33 ` Alexander Monakov
2022-12-23 14:34 ` Qing Zhao
2022-12-23 15:03 ` Alexander Monakov
2022-12-23 17:27 ` Jose E. Marchesi
2022-12-23 17:31 ` Alexander Monakov
2022-12-23 17:45 ` Jose E. Marchesi
2022-12-23 19:21 ` Qing Zhao [this message]
2022-12-23 19:36 ` Alexander Monakov
2022-12-23 19:57 ` Qing Zhao
2022-12-24 8:10 ` Alexander Monakov
2022-12-24 9:26 ` Richard Biener
2022-12-24 9:58 ` Jose E. Marchesi
2022-12-24 10:06 ` Richard Biener
2022-12-24 10:18 ` Alexander Monakov
2022-12-26 0:29 ` Segher Boessenkool
2023-01-05 18:11 ` Qing Zhao
2022-12-23 10:05 ` Richard Sandiford
2022-12-23 10:42 ` Jose E. Marchesi
2023-01-13 18:20 ` [PATCH] sched-deps: do not schedule pseudos across calls [PR108117] Alexander Monakov
2023-01-13 18:23 ` Richard Sandiford
2023-01-13 18:33 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FA6D04C-0D5F-4E51-A05D-A2D9370958B0@oracle.com \
--to=qing.zhao@oracle.com \
--cc=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).