From: Richard Biener <richard.guenther@gmail.com>
To: Alexander Monakov <amonakov@ispras.ru>
Cc: Qing Zhao <qing.zhao@oracle.com>,
Jose Marchesi <jose.marchesi@oracle.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH V2] Disable sched1 in functions that call setjmp
Date: Sat, 24 Dec 2022 10:26:55 +0100 [thread overview]
Message-ID: <64AC0724-25B0-4A85-AA9E-8A53A82C8A6B@gmail.com> (raw)
In-Reply-To: <0ad07be0-876d-cc24-6cdb-6b94690dfc52@ispras.ru>
> Am 24.12.2022 um 09:11 schrieb Alexander Monakov via Gcc-patches <gcc-patches@gcc.gnu.org>:
>
>
>> On Fri, 23 Dec 2022, Qing Zhao wrote:
>>
>> BTW, Why sched1 is not enabled on x86 by default?
>
> Register allocation is tricky on x86 due to small number of general-purpose
> registers, and sched1 can make it even more difficult. I think before register
> pressure modeling was added, sched1 could not be enabled because then allocation
> would sometimes fail, and now there's no incentive to enable it, as it is not so
> important for modern x86 CPUs. Perhaps someone else has a more comprehensive
> answer.
>
>> Another question is: As discussed in the original bug PR57067:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57067 The root cause of this
>> issue related to the abnormal control flow edges (from setjmp/longjmp) cannot
>> be represented correctly at RTL stage, shall we fix this root cause instead?
>
> You'd need an experienced reviewer to work with you, especially on high-level
> design decisions such as "How ABNORMAL_DISPATCHER should be represented on RTL".
> I'm afraid it's not just a matter of applying a small patch in one place.
For nonlocal goto we Thread the abnormal dispatcher. Of course by regenerating abnormal edges, not by keeping and modifying them. We cannot re-generate the (optimal) set of abnormal edges for setjmp so we want to preserve those edges. But as you say it’s a very non-trivial change.
Richard
> Alexander
next prev parent reply other threads:[~2022-12-24 9:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 17:32 Jose E. Marchesi
2022-12-22 17:56 ` Alexander Monakov
2022-12-22 19:28 ` Qing Zhao
2022-12-23 7:33 ` Alexander Monakov
2022-12-23 14:34 ` Qing Zhao
2022-12-23 15:03 ` Alexander Monakov
2022-12-23 17:27 ` Jose E. Marchesi
2022-12-23 17:31 ` Alexander Monakov
2022-12-23 17:45 ` Jose E. Marchesi
2022-12-23 19:21 ` Qing Zhao
2022-12-23 19:36 ` Alexander Monakov
2022-12-23 19:57 ` Qing Zhao
2022-12-24 8:10 ` Alexander Monakov
2022-12-24 9:26 ` Richard Biener [this message]
2022-12-24 9:58 ` Jose E. Marchesi
2022-12-24 10:06 ` Richard Biener
2022-12-24 10:18 ` Alexander Monakov
2022-12-26 0:29 ` Segher Boessenkool
2023-01-05 18:11 ` Qing Zhao
2022-12-23 10:05 ` Richard Sandiford
2022-12-23 10:42 ` Jose E. Marchesi
2023-01-13 18:20 ` [PATCH] sched-deps: do not schedule pseudos across calls [PR108117] Alexander Monakov
2023-01-13 18:23 ` Richard Sandiford
2023-01-13 18:33 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64AC0724-25B0-4A85-AA9E-8A53A82C8A6B@gmail.com \
--to=richard.guenther@gmail.com \
--cc=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=jose.marchesi@oracle.com \
--cc=qing.zhao@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).