* [PATCH] testsuite: Disable test for PR113292 on targets without TLS support
@ 2024-01-19 7:41 Nathaniel Shead
2024-01-19 13:47 ` Christophe Lyon
2024-01-23 21:05 ` Jason Merrill
0 siblings, 2 replies; 3+ messages in thread
From: Nathaniel Shead @ 2024-01-19 7:41 UTC (permalink / raw)
To: gcc-patches; +Cc: Jason Merrill, Christophe Lyon, Maxim Kuvyrkov
Tested on x86_64-pc-linux-gnu using a cross-compiler to
arm-unknown-linux-gnueabihf with --enable-threads=0 that the link test
is correctly skipped. OK for trunk?
-- >8 --
This disables the new test added by r14-8168 on machines that don't have
TLS support, such as bare-metal ARM.
gcc/testsuite/ChangeLog:
* g++.dg/modules/pr113292_c.C: Require TLS.
Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
---
gcc/testsuite/g++.dg/modules/pr113292_c.C | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/testsuite/g++.dg/modules/pr113292_c.C b/gcc/testsuite/g++.dg/modules/pr113292_c.C
index aa3f32ae818..c117c7cfcd4 100644
--- a/gcc/testsuite/g++.dg/modules/pr113292_c.C
+++ b/gcc/testsuite/g++.dg/modules/pr113292_c.C
@@ -1,6 +1,8 @@
// PR c++/113292
// { dg-module-do link }
+// { dg-add-options tls }
// { dg-additional-options "-fmodules-ts" }
+// { dg-require-effective-target tls_runtime }
import "pr113292_a.H";
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: Disable test for PR113292 on targets without TLS support
2024-01-19 7:41 [PATCH] testsuite: Disable test for PR113292 on targets without TLS support Nathaniel Shead
@ 2024-01-19 13:47 ` Christophe Lyon
2024-01-23 21:05 ` Jason Merrill
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Lyon @ 2024-01-19 13:47 UTC (permalink / raw)
To: Nathaniel Shead; +Cc: gcc-patches, Jason Merrill, Maxim Kuvyrkov
On Fri, 19 Jan 2024 at 08:41, Nathaniel Shead <nathanieloshead@gmail.com> wrote:
>
> Tested on x86_64-pc-linux-gnu using a cross-compiler to
> arm-unknown-linux-gnueabihf with --enable-threads=0 that the link test
> is correctly skipped. OK for trunk?
>
> -- >8 --
>
> This disables the new test added by r14-8168 on machines that don't have
> TLS support, such as bare-metal ARM.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/modules/pr113292_c.C: Require TLS.
>
> Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
> ---
> gcc/testsuite/g++.dg/modules/pr113292_c.C | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/g++.dg/modules/pr113292_c.C b/gcc/testsuite/g++.dg/modules/pr113292_c.C
> index aa3f32ae818..c117c7cfcd4 100644
> --- a/gcc/testsuite/g++.dg/modules/pr113292_c.C
> +++ b/gcc/testsuite/g++.dg/modules/pr113292_c.C
> @@ -1,6 +1,8 @@
> // PR c++/113292
> // { dg-module-do link }
> +// { dg-add-options tls }
> // { dg-additional-options "-fmodules-ts" }
> +// { dg-require-effective-target tls_runtime }
>
Hi,
Thanks, I think this is OK, although I think we prefer to put
dg-require before dg-add-options (after dg-module-do).
Christophe
> import "pr113292_a.H";
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: Disable test for PR113292 on targets without TLS support
2024-01-19 7:41 [PATCH] testsuite: Disable test for PR113292 on targets without TLS support Nathaniel Shead
2024-01-19 13:47 ` Christophe Lyon
@ 2024-01-23 21:05 ` Jason Merrill
1 sibling, 0 replies; 3+ messages in thread
From: Jason Merrill @ 2024-01-23 21:05 UTC (permalink / raw)
To: Nathaniel Shead, gcc-patches; +Cc: Christophe Lyon, Maxim Kuvyrkov
On 1/19/24 02:41, Nathaniel Shead wrote:
> Tested on x86_64-pc-linux-gnu using a cross-compiler to
> arm-unknown-linux-gnueabihf with --enable-threads=0 that the link test
> is correctly skipped. OK for trunk?
OK.
> -- >8 --
>
> This disables the new test added by r14-8168 on machines that don't have
> TLS support, such as bare-metal ARM.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/modules/pr113292_c.C: Require TLS.
>
> Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
> ---
> gcc/testsuite/g++.dg/modules/pr113292_c.C | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/g++.dg/modules/pr113292_c.C b/gcc/testsuite/g++.dg/modules/pr113292_c.C
> index aa3f32ae818..c117c7cfcd4 100644
> --- a/gcc/testsuite/g++.dg/modules/pr113292_c.C
> +++ b/gcc/testsuite/g++.dg/modules/pr113292_c.C
> @@ -1,6 +1,8 @@
> // PR c++/113292
> // { dg-module-do link }
> +// { dg-add-options tls }
> // { dg-additional-options "-fmodules-ts" }
> +// { dg-require-effective-target tls_runtime }
>
> import "pr113292_a.H";
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-23 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-19 7:41 [PATCH] testsuite: Disable test for PR113292 on targets without TLS support Nathaniel Shead
2024-01-19 13:47 ` Christophe Lyon
2024-01-23 21:05 ` Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).