From: Jiufu Guo <guojiufu@linux.ibm.com>
To: Jiufu Guo via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: "Kewen.Lin" <linkw@linux.ibm.com>,
segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org
Subject: Re: [PATCH 2/3]rs6000: NFC use sext_hwi to replace ((v&0xf..f)^0x80..0) - 0x80..0
Date: Fri, 09 Dec 2022 09:51:15 +0800 [thread overview]
Message-ID: <7ek031mjjg.fsf@pike.rch.stglabs.ibm.com> (raw)
In-Reply-To: <7er0xev0q3.fsf@pike.rch.stglabs.ibm.com> (Jiufu Guo via Gcc-patches's message of "Mon, 05 Dec 2022 14:11:32 +0800")
Hi,
Jiufu Guo via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> Hi Kewen,
>
> "Kewen.Lin" <linkw@linux.ibm.com> writes:
>> on 2022/12/1 20:16, guojiufu wrote:
>>> On 2022-12-01 15:10, Jiufu Guo via Gcc-patches wrote:
>>>> Hi Kewen,
cut...
>>> From 8aa8e1234b6ec34473434951a3a6177253aac770 Mon Sep 17 00:00:00 2001
>>> From: Jiufu Guo <guojiufu@linux.ibm.com>
>>> Date: Wed, 30 Nov 2022 13:13:37 +0800
>>> Subject: [PATCH 2/2]rs6000: update ((v&0xf..f)^0x80..0) - 0x80..0 with code: like sext_hwi
>>>
>>
>> May be shorter with "rs6000: Update sign extension computation with
>> sext_hwi"?
> Thanks for your great suggestions!
>>
>>> This patch just replaces the expression like:
>>> ((value & 0xf..f) ^ 0x80..0) - 0x80..0 to better code(e.g. sext_hwi) for
>>> rs6000.cc, rs6000.md and predicates.md (files under rs6000/).
>>
>>
>>> Bootstrap and regtest pass on ppc64{,le}.
>>>
>>
>> Thanks for updating and testing, this patch is OK.
Committed via r13-4556. Thanks again!
BR,
Jeff (Jiufu)
>
> BR,
> Jeff (Jiufu)
>
>>
>> BR,
>> Kewen
next prev parent reply other threads:[~2022-12-09 1:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 1:36 [PATCH 1/3]rs6000: NFC use more readable pattern to clean high 32 bits Jiufu Guo
2022-12-01 1:36 ` [PATCH 2/3]rs6000: NFC use sext_hwi to replace ((v&0xf..f)^0x80..0) - 0x80..0 Jiufu Guo
2022-12-01 5:17 ` Kewen.Lin
2022-12-01 5:30 ` Kewen.Lin
2022-12-01 6:32 ` Jiufu Guo
2022-12-01 5:35 ` Jiufu Guo
2022-12-01 6:11 ` Kewen.Lin
2022-12-01 7:10 ` Jiufu Guo
2022-12-01 12:16 ` guojiufu
2022-12-02 8:56 ` Kewen.Lin
2022-12-05 6:11 ` Jiufu Guo
2022-12-09 1:51 ` Jiufu Guo [this message]
2022-12-01 1:36 ` [PATCH 3/3]rs6000: NFC no need copy_rtx in rs6000_emit_set_long_const and rs6000_emit_set_const Jiufu Guo
2022-12-01 3:31 ` Kewen.Lin
2022-12-01 4:52 ` Jiufu Guo
2022-12-09 12:25 ` Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ek031mjjg.fsf@pike.rch.stglabs.ibm.com \
--to=guojiufu@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).