From: Mike Stump <mikestump@comcast.net>
To: Alexandre Oliva <oliva@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Kewen Lin <linkw@gcc.gnu.org>,
Hans-Peter Nilsson <hp@bitrange.com>
Subject: Re: [PATCH v2] [testsuite] require sqrt_insn effective target where needed
Date: Tue, 23 Apr 2024 19:15:52 -0700 [thread overview]
Message-ID: <82D41324-7A16-4A23-BF68-9E881186929A@comcast.net> (raw)
In-Reply-To: <oro7a1n2jf.fsf@lxoliva.fsfla.org>
On Apr 22, 2024, at 2:56 AM, Alexandre Oliva <oliva@adacore.com> wrote:
>
> This patch takes feedback received for 3 earlier patches, and adopts a
> simpler approach to skip the still-failing tests, that I believe to be
> in line with ppc maintainers' expressed preferences.
> https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565939.html
> https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566617.html
> https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566521.html
> Ping?-ish :-)
>
>
> Some tests fail on ppc and ppc64 when testing a compiler [with options
> for] for a CPU [emulator] that doesn't support the sqrt insn.
>
> The gcc.dg/cdce3.c is one in which the expected shrink-wrap
> optimization only takes place when the target CPU supports a sqrt
> insn.
>
> The gcc.target/powerpc/pr46728-1[0-4].c tests use -mpowerpc-gpopt and
> call sqrt(), which involves the sqrt insn that the target CPU under
> test may not support.
>
> Require a sqrt_insn effective target for all the affected tests.
>
> Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also testing
> with gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install?
Ok.
prev parent reply other threads:[~2024-04-24 2:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 5:30 enable sqrt insns for cdce3.c Alexandre Oliva
2021-03-10 17:11 ` Hans-Peter Nilsson
2021-03-11 16:04 ` Alexandre Oliva
2024-04-22 9:50 ` Alexandre Oliva
2024-04-23 15:38 ` Hans-Peter Nilsson
2024-04-28 7:40 ` Alexandre Oliva
2021-03-20 15:20 ` Jeff Law
2024-04-22 9:56 ` [PATCH v2] [testsuite] require sqrt_insn effective target where needed Alexandre Oliva
2024-04-23 8:59 ` Kewen.Lin
2024-04-23 9:14 ` Iain Sandoe
2024-04-28 7:37 ` Alexandre Oliva
2024-04-24 2:15 ` Mike Stump [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82D41324-7A16-4A23-BF68-9E881186929A@comcast.net \
--to=mikestump@comcast.net \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=linkw@gcc.gnu.org \
--cc=oliva@adacore.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).