From: Andrew Pinski <pinskia@gcc.gnu.org>
To: Zhongyunde <zhongyunde@huawei.com>
Cc: "hongtao.liu@intel.com" <hongtao.liu@intel.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Zhangwen(Esan)" <zwzhangwen.zhang@huawei.com>,
"Weiwei (weiwei, Compiler)" <weiwei64@huawei.com>,
"zhong_1985624@163.com" <zhong_1985624@163.com>
Subject: Re: [PATCH] [PHIOPT] Add A ? B + CST : B match and simplify optimizations
Date: Fri, 4 Nov 2022 23:34:14 -0700 [thread overview]
Message-ID: <CA+=Sn1kwT-KE5Q53xk8ZEGLnaVk_vwD7iaCtAEZSac63Z=-SOA@mail.gmail.com> (raw)
In-Reply-To: <23b39c10b30043318e05a5c44cc76591@huawei.com>
On Fri, Nov 4, 2022 at 11:17 PM Zhongyunde <zhongyunde@huawei.com> wrote:
>
> hi,
> This patch is try to fix the issue https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107190,
> would you like to give me some suggestion, thanks.
This seems like a "simplified" version of
https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584411.html
which just handles power of 2 constants where we know the cond will be
removed.
We could do even more "simplified" of 1 if needed really.
What is the IR before PHI-OPT? Is it just + 1?
Also your pattern can be simplified to use integer_pow2p in the match
part instead of INTEGER_CST.
Thanks,
Andrew
>
> ~/source/gccUpstreamDir/gcc/testsuite(cfg) » git format-patch -1 --start-number=00 HEAD -o ~/patch
> /home/zhongyunde/patch/0000-PHIOPT-Add-A-B-CST-B-match-and-simplify-optimization.patch
next prev parent reply other threads:[~2022-11-05 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 21:44 [PATCH] riscv: implement TARGET_MODE_REP_EXTENDED Philipp Tomsich
2022-09-06 11:39 ` Alexander Monakov
2022-09-16 23:48 ` Jeff Law
2022-09-17 7:59 ` Palmer Dabbelt
2022-11-04 23:00 ` Philipp Tomsich
2022-11-05 6:16 ` [PATCH] [PHIOPT] Add A ? B + CST : B match and simplify optimizations Zhongyunde
2022-11-05 6:34 ` Andrew Pinski [this message]
2022-11-05 9:03 ` Zhongyunde
2022-11-08 14:58 ` Richard Biener
2022-11-08 15:51 ` 钟云德
2022-11-09 8:00 ` Richard Biener
2022-11-07 13:55 ` [PATCH] riscv: implement TARGET_MODE_REP_EXTENDED Alexander Monakov
2022-11-08 23:45 ` Philipp Tomsich
2022-11-09 17:21 ` Alexander Monakov
2022-11-20 16:09 ` Jeff Law
2022-11-21 13:49 ` Alexander Monakov
2022-11-21 14:56 ` Jeff Law
2022-11-21 15:33 ` Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1kwT-KE5Q53xk8ZEGLnaVk_vwD7iaCtAEZSac63Z=-SOA@mail.gmail.com' \
--to=pinskia@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=weiwei64@huawei.com \
--cc=zhong_1985624@163.com \
--cc=zhongyunde@huawei.com \
--cc=zwzhangwen.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).