* [PATCH] RISC-V: Fix the sge<u> ..., x0, ... pattern
@ 2022-08-06 19:41 Palmer Dabbelt
2022-08-10 15:51 ` Kito Cheng
0 siblings, 1 reply; 2+ messages in thread
From: Palmer Dabbelt @ 2022-08-06 19:41 UTC (permalink / raw)
To: gcc-patches
There's no operand 2 here, so referencing it doesn't make sense. I
couldn't find a way to trigger bad assembly output so I don't have a
test.
gcc/ChangeLog
PR target/106543
* config/riscv/riscv.md (sge<u>_<X:mode><GPR:mode>): Remove
reference to non-existent operand.
---
No new failures on the Linux multilibs on trunk.
---
gcc/config/riscv/riscv.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md
index 0796f91dd30..ed1c7f241e6 100644
--- a/gcc/config/riscv/riscv.md
+++ b/gcc/config/riscv/riscv.md
@@ -2386,7 +2386,7 @@
(any_ge:GPR (match_operand:X 1 "register_operand" " r")
(const_int 1)))]
""
- "slt%i2<u>\t%0,zero,%1"
+ "slt<u>\t%0,zero,%1"
[(set_attr "type" "slt")
(set_attr "mode" "<X:MODE>")])
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] RISC-V: Fix the sge<u> ..., x0, ... pattern
2022-08-06 19:41 [PATCH] RISC-V: Fix the sge<u> ..., x0, ... pattern Palmer Dabbelt
@ 2022-08-10 15:51 ` Kito Cheng
0 siblings, 0 replies; 2+ messages in thread
From: Kito Cheng @ 2022-08-10 15:51 UTC (permalink / raw)
To: Palmer Dabbelt; +Cc: GCC Patches
LGTM, that's apparently some kind of copy & paste error (from *slt<u>
pattern) when we add this pattern.
On Sun, Aug 7, 2022 at 3:42 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> There's no operand 2 here, so referencing it doesn't make sense. I
> couldn't find a way to trigger bad assembly output so I don't have a
> test.
>
> gcc/ChangeLog
>
> PR target/106543
> * config/riscv/riscv.md (sge<u>_<X:mode><GPR:mode>): Remove
> reference to non-existent operand.
> ---
> No new failures on the Linux multilibs on trunk.
> ---
> gcc/config/riscv/riscv.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md
> index 0796f91dd30..ed1c7f241e6 100644
> --- a/gcc/config/riscv/riscv.md
> +++ b/gcc/config/riscv/riscv.md
> @@ -2386,7 +2386,7 @@
> (any_ge:GPR (match_operand:X 1 "register_operand" " r")
> (const_int 1)))]
> ""
> - "slt%i2<u>\t%0,zero,%1"
> + "slt<u>\t%0,zero,%1"
> [(set_attr "type" "slt")
> (set_attr "mode" "<X:MODE>")])
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-10 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-06 19:41 [PATCH] RISC-V: Fix the sge<u> ..., x0, ... pattern Palmer Dabbelt
2022-08-10 15:51 ` Kito Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).