* [PATCH] fix frange_nextafter odr violation
@ 2023-06-08 14:37 Alexandre Oliva
2023-06-09 9:03 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Oliva @ 2023-06-08 14:37 UTC (permalink / raw)
To: gcc-patches
C++ requires inline functions to be declared inline and defined in
every translation unit that uses them. frange_nextafter is used in
gimple-range-op.cc but it's only defined as inline in
range-op-float.cc. Drop the extraneous inline specifier.
Other non-static inline functions in range-op-float.cc are not
referenced elsewhere, so I'm making them static.
Bootstrapping on x86_64-linux-gnu, along with other changes that exposed
the problem; it's already into stage3, and it wouldn't get past stage2
before. Ok to install?
for gcc/ChangeLog
* range-op-float.cc (frange_nextafter): Drop inline.
(frelop_early_resolve): Add static.
(frange_float): Likewise.
---
gcc/range-op-float.cc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc
index a99a6b01ed835..d6da2aa701ee3 100644
--- a/gcc/range-op-float.cc
+++ b/gcc/range-op-float.cc
@@ -255,7 +255,7 @@ maybe_isnan (const frange &op1, const frange &op2)
// Floating version of relop_early_resolve that takes into account NAN
// and -ffinite-math-only.
-inline bool
+static inline bool
frelop_early_resolve (irange &r, tree type,
const frange &op1, const frange &op2,
relation_trio rel, relation_kind my_rel)
@@ -272,7 +272,7 @@ frelop_early_resolve (irange &r, tree type,
// Set VALUE to its next real value, or INF if the operation overflows.
-inline void
+void
frange_nextafter (enum machine_mode mode,
REAL_VALUE_TYPE &value,
const REAL_VALUE_TYPE &inf)
@@ -2878,7 +2878,7 @@ namespace selftest
// Build an frange from string endpoints.
-inline frange
+static inline frange
frange_float (const char *lb, const char *ub, tree type = float_type_node)
{
REAL_VALUE_TYPE min, max;
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix frange_nextafter odr violation
2023-06-08 14:37 [PATCH] fix frange_nextafter odr violation Alexandre Oliva
@ 2023-06-09 9:03 ` Richard Biener
2023-06-09 12:26 ` Alexandre Oliva
0 siblings, 1 reply; 4+ messages in thread
From: Richard Biener @ 2023-06-09 9:03 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: gcc-patches
On Thu, Jun 8, 2023 at 4:38 PM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> C++ requires inline functions to be declared inline and defined in
> every translation unit that uses them. frange_nextafter is used in
> gimple-range-op.cc but it's only defined as inline in
> range-op-float.cc. Drop the extraneous inline specifier.
>
> Other non-static inline functions in range-op-float.cc are not
> referenced elsewhere, so I'm making them static.
>
> Bootstrapping on x86_64-linux-gnu, along with other changes that exposed
> the problem; it's already into stage3, and it wouldn't get past stage2
> before. Ok to install?
OK
>
> for gcc/ChangeLog
>
> * range-op-float.cc (frange_nextafter): Drop inline.
> (frelop_early_resolve): Add static.
> (frange_float): Likewise.
> ---
> gcc/range-op-float.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc
> index a99a6b01ed835..d6da2aa701ee3 100644
> --- a/gcc/range-op-float.cc
> +++ b/gcc/range-op-float.cc
> @@ -255,7 +255,7 @@ maybe_isnan (const frange &op1, const frange &op2)
> // Floating version of relop_early_resolve that takes into account NAN
> // and -ffinite-math-only.
>
> -inline bool
> +static inline bool
> frelop_early_resolve (irange &r, tree type,
> const frange &op1, const frange &op2,
> relation_trio rel, relation_kind my_rel)
> @@ -272,7 +272,7 @@ frelop_early_resolve (irange &r, tree type,
>
> // Set VALUE to its next real value, or INF if the operation overflows.
>
> -inline void
> +void
> frange_nextafter (enum machine_mode mode,
> REAL_VALUE_TYPE &value,
> const REAL_VALUE_TYPE &inf)
> @@ -2878,7 +2878,7 @@ namespace selftest
>
> // Build an frange from string endpoints.
>
> -inline frange
> +static inline frange
> frange_float (const char *lb, const char *ub, tree type = float_type_node)
> {
> REAL_VALUE_TYPE min, max;
>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix frange_nextafter odr violation
2023-06-09 9:03 ` Richard Biener
@ 2023-06-09 12:26 ` Alexandre Oliva
2023-06-09 12:50 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Oliva @ 2023-06-09 12:26 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
On Jun 9, 2023, Richard Biener <richard.guenther@gmail.com> wrote:
> On Thu, Jun 8, 2023 at 4:38 PM Alexandre Oliva via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>> C++ requires inline functions to be declared inline and defined in
>> every translation unit that uses them. frange_nextafter is used in
>> gimple-range-op.cc but it's only defined as inline in
>> range-op-float.cc. Drop the extraneous inline specifier.
> OK
>> for gcc/ChangeLog
>>
>> * range-op-float.cc (frange_nextafter): Drop inline.
>> (frelop_early_resolve): Add static.
>> (frange_float): Likewise.
The problem is also present in gcc-13. Ok there as well? Regstrapped
on x86_64-linux-gnu.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix frange_nextafter odr violation
2023-06-09 12:26 ` Alexandre Oliva
@ 2023-06-09 12:50 ` Richard Biener
0 siblings, 0 replies; 4+ messages in thread
From: Richard Biener @ 2023-06-09 12:50 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: gcc-patches
On Fri, Jun 9, 2023 at 2:26 PM Alexandre Oliva <oliva@adacore.com> wrote:
>
> On Jun 9, 2023, Richard Biener <richard.guenther@gmail.com> wrote:
>
> > On Thu, Jun 8, 2023 at 4:38 PM Alexandre Oliva via Gcc-patches
> > <gcc-patches@gcc.gnu.org> wrote:
>
> >> C++ requires inline functions to be declared inline and defined in
> >> every translation unit that uses them. frange_nextafter is used in
> >> gimple-range-op.cc but it's only defined as inline in
> >> range-op-float.cc. Drop the extraneous inline specifier.
>
> > OK
>
> >> for gcc/ChangeLog
> >>
> >> * range-op-float.cc (frange_nextafter): Drop inline.
> >> (frelop_early_resolve): Add static.
> >> (frange_float): Likewise.
>
> The problem is also present in gcc-13. Ok there as well? Regstrapped
> on x86_64-linux-gnu.
Yes.
Richard.
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-09 12:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-08 14:37 [PATCH] fix frange_nextafter odr violation Alexandre Oliva
2023-06-09 9:03 ` Richard Biener
2023-06-09 12:26 ` Alexandre Oliva
2023-06-09 12:50 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).