From: Hongtao Liu <crazylht@gmail.com>
To: Hongyu Wang <hongyu.wang@intel.com>
Cc: gcc-patches@gcc.gnu.org, ubizjak@gmail.com, hongtao.liu@intel.com
Subject: Re: [PATCH v2 00/17] Support Intel APX NDD
Date: Tue, 5 Dec 2023 11:48:38 +0800 [thread overview]
Message-ID: <CAMZc-bwu_7WMTPuHVk9PBUZAvTOzoboERzA0VL0_nZ-1=iO64g@mail.gmail.com> (raw)
In-Reply-To: <20231205022948.504790-1-hongyu.wang@intel.com>
On Tue, Dec 5, 2023 at 10:32 AM Hongyu Wang <hongyu.wang@intel.com> wrote:
>
> Hi,
>
> APX NDD patches have been posted at
> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636604.html
>
> Thanks to Hongtao's review, the V2 patch adds support of zext sematic with
> memory input as NDD by default clear upper bits of dest for any operand size.
>
> Also we support TImode shift with new split helper functions, which allows NDD
> form split but still restric the memory src usage as in post-reload splitter
> the register number is restricted, and no new register can be used for
> shld/shrd.
>
> Also fixed several typo/formatting/redundant code.
Patches LGTM, Please wait a few more days before committing incase
other folks have comments.
>
> Bootstrapped/regtested on x86_64-pc-linux-gnu{-m32,} and sde.
>
> OK for trunk?
>
> Hongyu Wang (8):
> [APX NDD] Restrict TImode register usage when NDD enabled
> [APX NDD] Disable seg_prefixed memory usage for NDD add
> [APX NDD] Support APX NDD for left shift insns
> [APX NDD] Support APX NDD for right shift insns
> [APX NDD] Support APX NDD for rotate insns
> [APX NDD] Support APX NDD for shld/shrd insns
> [APX NDD] Support APX NDD for cmove insns
> [APX NDD] Support TImode shift for NDD
>
> Kong Lingling (9):
> [APX NDD] Support Intel APX NDD for legacy add insn
> [APX NDD] Support APX NDD for optimization patterns of add
> [APX NDD] Support APX NDD for adc insns
> [APX NDD] Support APX NDD for sub insns
> [APX NDD] Support APX NDD for sbb insn
> [APX NDD] Support APX NDD for neg insn
> [APX NDD] Support APX NDD for not insn
> [APX NDD] Support APX NDD for and insn
> [APX NDD] Support APX NDD for or/xor insn
>
> gcc/config/i386/constraints.md | 5 +
> gcc/config/i386/i386-expand.cc | 164 +-
> gcc/config/i386/i386-options.cc | 2 +
> gcc/config/i386/i386-protos.h | 16 +-
> gcc/config/i386/i386.cc | 40 +-
> gcc/config/i386/i386.md | 2323 +++++++++++------
> gcc/testsuite/gcc.target/i386/apx-ndd-adc.c | 15 +
> gcc/testsuite/gcc.target/i386/apx-ndd-cmov.c | 16 +
> gcc/testsuite/gcc.target/i386/apx-ndd-sbb.c | 6 +
> .../gcc.target/i386/apx-ndd-shld-shrd.c | 24 +
> .../gcc.target/i386/apx-ndd-ti-shift.c | 91 +
> gcc/testsuite/gcc.target/i386/apx-ndd.c | 202 ++
> 12 files changed, 2149 insertions(+), 755 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/i386/apx-ndd-adc.c
> create mode 100644 gcc/testsuite/gcc.target/i386/apx-ndd-cmov.c
> create mode 100644 gcc/testsuite/gcc.target/i386/apx-ndd-sbb.c
> create mode 100644 gcc/testsuite/gcc.target/i386/apx-ndd-shld-shrd.c
> create mode 100644 gcc/testsuite/gcc.target/i386/apx-ndd-ti-shift.c
> create mode 100644 gcc/testsuite/gcc.target/i386/apx-ndd.c
>
> --
> 2.31.1
>
--
BR,
Hongtao
prev parent reply other threads:[~2023-12-05 3:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 2:29 Hongyu Wang
2023-12-05 2:29 ` [PATCH 01/17] [APX NDD] Support Intel APX NDD for legacy add insn Hongyu Wang
2023-12-05 2:29 ` [PATCH 02/17] [APX NDD] Restrict TImode register usage when NDD enabled Hongyu Wang
2023-12-05 10:46 ` Uros Bizjak
2023-12-06 1:24 ` Hongyu Wang
2023-12-06 6:55 ` Uros Bizjak
2023-12-05 2:29 ` [PATCH 03/17] [APX NDD] Support APX NDD for optimization patterns of add Hongyu Wang
2023-12-05 11:20 ` Uros Bizjak
2023-12-05 2:29 ` [PATCH 04/17] [APX NDD] Disable seg_prefixed memory usage for NDD add Hongyu Wang
2023-12-05 2:29 ` [PATCH 05/17] [APX NDD] Support APX NDD for adc insns Hongyu Wang
2023-12-05 11:25 ` Uros Bizjak
2023-12-05 2:29 ` [PATCH 06/17] [APX NDD] Support APX NDD for sub insns Hongyu Wang
2023-12-05 2:29 ` [PATCH 07/17] [APX NDD] Support APX NDD for sbb insn Hongyu Wang
2023-12-05 2:29 ` [PATCH 08/17] [APX NDD] Support APX NDD for neg insn Hongyu Wang
2023-12-05 2:29 ` [PATCH 09/17] [APX NDD] Support APX NDD for not insn Hongyu Wang
2023-12-05 2:29 ` [PATCH 10/17] [APX NDD] Support APX NDD for and insn Hongyu Wang
2023-12-05 2:29 ` [PATCH 11/17] [APX NDD] Support APX NDD for or/xor insn Hongyu Wang
2023-12-05 2:29 ` [PATCH 12/17] [APX NDD] Support APX NDD for left shift insns Hongyu Wang
2023-12-05 2:29 ` [PATCH 13/17] [APX NDD] Support APX NDD for right " Hongyu Wang
2023-12-05 2:29 ` [PATCH 14/17] [APX NDD] Support APX NDD for rotate insns Hongyu Wang
2023-12-05 2:29 ` [PATCH 15/17] [APX NDD] Support APX NDD for shld/shrd insns Hongyu Wang
2023-12-05 2:29 ` [PATCH 16/17] [APX NDD] Support APX NDD for cmove insns Hongyu Wang
2023-12-05 2:29 ` [PATCH 17/17] [APX NDD] Support TImode shift for NDD Hongyu Wang
2023-12-05 3:48 ` Hongtao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZc-bwu_7WMTPuHVk9PBUZAvTOzoboERzA0VL0_nZ-1=iO64g@mail.gmail.com' \
--to=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hongyu.wang@intel.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).