* [PATCH] RISC-V: Change vsetvl tail and mask policy to default policy
@ 2023-08-31 9:06 Lehua Ding
2023-08-31 9:13 ` Kito Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Lehua Ding @ 2023-08-31 9:06 UTC (permalink / raw)
To: gcc-patches; +Cc: juzhe.zhong, kito.cheng, rdapp.gcc, palmer, jeffreyalaw
This patch change the vsetvl policy to default policy
(returned by get_prefer_mask_policy and get_prefer_tail_policy) instead
fixed policy. Any policy is now returned, allowing change to agnostic
or undisturbed. In the future, users may be able to control the default
policy, such as keeping agnostic by compiler options.
gcc/ChangeLog:
* config/riscv/riscv-protos.h (IS_AGNOSTIC): Move to here.
* config/riscv/riscv-v.cc (gen_no_side_effects_vsetvl_rtx):
Change to default policy.
* config/riscv/riscv-vector-builtins-bases.cc: Change to default policy.
* config/riscv/riscv-vsetvl.h (IS_AGNOSTIC): Delete.
* config/riscv/riscv.cc (riscv_print_operand): Use IS_AGNOSTIC to test.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/rvv/base/binop_vx_constraint-171.c: Adjust.
* gcc.target/riscv/rvv/base/binop_vx_constraint-173.c: Adjust.
* gcc.target/riscv/rvv/vsetvl/vsetvl-24.c: New test.
---
gcc/config/riscv/riscv-protos.h | 3 +++
gcc/config/riscv/riscv-v.cc | 4 +++-
gcc/config/riscv/riscv-vector-builtins-bases.cc | 8 ++++----
gcc/config/riscv/riscv-vsetvl.h | 2 --
gcc/config/riscv/riscv.cc | 3 +--
.../riscv/rvv/base/binop_vx_constraint-171.c | 4 ++--
.../riscv/rvv/base/binop_vx_constraint-173.c | 4 ++--
gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c | 11 +++++++++++
8 files changed, 26 insertions(+), 13 deletions(-)
create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h
index 92e30a10f3c..e145ee6c69b 100644
--- a/gcc/config/riscv/riscv-protos.h
+++ b/gcc/config/riscv/riscv-protos.h
@@ -406,6 +406,9 @@ enum mask_policy
MASK_ANY = 2,
};
+/* Return true if VALUE is agnostic or any policy. */
+#define IS_AGNOSTIC(VALUE) (bool) (VALUE & 0x1 || (VALUE >> 1 & 0x1))
+
enum class reduction_type
{
UNORDERED,
diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
index 427700192a3..6228ff3d92e 100644
--- a/gcc/config/riscv/riscv-v.cc
+++ b/gcc/config/riscv/riscv-v.cc
@@ -1672,9 +1672,11 @@ static rtx
gen_no_side_effects_vsetvl_rtx (machine_mode vmode, rtx vl, rtx avl)
{
unsigned int sew = get_sew (vmode);
+ rtx tail_policy = gen_int_mode (get_prefer_tail_policy (), Pmode);
+ rtx mask_policy = gen_int_mode (get_prefer_mask_policy (), Pmode);
return gen_vsetvl_no_side_effects (Pmode, vl, avl, gen_int_mode (sew, Pmode),
gen_int_mode (get_vlmul (vmode), Pmode),
- const0_rtx, const0_rtx);
+ tail_policy, mask_policy);
}
/* GET VL * 2 rtx. */
diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
index 54582ee130c..8e679f72392 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
@@ -139,11 +139,11 @@ public:
/* LMUL. */
e.add_input_operand (Pmode, gen_int_mode (get_vlmul (mode), Pmode));
- /* TA. */
- e.add_input_operand (Pmode, gen_int_mode (1, Pmode));
+ /* TAIL_ANY. */
+ e.add_input_operand (Pmode, gen_int_mode (get_prefer_tail_policy (), Pmode));
- /* MU. */
- e.add_input_operand (Pmode, gen_int_mode (0, Pmode));
+ /* MASK_ANY. */
+ e.add_input_operand (Pmode, gen_int_mode (get_prefer_mask_policy (), Pmode));
return e.generate_insn (code_for_vsetvl_no_side_effects (Pmode));
}
};
diff --git a/gcc/config/riscv/riscv-vsetvl.h b/gcc/config/riscv/riscv-vsetvl.h
index 2a315e45f31..53549abfac5 100644
--- a/gcc/config/riscv/riscv-vsetvl.h
+++ b/gcc/config/riscv/riscv-vsetvl.h
@@ -21,8 +21,6 @@ along with GCC; see the file COPYING3. If not see
#ifndef GCC_RISCV_VSETVL_H
#define GCC_RISCV_VSETVL_H
-#define IS_AGNOSTIC(VALUE) (bool) (VALUE & 0x1 || (VALUE >> 1 & 0x1))
-
namespace riscv_vector {
/* Classification of vsetvl instruction. */
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index d84fa2311fa..8bca8075713 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -5246,8 +5246,7 @@ riscv_print_operand (FILE *file, rtx op, int letter)
else if (code == CONST_INT)
{
/* Tail && Mask policy. */
- bool agnostic_p = UINTVAL (op) & 0x1;
- asm_fprintf (file, "%s", agnostic_p ? "a" : "u");
+ asm_fprintf (file, "%s", IS_AGNOSTIC (UINTVAL (op)) ? "a" : "u");
}
else
output_operand_lossage ("invalid vector constant");
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
index dae5eff42ce..6e8669ae59e 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
@@ -7,7 +7,7 @@
/*
** f1:
** ...
-** vsetivli\t[a-x0-9]+,\s*4,e64,m1,tu,m[au]
+** vsetivli\t[a-x0-9]+,\s*4,e64,m1,t[au],m[au]
** ...
** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
** ...
@@ -41,7 +41,7 @@ void f1 (void * in, void *out, int64_t x, int n)
/*
** f2:
** ...
-** vsetivli\t[a-x0-9]+,\s*4,e64,m1,tu,m[au]
+** vsetivli\t[a-x0-9]+,\s*4,e64,m1,t[au],m[au]
** ...
** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
** ...
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
index 0d5a2603856..af9c45e942b 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
@@ -7,7 +7,7 @@
/*
** f1:
** ...
-** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,tu,m[au]
+** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,t[au],m[au]
** ...
** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
** ...
@@ -41,7 +41,7 @@ void f1 (void * in, void *out, int64_t x, int vl)
/*
** f2:
** ...
-** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,tu,m[au]
+** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,t[au],m[au]
** ...
** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
** ...
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c b/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
new file mode 100644
index 00000000000..1703c739f5e
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gcv -mabi=lp64d" } */
+
+#include <riscv_vector.h>
+
+size_t foo ()
+{
+ return __riscv_vsetvlmax_e8m1 ();
+}
+
+/* { dg-final { scan-assembler-times {\tvsetvli\t[a-x0-9]+,zero,e8,m1,ta,ma} 1 } } */
--
2.36.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Change vsetvl tail and mask policy to default policy
2023-08-31 9:06 [PATCH] RISC-V: Change vsetvl tail and mask policy to default policy Lehua Ding
@ 2023-08-31 9:13 ` Kito Cheng
2023-08-31 10:47 ` Lehua Ding
0 siblings, 1 reply; 3+ messages in thread
From: Kito Cheng @ 2023-08-31 9:13 UTC (permalink / raw)
To: Lehua Ding; +Cc: gcc-patches, juzhe.zhong
LGTM
On Thu, Aug 31, 2023 at 5:07 PM Lehua Ding <lehua.ding@rivai.ai> wrote:
>
> This patch change the vsetvl policy to default policy
> (returned by get_prefer_mask_policy and get_prefer_tail_policy) instead
> fixed policy. Any policy is now returned, allowing change to agnostic
> or undisturbed. In the future, users may be able to control the default
> policy, such as keeping agnostic by compiler options.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-protos.h (IS_AGNOSTIC): Move to here.
> * config/riscv/riscv-v.cc (gen_no_side_effects_vsetvl_rtx):
> Change to default policy.
> * config/riscv/riscv-vector-builtins-bases.cc: Change to default policy.
> * config/riscv/riscv-vsetvl.h (IS_AGNOSTIC): Delete.
> * config/riscv/riscv.cc (riscv_print_operand): Use IS_AGNOSTIC to test.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/rvv/base/binop_vx_constraint-171.c: Adjust.
> * gcc.target/riscv/rvv/base/binop_vx_constraint-173.c: Adjust.
> * gcc.target/riscv/rvv/vsetvl/vsetvl-24.c: New test.
>
> ---
> gcc/config/riscv/riscv-protos.h | 3 +++
> gcc/config/riscv/riscv-v.cc | 4 +++-
> gcc/config/riscv/riscv-vector-builtins-bases.cc | 8 ++++----
> gcc/config/riscv/riscv-vsetvl.h | 2 --
> gcc/config/riscv/riscv.cc | 3 +--
> .../riscv/rvv/base/binop_vx_constraint-171.c | 4 ++--
> .../riscv/rvv/base/binop_vx_constraint-173.c | 4 ++--
> gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c | 11 +++++++++++
> 8 files changed, 26 insertions(+), 13 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
>
> diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h
> index 92e30a10f3c..e145ee6c69b 100644
> --- a/gcc/config/riscv/riscv-protos.h
> +++ b/gcc/config/riscv/riscv-protos.h
> @@ -406,6 +406,9 @@ enum mask_policy
> MASK_ANY = 2,
> };
>
> +/* Return true if VALUE is agnostic or any policy. */
> +#define IS_AGNOSTIC(VALUE) (bool) (VALUE & 0x1 || (VALUE >> 1 & 0x1))
> +
> enum class reduction_type
> {
> UNORDERED,
> diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
> index 427700192a3..6228ff3d92e 100644
> --- a/gcc/config/riscv/riscv-v.cc
> +++ b/gcc/config/riscv/riscv-v.cc
> @@ -1672,9 +1672,11 @@ static rtx
> gen_no_side_effects_vsetvl_rtx (machine_mode vmode, rtx vl, rtx avl)
> {
> unsigned int sew = get_sew (vmode);
> + rtx tail_policy = gen_int_mode (get_prefer_tail_policy (), Pmode);
> + rtx mask_policy = gen_int_mode (get_prefer_mask_policy (), Pmode);
> return gen_vsetvl_no_side_effects (Pmode, vl, avl, gen_int_mode (sew, Pmode),
> gen_int_mode (get_vlmul (vmode), Pmode),
> - const0_rtx, const0_rtx);
> + tail_policy, mask_policy);
> }
>
> /* GET VL * 2 rtx. */
> diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> index 54582ee130c..8e679f72392 100644
> --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
> +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> @@ -139,11 +139,11 @@ public:
> /* LMUL. */
> e.add_input_operand (Pmode, gen_int_mode (get_vlmul (mode), Pmode));
>
> - /* TA. */
> - e.add_input_operand (Pmode, gen_int_mode (1, Pmode));
> + /* TAIL_ANY. */
> + e.add_input_operand (Pmode, gen_int_mode (get_prefer_tail_policy (), Pmode));
>
> - /* MU. */
> - e.add_input_operand (Pmode, gen_int_mode (0, Pmode));
> + /* MASK_ANY. */
> + e.add_input_operand (Pmode, gen_int_mode (get_prefer_mask_policy (), Pmode));
> return e.generate_insn (code_for_vsetvl_no_side_effects (Pmode));
> }
> };
> diff --git a/gcc/config/riscv/riscv-vsetvl.h b/gcc/config/riscv/riscv-vsetvl.h
> index 2a315e45f31..53549abfac5 100644
> --- a/gcc/config/riscv/riscv-vsetvl.h
> +++ b/gcc/config/riscv/riscv-vsetvl.h
> @@ -21,8 +21,6 @@ along with GCC; see the file COPYING3. If not see
> #ifndef GCC_RISCV_VSETVL_H
> #define GCC_RISCV_VSETVL_H
>
> -#define IS_AGNOSTIC(VALUE) (bool) (VALUE & 0x1 || (VALUE >> 1 & 0x1))
> -
> namespace riscv_vector {
>
> /* Classification of vsetvl instruction. */
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index d84fa2311fa..8bca8075713 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -5246,8 +5246,7 @@ riscv_print_operand (FILE *file, rtx op, int letter)
> else if (code == CONST_INT)
> {
> /* Tail && Mask policy. */
> - bool agnostic_p = UINTVAL (op) & 0x1;
> - asm_fprintf (file, "%s", agnostic_p ? "a" : "u");
> + asm_fprintf (file, "%s", IS_AGNOSTIC (UINTVAL (op)) ? "a" : "u");
> }
> else
> output_operand_lossage ("invalid vector constant");
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
> index dae5eff42ce..6e8669ae59e 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
> @@ -7,7 +7,7 @@
> /*
> ** f1:
> ** ...
> -** vsetivli\t[a-x0-9]+,\s*4,e64,m1,tu,m[au]
> +** vsetivli\t[a-x0-9]+,\s*4,e64,m1,t[au],m[au]
> ** ...
> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
> ** ...
> @@ -41,7 +41,7 @@ void f1 (void * in, void *out, int64_t x, int n)
> /*
> ** f2:
> ** ...
> -** vsetivli\t[a-x0-9]+,\s*4,e64,m1,tu,m[au]
> +** vsetivli\t[a-x0-9]+,\s*4,e64,m1,t[au],m[au]
> ** ...
> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
> ** ...
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
> index 0d5a2603856..af9c45e942b 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
> @@ -7,7 +7,7 @@
> /*
> ** f1:
> ** ...
> -** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,tu,m[au]
> +** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,t[au],m[au]
> ** ...
> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
> ** ...
> @@ -41,7 +41,7 @@ void f1 (void * in, void *out, int64_t x, int vl)
> /*
> ** f2:
> ** ...
> -** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,tu,m[au]
> +** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,t[au],m[au]
> ** ...
> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
> ** ...
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c b/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
> new file mode 100644
> index 00000000000..1703c739f5e
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
> @@ -0,0 +1,11 @@
> +/* { dg-do compile } */
> +/* { dg-options "-march=rv64gcv -mabi=lp64d" } */
> +
> +#include <riscv_vector.h>
> +
> +size_t foo ()
> +{
> + return __riscv_vsetvlmax_e8m1 ();
> +}
> +
> +/* { dg-final { scan-assembler-times {\tvsetvli\t[a-x0-9]+,zero,e8,m1,ta,ma} 1 } } */
> --
> 2.36.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Change vsetvl tail and mask policy to default policy
2023-08-31 9:13 ` Kito Cheng
@ 2023-08-31 10:47 ` Lehua Ding
0 siblings, 0 replies; 3+ messages in thread
From: Lehua Ding @ 2023-08-31 10:47 UTC (permalink / raw)
To: Kito Cheng; +Cc: gcc-patches, juzhe.zhong
Committed, thanks Kito.
On 2023/8/31 17:13, Kito Cheng via Gcc-patches wrote:
> LGTM
>
> On Thu, Aug 31, 2023 at 5:07 PM Lehua Ding <lehua.ding@rivai.ai> wrote:
>>
>> This patch change the vsetvl policy to default policy
>> (returned by get_prefer_mask_policy and get_prefer_tail_policy) instead
>> fixed policy. Any policy is now returned, allowing change to agnostic
>> or undisturbed. In the future, users may be able to control the default
>> policy, such as keeping agnostic by compiler options.
>>
>> gcc/ChangeLog:
>>
>> * config/riscv/riscv-protos.h (IS_AGNOSTIC): Move to here.
>> * config/riscv/riscv-v.cc (gen_no_side_effects_vsetvl_rtx):
>> Change to default policy.
>> * config/riscv/riscv-vector-builtins-bases.cc: Change to default policy.
>> * config/riscv/riscv-vsetvl.h (IS_AGNOSTIC): Delete.
>> * config/riscv/riscv.cc (riscv_print_operand): Use IS_AGNOSTIC to test.
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/riscv/rvv/base/binop_vx_constraint-171.c: Adjust.
>> * gcc.target/riscv/rvv/base/binop_vx_constraint-173.c: Adjust.
>> * gcc.target/riscv/rvv/vsetvl/vsetvl-24.c: New test.
>>
>> ---
>> gcc/config/riscv/riscv-protos.h | 3 +++
>> gcc/config/riscv/riscv-v.cc | 4 +++-
>> gcc/config/riscv/riscv-vector-builtins-bases.cc | 8 ++++----
>> gcc/config/riscv/riscv-vsetvl.h | 2 --
>> gcc/config/riscv/riscv.cc | 3 +--
>> .../riscv/rvv/base/binop_vx_constraint-171.c | 4 ++--
>> .../riscv/rvv/base/binop_vx_constraint-173.c | 4 ++--
>> gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c | 11 +++++++++++
>> 8 files changed, 26 insertions(+), 13 deletions(-)
>> create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
>>
>> diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h
>> index 92e30a10f3c..e145ee6c69b 100644
>> --- a/gcc/config/riscv/riscv-protos.h
>> +++ b/gcc/config/riscv/riscv-protos.h
>> @@ -406,6 +406,9 @@ enum mask_policy
>> MASK_ANY = 2,
>> };
>>
>> +/* Return true if VALUE is agnostic or any policy. */
>> +#define IS_AGNOSTIC(VALUE) (bool) (VALUE & 0x1 || (VALUE >> 1 & 0x1))
>> +
>> enum class reduction_type
>> {
>> UNORDERED,
>> diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
>> index 427700192a3..6228ff3d92e 100644
>> --- a/gcc/config/riscv/riscv-v.cc
>> +++ b/gcc/config/riscv/riscv-v.cc
>> @@ -1672,9 +1672,11 @@ static rtx
>> gen_no_side_effects_vsetvl_rtx (machine_mode vmode, rtx vl, rtx avl)
>> {
>> unsigned int sew = get_sew (vmode);
>> + rtx tail_policy = gen_int_mode (get_prefer_tail_policy (), Pmode);
>> + rtx mask_policy = gen_int_mode (get_prefer_mask_policy (), Pmode);
>> return gen_vsetvl_no_side_effects (Pmode, vl, avl, gen_int_mode (sew, Pmode),
>> gen_int_mode (get_vlmul (vmode), Pmode),
>> - const0_rtx, const0_rtx);
>> + tail_policy, mask_policy);
>> }
>>
>> /* GET VL * 2 rtx. */
>> diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
>> index 54582ee130c..8e679f72392 100644
>> --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
>> +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
>> @@ -139,11 +139,11 @@ public:
>> /* LMUL. */
>> e.add_input_operand (Pmode, gen_int_mode (get_vlmul (mode), Pmode));
>>
>> - /* TA. */
>> - e.add_input_operand (Pmode, gen_int_mode (1, Pmode));
>> + /* TAIL_ANY. */
>> + e.add_input_operand (Pmode, gen_int_mode (get_prefer_tail_policy (), Pmode));
>>
>> - /* MU. */
>> - e.add_input_operand (Pmode, gen_int_mode (0, Pmode));
>> + /* MASK_ANY. */
>> + e.add_input_operand (Pmode, gen_int_mode (get_prefer_mask_policy (), Pmode));
>> return e.generate_insn (code_for_vsetvl_no_side_effects (Pmode));
>> }
>> };
>> diff --git a/gcc/config/riscv/riscv-vsetvl.h b/gcc/config/riscv/riscv-vsetvl.h
>> index 2a315e45f31..53549abfac5 100644
>> --- a/gcc/config/riscv/riscv-vsetvl.h
>> +++ b/gcc/config/riscv/riscv-vsetvl.h
>> @@ -21,8 +21,6 @@ along with GCC; see the file COPYING3. If not see
>> #ifndef GCC_RISCV_VSETVL_H
>> #define GCC_RISCV_VSETVL_H
>>
>> -#define IS_AGNOSTIC(VALUE) (bool) (VALUE & 0x1 || (VALUE >> 1 & 0x1))
>> -
>> namespace riscv_vector {
>>
>> /* Classification of vsetvl instruction. */
>> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
>> index d84fa2311fa..8bca8075713 100644
>> --- a/gcc/config/riscv/riscv.cc
>> +++ b/gcc/config/riscv/riscv.cc
>> @@ -5246,8 +5246,7 @@ riscv_print_operand (FILE *file, rtx op, int letter)
>> else if (code == CONST_INT)
>> {
>> /* Tail && Mask policy. */
>> - bool agnostic_p = UINTVAL (op) & 0x1;
>> - asm_fprintf (file, "%s", agnostic_p ? "a" : "u");
>> + asm_fprintf (file, "%s", IS_AGNOSTIC (UINTVAL (op)) ? "a" : "u");
>> }
>> else
>> output_operand_lossage ("invalid vector constant");
>> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
>> index dae5eff42ce..6e8669ae59e 100644
>> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
>> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-171.c
>> @@ -7,7 +7,7 @@
>> /*
>> ** f1:
>> ** ...
>> -** vsetivli\t[a-x0-9]+,\s*4,e64,m1,tu,m[au]
>> +** vsetivli\t[a-x0-9]+,\s*4,e64,m1,t[au],m[au]
>> ** ...
>> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
>> ** ...
>> @@ -41,7 +41,7 @@ void f1 (void * in, void *out, int64_t x, int n)
>> /*
>> ** f2:
>> ** ...
>> -** vsetivli\t[a-x0-9]+,\s*4,e64,m1,tu,m[au]
>> +** vsetivli\t[a-x0-9]+,\s*4,e64,m1,t[au],m[au]
>> ** ...
>> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
>> ** ...
>> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
>> index 0d5a2603856..af9c45e942b 100644
>> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
>> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/binop_vx_constraint-173.c
>> @@ -7,7 +7,7 @@
>> /*
>> ** f1:
>> ** ...
>> -** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,tu,m[au]
>> +** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,t[au],m[au]
>> ** ...
>> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
>> ** ...
>> @@ -41,7 +41,7 @@ void f1 (void * in, void *out, int64_t x, int vl)
>> /*
>> ** f2:
>> ** ...
>> -** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,tu,m[au]
>> +** vsetvli\t[a-x0-9]+,\s*[a-x0-9]+,e64,m1,t[au],m[au]
>> ** ...
>> ** vsetvli\tzero,\s*[a-x0-9]+,e32,m1,tu,m[au]
>> ** ...
>> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c b/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
>> new file mode 100644
>> index 00000000000..1703c739f5e
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/vsetvl-24.c
>> @@ -0,0 +1,11 @@
>> +/* { dg-do compile } */
>> +/* { dg-options "-march=rv64gcv -mabi=lp64d" } */
>> +
>> +#include <riscv_vector.h>
>> +
>> +size_t foo ()
>> +{
>> + return __riscv_vsetvlmax_e8m1 ();
>> +}
>> +
>> +/* { dg-final { scan-assembler-times {\tvsetvli\t[a-x0-9]+,zero,e8,m1,ta,ma} 1 } } */
>> --
>> 2.36.3
>>
--
Best,
Lehua
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-31 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-31 9:06 [PATCH] RISC-V: Change vsetvl tail and mask policy to default policy Lehua Ding
2023-08-31 9:13 ` Kito Cheng
2023-08-31 10:47 ` Lehua Ding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).