* [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505).
@ 2023-01-27 17:44 Srinath Parvathaneni
2023-02-02 12:16 ` Srinath Parvathaneni
2023-02-08 9:45 ` Richard Earnshaw
0 siblings, 2 replies; 3+ messages in thread
From: Srinath Parvathaneni @ 2023-01-27 17:44 UTC (permalink / raw)
To: gcc-patches; +Cc: nd, richard.earnshaw, kyrylo.tkachov
[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]
Hello,
I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and
latter received few upstream comments proposing more robust fix for this issue.
In this patch I'm addressing those comments and sending this as a followup patch.
Regression tested on arm-none-eabi target and found no regressions.
Ok for master?
[1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html
Regards,
Srinath.
gcc/ChangeLog:
2023-01-27 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
PR target/108505
* config.gcc (tm_mlib_file): Define new variable.
############### Attachment also inlined for ease of reply ###############
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -4355,6 +4355,7 @@ case "${target}" in
case ${arm_multilib} in
aprofile|rmprofile)
tmake_profile_file="arm/t-multilib"
+ tm_mlib_file="arm/arm-mlib.h"
;;
@*)
ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
@@ -4393,7 +4394,7 @@ case "${target}" in
# through to the multilib selector
with_float="soft"
tmake_file="${tmake_file} ${tmake_profile_file}"
- tm_file="$tm_file arm/arm-mlib.h"
+ tm_file="$tm_file $tm_mlib_file"
TM_MULTILIB_CONFIG="$with_multilib_list"
fi
fi
[-- Attachment #2: rb16853.patch --]
[-- Type: text/plain, Size: 730 bytes --]
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -4355,6 +4355,7 @@ case "${target}" in
case ${arm_multilib} in
aprofile|rmprofile)
tmake_profile_file="arm/t-multilib"
+ tm_mlib_file="arm/arm-mlib.h"
;;
@*)
ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
@@ -4393,7 +4394,7 @@ case "${target}" in
# through to the multilib selector
with_float="soft"
tmake_file="${tmake_file} ${tmake_profile_file}"
- tm_file="$tm_file arm/arm-mlib.h"
+ tm_file="$tm_file $tm_mlib_file"
TM_MULTILIB_CONFIG="$with_multilib_list"
fi
fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505).
2023-01-27 17:44 [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505) Srinath Parvathaneni
@ 2023-02-02 12:16 ` Srinath Parvathaneni
2023-02-08 9:45 ` Richard Earnshaw
1 sibling, 0 replies; 3+ messages in thread
From: Srinath Parvathaneni @ 2023-02-02 12:16 UTC (permalink / raw)
To: gcc-patches; +Cc: nd, Richard Earnshaw, Kyrylo Tkachov
[-- Attachment #1: Type: text/plain, Size: 2408 bytes --]
Ping!!
________________________________
From: Gcc-patches <gcc-patches-bounces+srinath.parvathaneni=arm.com@gcc.gnu.org> on behalf of Srinath Parvathaneni via Gcc-patches <gcc-patches@gcc.gnu.org>
Sent: 27 January 2023 17:44
To: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Subject: [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505).
Hello,
I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and
latter received few upstream comments proposing more robust fix for this issue.
In this patch I'm addressing those comments and sending this as a followup patch.
Regression tested on arm-none-eabi target and found no regressions.
Ok for master?
[1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html
Regards,
Srinath.
gcc/ChangeLog:
2023-01-27 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
PR target/108505
* config.gcc (tm_mlib_file): Define new variable.
############### Attachment also inlined for ease of reply ###############
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -4355,6 +4355,7 @@ case "${target}" in
case ${arm_multilib} in
aprofile|rmprofile)
tmake_profile_file="arm/t-multilib"
+ tm_mlib_file="arm/arm-mlib.h"
;;
@*)
ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
@@ -4393,7 +4394,7 @@ case "${target}" in
# through to the multilib selector
with_float="soft"
tmake_file="${tmake_file} ${tmake_profile_file}"
- tm_file="$tm_file arm/arm-mlib.h"
+ tm_file="$tm_file $tm_mlib_file"
TM_MULTILIB_CONFIG="$with_multilib_list"
fi
fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505).
2023-01-27 17:44 [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505) Srinath Parvathaneni
2023-02-02 12:16 ` Srinath Parvathaneni
@ 2023-02-08 9:45 ` Richard Earnshaw
1 sibling, 0 replies; 3+ messages in thread
From: Richard Earnshaw @ 2023-02-08 9:45 UTC (permalink / raw)
To: Srinath Parvathaneni, gcc-patches; +Cc: nd, richard.earnshaw, kyrylo.tkachov
On 27/01/2023 17:44, Srinath Parvathaneni via Gcc-patches wrote:
> Hello,
>
> I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and
> latter received few upstream comments proposing more robust fix for this issue.
>
> In this patch I'm addressing those comments and sending this as a followup patch.
>
> Regression tested on arm-none-eabi target and found no regressions.
>
> Ok for master?
>
OK. But please correct the syntax for the PR in the subject. It should
be "[PR...]" not "(PR...)".
R.
> [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html
>
> Regards,
> Srinath.
>
> gcc/ChangeLog:
>
> 2023-01-27 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
>
> PR target/108505
> * config.gcc (tm_mlib_file): Define new variable.
>
>
> ############### Attachment also inlined for ease of reply ###############
>
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -4355,6 +4355,7 @@ case "${target}" in
> case ${arm_multilib} in
> aprofile|rmprofile)
> tmake_profile_file="arm/t-multilib"
> + tm_mlib_file="arm/arm-mlib.h"
> ;;
> @*)
> ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
> @@ -4393,7 +4394,7 @@ case "${target}" in
> # through to the multilib selector
> with_float="soft"
> tmake_file="${tmake_file} ${tmake_profile_file}"
> - tm_file="$tm_file arm/arm-mlib.h"
> + tm_file="$tm_file $tm_mlib_file"
> TM_MULTILIB_CONFIG="$with_multilib_list"
> fi
> fi
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-08 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-27 17:44 [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505) Srinath Parvathaneni
2023-02-02 12:16 ` Srinath Parvathaneni
2023-02-08 9:45 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).