From: Jakub Jelinek <jakub@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Richard Sandiford <Richard.Sandiford@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libgcc: Fix uninitialized RA signing on AArch64 [PR107678]
Date: Tue, 10 Jan 2023 19:12:34 +0100 [thread overview]
Message-ID: <Y72qktCU96I1m/UT@tucnak> (raw)
In-Reply-To: <PAWPR08MB89823C6DE93D9912BA10590983FF9@PAWPR08MB8982.eurprd08.prod.outlook.com>
On Tue, Jan 10, 2023 at 04:33:59PM +0000, Wilco Dijkstra via Gcc-patches wrote:
> @@ -1204,10 +1203,15 @@ execute_cfa_program (const unsigned char *insn_ptr,
> case DW_CFA_GNU_window_save:
> #if defined (__aarch64__) && !defined (__ILP32__)
> /* This CFA is multiplexed with Sparc. On AArch64 it's used to toggle
> - return address signing status. */
> + return address signing status. The REG_UNDEFINED/UNSAVED states
> + mean RA signing is enabled/disabled. */
> reg = DWARF_REGNUM_AARCH64_RA_STATE;
> - gcc_assert (fs->regs.how[reg] == REG_UNSAVED);
> - fs->regs.reg[reg].loc.offset ^= 1;
> + gcc_assert (fs->regs.how[reg] == REG_UNSAVED
> + || fs->regs.how[reg] == REG_UNDEFINED);
> + if (fs->regs.how[reg] == REG_UNSAVED)
> + fs->regs.how[reg] = REG_UNDEFINED;
> + else
> + fs->regs.how[reg] = REG_UNSAVED;
Wouldn't the assert be better written just as:
if (fs->regs.how[reg] == REG_UNSAVED)
fs->regs.how[reg] = REG_UNDEFINED;
else
{
gcc_assert (fs->regs.how[reg] == REG_UNDEFINED);
fs->regs.how[reg] = REG_UNSAVED;
}
?
Anyway, the sooner this makes it into gcc trunk, the better, it breaks quite
a lot of stuff.
Jakub
next prev parent reply other threads:[~2023-01-10 18:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:55 Wilco Dijkstra
2022-12-05 19:04 ` Richard Sandiford
2022-12-06 10:50 ` Szabolcs Nagy
2022-12-06 11:58 ` Wilco Dijkstra
2022-12-06 21:33 ` Szabolcs Nagy
2023-01-03 17:27 ` Wilco Dijkstra
2023-01-05 14:57 ` Szabolcs Nagy
2023-01-10 16:33 ` Wilco Dijkstra
2023-01-10 18:12 ` Jakub Jelinek [this message]
2023-01-11 11:33 ` Martin Liška
2023-01-11 11:59 ` Wilco Dijkstra
2023-01-12 10:49 ` Jakub Jelinek
2023-01-12 12:05 ` Richard Sandiford
2023-01-12 12:08 ` Richard Sandiford
2023-01-12 12:28 ` Jakub Jelinek
2023-01-12 14:39 ` Jakub Jelinek
2023-01-12 15:22 ` Richard Sandiford
2023-01-12 15:34 ` Jakub Jelinek
2023-01-12 15:40 ` Richard Sandiford
2023-01-12 18:57 ` Jakub Jelinek
2023-01-16 13:04 ` Martin Liška
2023-01-17 19:49 ` Wilco Dijkstra
2023-01-17 20:43 ` Richard Sandiford
2023-01-18 12:49 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y72qktCU96I1m/UT@tucnak \
--to=jakub@redhat.com \
--cc=Richard.Sandiford@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).