* [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite
@ 2023-11-08 14:55 Florian Weimer
2023-11-08 14:58 ` Jakub Jelinek
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2023-11-08 14:55 UTC (permalink / raw)
To: gcc-patches
* gcc.target/x86_64/abi/avx/avx-check.h (main): Call
__builtin_printf instead of printf.
* gcc.target/x86_64/abi/avx/test_passing_m256.c
(fun_check_passing_m256_8_values): Add missing void return
type.
* gcc.target/x86_64/abi/avx512f/avx512f-check.h (main): Call
__builtin_printf instead of printf.
* gcc.target/x86_64/abi/avx512f/test_passing_m512.c
(fun_check_passing_m512_8_values): Add missing void return
type.
---
gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h | 4 ++--
gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c | 1 +
gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h | 6 +++---
gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c | 1 +
4 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h b/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h
index e66a27e9afd..a04d0777637 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h
@@ -16,12 +16,12 @@ main ()
{
avx_test ();
#ifdef DEBUG
- printf ("PASSED\n");
+ __builtin_printf ("PASSED\n");
#endif
}
#ifdef DEBUG
else
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
return 0;
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c b/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c
index ffc3ec36bf7..f739670431b 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c
@@ -24,6 +24,7 @@ int failed = 0;
assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
} while (0)
+void
fun_check_passing_m256_8_values (__m256 i0 ATTRIBUTE_UNUSED, __m256 i1 ATTRIBUTE_UNUSED, __m256 i2 ATTRIBUTE_UNUSED, __m256 i3 ATTRIBUTE_UNUSED, __m256 i4 ATTRIBUTE_UNUSED, __m256 i5 ATTRIBUTE_UNUSED, __m256 i6 ATTRIBUTE_UNUSED, __m256 i7 ATTRIBUTE_UNUSED)
{
/* Check argument values. */
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h
index 25ce544c4a3..00a7578d2b5 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h
@@ -24,17 +24,17 @@ main ()
{
avx512f_test ();
#ifdef DEBUG
- printf ("PASSED\n");
+ __builtin_printf ("PASSED\n");
#endif
}
#ifdef DEBUG
else
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
}
#ifdef DEBUG
else
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
return 0;
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c
index ead9c6797e1..1c88a55fb4b 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c
@@ -24,6 +24,7 @@ int failed = 0;
assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
} while (0)
+void
fun_check_passing_m512_8_values (__m512 i0 ATTRIBUTE_UNUSED, __m512 i1 ATTRIBUTE_UNUSED, __m512 i2 ATTRIBUTE_UNUSED, __m512 i3 ATTRIBUTE_UNUSED, __m512 i4 ATTRIBUTE_UNUSED, __m512 i5 ATTRIBUTE_UNUSED, __m512 i6 ATTRIBUTE_UNUSED, __m512 i7 ATTRIBUTE_UNUSED)
{
/* Check argument values. */
base-commit: d72492cca7a66af166b8dcf58d1166d8b0c59c59
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite
2023-11-08 14:55 [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite Florian Weimer
@ 2023-11-08 14:58 ` Jakub Jelinek
2023-11-09 9:33 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Jelinek @ 2023-11-08 14:58 UTC (permalink / raw)
To: Florian Weimer; +Cc: gcc-patches
On Wed, Nov 08, 2023 at 03:55:17PM +0100, Florian Weimer wrote:
> * gcc.target/x86_64/abi/avx/avx-check.h (main): Call
> __builtin_printf instead of printf.
> * gcc.target/x86_64/abi/avx/test_passing_m256.c
> (fun_check_passing_m256_8_values): Add missing void return
> type.
> * gcc.target/x86_64/abi/avx512f/avx512f-check.h (main): Call
> __builtin_printf instead of printf.
> * gcc.target/x86_64/abi/avx512f/test_passing_m512.c
> (fun_check_passing_m512_8_values): Add missing void return
> type.
LGTM.
Jakub
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite
2023-11-08 14:58 ` Jakub Jelinek
@ 2023-11-09 9:33 ` Florian Weimer
2023-11-09 9:36 ` Jakub Jelinek
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2023-11-09 9:33 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
* Jakub Jelinek:
> On Wed, Nov 08, 2023 at 03:55:17PM +0100, Florian Weimer wrote:
>> * gcc.target/x86_64/abi/avx/avx-check.h (main): Call
>> __builtin_printf instead of printf.
>> * gcc.target/x86_64/abi/avx/test_passing_m256.c
>> (fun_check_passing_m256_8_values): Add missing void return
>> type.
>> * gcc.target/x86_64/abi/avx512f/avx512f-check.h (main): Call
>> __builtin_printf instead of printf.
>> * gcc.target/x86_64/abi/avx512f/test_passing_m512.c
>> (fun_check_passing_m512_8_values): Add missing void return
>> type.
>
> LGTM.
I should have scrolled down further, there are more fixes required along
the same lines. Still okay?
Thanks,
Florian
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-i386-Fix-C99-compatibility-issues-in-the-x86-64-AVX-.patch --]
[-- Type: text/x-patch, Size: 7602 bytes --]
From 3a6df3281a525ae6113f50d7b38b09fcd803801e Mon Sep 17 00:00:00 2001
Message-ID: <3a6df3281a525ae6113f50d7b38b09fcd803801e.1699522355.git.fweimer@redhat.com>
From: Florian Weimer <fweimer@redhat.com>
Date: Wed, 8 Nov 2023 15:14:40 +0100
Subject: [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test
suite
Content-type: text/plain
To: gcc-patches@gcc.gnu.org
gcc/testsuite/
* gcc.target/x86_64/abi/avx/avx-check.h (main): Call
__builtin_printf instead of printf.
* gcc.target/x86_64/abi/avx/test_passing_m256.c
(fun_check_passing_m256_8_values): Add missing void return
type.
* gcc.target/x86_64/abi/avx512f/avx512f-check.h (main): Call
__builtin_printf instead of printf.
* gcc.target/x86_64/abi/avx512f/test_passing_m512.c
(fun_check_passing_m512_8_values): Add missing void return
type.
* gcc.target/x86_64/abi/bf16/bf16-check.h (main): Call
__builtin_printf instead of printf.
* gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h (main):
Likewise.
* gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c
(fun_check_passing_m256bf16_8_values): Add missing void
return type.
* gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h (main):
Call __builtin_printf instead of printf.
* gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c
(fun_check_passing_m512bf16_8_values): Add missign void
return type.
---
gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h | 4 ++--
gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c | 1 +
gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h | 6 +++---
.../gcc.target/x86_64/abi/avx512f/test_passing_m512.c | 1 +
gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h | 4 ++--
.../gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h | 4 ++--
.../gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c | 1 +
.../gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h | 4 ++--
.../gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c | 1 +
9 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h b/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h
index e66a27e9afd..a04d0777637 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h
@@ -16,12 +16,12 @@ main ()
{
avx_test ();
#ifdef DEBUG
- printf ("PASSED\n");
+ __builtin_printf ("PASSED\n");
#endif
}
#ifdef DEBUG
else
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
return 0;
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c b/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c
index ffc3ec36bf7..f739670431b 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c
@@ -24,6 +24,7 @@ int failed = 0;
assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
} while (0)
+void
fun_check_passing_m256_8_values (__m256 i0 ATTRIBUTE_UNUSED, __m256 i1 ATTRIBUTE_UNUSED, __m256 i2 ATTRIBUTE_UNUSED, __m256 i3 ATTRIBUTE_UNUSED, __m256 i4 ATTRIBUTE_UNUSED, __m256 i5 ATTRIBUTE_UNUSED, __m256 i6 ATTRIBUTE_UNUSED, __m256 i7 ATTRIBUTE_UNUSED)
{
/* Check argument values. */
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h
index 25ce544c4a3..00a7578d2b5 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h
@@ -24,17 +24,17 @@ main ()
{
avx512f_test ();
#ifdef DEBUG
- printf ("PASSED\n");
+ __builtin_printf ("PASSED\n");
#endif
}
#ifdef DEBUG
else
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
}
#ifdef DEBUG
else
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
return 0;
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c
index ead9c6797e1..1c88a55fb4b 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c
+++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c
@@ -24,6 +24,7 @@ int failed = 0;
assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
} while (0)
+void
fun_check_passing_m512_8_values (__m512 i0 ATTRIBUTE_UNUSED, __m512 i1 ATTRIBUTE_UNUSED, __m512 i2 ATTRIBUTE_UNUSED, __m512 i3 ATTRIBUTE_UNUSED, __m512 i4 ATTRIBUTE_UNUSED, __m512 i5 ATTRIBUTE_UNUSED, __m512 i6 ATTRIBUTE_UNUSED, __m512 i7 ATTRIBUTE_UNUSED)
{
/* Check argument values. */
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h b/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h
index 25448fc6863..5db94a26c08 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h
+++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h
@@ -11,13 +11,13 @@ main ()
{
do_test ();
#ifdef DEBUG
- printf ("PASSED\n");
+ __builtin_printf ("PASSED\n");
#endif
return 0;
}
#ifdef DEBUG
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
return 0;
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h
index 479ebc3ec3f..81564f02e7a 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h
+++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h
@@ -11,13 +11,13 @@ main ()
{
do_test ();
#ifdef DEBUG
- printf ("PASSED\n");
+ __builtin_printf ("PASSED\n");
#endif
return 0;
}
#ifdef DEBUG
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
return 0;
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c
index 3fb2d7d20f8..34e97332272 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c
+++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c
@@ -25,6 +25,7 @@ int failed = 0;
assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
} while (0)
+void
fun_check_passing_m256bf16_8_values (__m256bf16 i0 ATTRIBUTE_UNUSED,
__m256bf16 i1 ATTRIBUTE_UNUSED,
__m256bf16 i2 ATTRIBUTE_UNUSED,
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h
index 9cd39b878dd..b3e13829535 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h
+++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h
@@ -11,13 +11,13 @@ main ()
{
do_test ();
#ifdef DEBUG
- printf ("PASSED\n");
+ __builtin_printf ("PASSED\n");
#endif
return 0;
}
#ifdef DEBUG
- printf ("SKIPPED\n");
+ __builtin_printf ("SKIPPED\n");
#endif
return 0;
diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c
index 1c5c407efee..b06b90a7478 100644
--- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c
+++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c
@@ -25,6 +25,7 @@ int failed = 0;
assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
} while (0)
+void
fun_check_passing_m512bf16_8_values (__m512bf16 i0 ATTRIBUTE_UNUSED,
__m512bf16 i1 ATTRIBUTE_UNUSED,
__m512bf16 i2 ATTRIBUTE_UNUSED,
--
2.41.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite
2023-11-09 9:33 ` Florian Weimer
@ 2023-11-09 9:36 ` Jakub Jelinek
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Jelinek @ 2023-11-09 9:36 UTC (permalink / raw)
To: Florian Weimer; +Cc: gcc-patches
On Thu, Nov 09, 2023 at 10:33:40AM +0100, Florian Weimer wrote:
> * Jakub Jelinek:
>
> > On Wed, Nov 08, 2023 at 03:55:17PM +0100, Florian Weimer wrote:
> >> * gcc.target/x86_64/abi/avx/avx-check.h (main): Call
> >> __builtin_printf instead of printf.
> >> * gcc.target/x86_64/abi/avx/test_passing_m256.c
> >> (fun_check_passing_m256_8_values): Add missing void return
> >> type.
> >> * gcc.target/x86_64/abi/avx512f/avx512f-check.h (main): Call
> >> __builtin_printf instead of printf.
> >> * gcc.target/x86_64/abi/avx512f/test_passing_m512.c
> >> (fun_check_passing_m512_8_values): Add missing void return
> >> type.
> >
> > LGTM.
>
> I should have scrolled down further, there are more fixes required along
> the same lines. Still okay?
Yes.
Jakub
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-09 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-08 14:55 [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite Florian Weimer
2023-11-08 14:58 ` Jakub Jelinek
2023-11-09 9:33 ` Florian Weimer
2023-11-09 9:36 ` Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).