* [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
@ 2024-04-17 14:01 Christophe Lyon
2024-04-17 14:07 ` Jakub Jelinek
2024-04-17 17:16 ` Eric Gallager
0 siblings, 2 replies; 4+ messages in thread
From: Christophe Lyon @ 2024-04-17 14:01 UTC (permalink / raw)
To: gcc-patches, jakub, pinskia, arsen, dmalcolm; +Cc: Christophe Lyon
As discussed in the PR, aclocal.m4 and configure were incorrectly
regenerated at some point.
2024-04-17 Christophe Lyon <christophe.lyon@linaro.org>
PR preprocessor/114748
libcpp/
* aclocal.m4: Regenerate.
* configure: Regenerate.
---
libcpp/aclocal.m4 | 1 +
libcpp/configure | 3 +++
2 files changed, 4 insertions(+)
diff --git a/libcpp/aclocal.m4 b/libcpp/aclocal.m4
index 4fc81709622..4d898ea2c97 100644
--- a/libcpp/aclocal.m4
+++ b/libcpp/aclocal.m4
@@ -26,6 +26,7 @@ m4_include([../config/lib-ld.m4])
m4_include([../config/lib-link.m4])
m4_include([../config/lib-prefix.m4])
m4_include([../config/nls.m4])
+m4_include([../config/override.m4])
m4_include([../config/po.m4])
m4_include([../config/progtest.m4])
m4_include([../config/warnings.m4])
diff --git a/libcpp/configure b/libcpp/configure
index 8a38c0546e3..32d6aaa3069 100755
--- a/libcpp/configure
+++ b/libcpp/configure
@@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
+
+
+
ac_aux_dir=
for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do
if test -f "$ac_dir/install-sh"; then
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
2024-04-17 14:01 [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748] Christophe Lyon
@ 2024-04-17 14:07 ` Jakub Jelinek
2024-04-17 17:16 ` Eric Gallager
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Jelinek @ 2024-04-17 14:07 UTC (permalink / raw)
To: Christophe Lyon; +Cc: gcc-patches, pinskia, arsen, dmalcolm
On Wed, Apr 17, 2024 at 02:01:55PM +0000, Christophe Lyon wrote:
> As discussed in the PR, aclocal.m4 and configure were incorrectly
> regenerated at some point.
>
> 2024-04-17 Christophe Lyon <christophe.lyon@linaro.org>
>
> PR preprocessor/114748
> libcpp/
> * aclocal.m4: Regenerate.
> * configure: Regenerate.
Ok, thanks.
Jakub
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
2024-04-17 14:01 [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748] Christophe Lyon
2024-04-17 14:07 ` Jakub Jelinek
@ 2024-04-17 17:16 ` Eric Gallager
2024-04-17 17:20 ` Jakub Jelinek
1 sibling, 1 reply; 4+ messages in thread
From: Eric Gallager @ 2024-04-17 17:16 UTC (permalink / raw)
To: Christophe Lyon; +Cc: gcc-patches, jakub, pinskia, arsen, dmalcolm
On Wed, Apr 17, 2024 at 10:03 AM Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> As discussed in the PR, aclocal.m4 and configure were incorrectly
> regenerated at some point.
>
> 2024-04-17 Christophe Lyon <christophe.lyon@linaro.org>
>
> PR preprocessor/114748
> libcpp/
> * aclocal.m4: Regenerate.
> * configure: Regenerate.
> ---
> libcpp/aclocal.m4 | 1 +
> libcpp/configure | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/libcpp/aclocal.m4 b/libcpp/aclocal.m4
> index 4fc81709622..4d898ea2c97 100644
> --- a/libcpp/aclocal.m4
> +++ b/libcpp/aclocal.m4
> @@ -26,6 +26,7 @@ m4_include([../config/lib-ld.m4])
> m4_include([../config/lib-link.m4])
> m4_include([../config/lib-prefix.m4])
> m4_include([../config/nls.m4])
> +m4_include([../config/override.m4])
> m4_include([../config/po.m4])
> m4_include([../config/progtest.m4])
> m4_include([../config/warnings.m4])
> diff --git a/libcpp/configure b/libcpp/configure
> index 8a38c0546e3..32d6aaa3069 100755
> --- a/libcpp/configure
> +++ b/libcpp/configure
> @@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
>
>
>
> +
> +
> +
So, this is kind of a minor style nitpick, but personally, it kind of
bothers me when autotools goes and inserts a bunch of unnecessary
blank newlines in the generated output scripts. Does anyone else think
it'd be worth it to scatter around some of m4's "dnl" comments in the
configure.ac scripts, to get autoconf to eat the unnecessary newlines?
Just an idea,
Eric Gallager
> ac_aux_dir=
> for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do
> if test -f "$ac_dir/install-sh"; then
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
2024-04-17 17:16 ` Eric Gallager
@ 2024-04-17 17:20 ` Jakub Jelinek
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Jelinek @ 2024-04-17 17:20 UTC (permalink / raw)
To: Eric Gallager; +Cc: Christophe Lyon, gcc-patches, pinskia, arsen, dmalcolm
On Wed, Apr 17, 2024 at 01:16:43PM -0400, Eric Gallager wrote:
> > --- a/libcpp/configure
> > +++ b/libcpp/configure
> > @@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
> >
> >
> >
> > +
> > +
> > +
>
> So, this is kind of a minor style nitpick, but personally, it kind of
> bothers me when autotools goes and inserts a bunch of unnecessary
> blank newlines in the generated output scripts. Does anyone else think
> it'd be worth it to scatter around some of m4's "dnl" comments in the
> configure.ac scripts, to get autoconf to eat the unnecessary newlines?
In stage1 maybe, but certainly not in stage4.
Jakub
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-17 17:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 14:01 [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748] Christophe Lyon
2024-04-17 14:07 ` Jakub Jelinek
2024-04-17 17:16 ` Eric Gallager
2024-04-17 17:20 ` Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).