From: "Martin Liška" <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>,
Eric Botcazou <botcazou@adacore.com>
Cc: Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches@gcc.gnu.org, Martin Jambor <mjambor@suse.cz>
Subject: Re: [PATCH] Fix bogus -Wstringop-overflow warning
Date: Fri, 14 Oct 2022 12:27:28 +0200 [thread overview]
Message-ID: <bd26e228-551d-a7df-bb99-ad4843f9b21f@suse.cz> (raw)
In-Reply-To: <CAFiYyc2jV-CDeWQ0Xvv1F9dLHLVgphvBz37XS1=uh_JSsZXOVg@mail.gmail.com>
On 10/14/22 08:12, Richard Biener wrote:
> On Fri, Oct 14, 2022 at 12:54 AM Eric Botcazou via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>>> Not a fan as it could potentially hide a real issue, but I don't really
>>> have a better solution.
>>
>> Thanks.
>>
>>> I pondered suggesting "access" affect type identity, but the cases where
>>> that's really important are probably better handled by the "fn spec"
>>> attribute, leaving "access" strictly impacting diagnostics.
>>
>> I can expand a bit here, because I tried to change the "access" attribute that
>> way and this badly breaks the C compiler, for example:
>>
>> int foo (int n, char m[1][n]);
>>
>> int foo (int n, char m[1][n]) {}
>>
>> no longer compiles with an error about different function types.
>
> Note in discussion with IPA folks we agreed that IPA cloning that modifies
> arguments either has to remove access attributes, adjust them or refrain
> from cloning.
>
> Martin - has anything been done to this respect?
I think it's more for Martin Jambor who's the IPA specialist when it comes
to parameter manipulation.
Martin
>
> I suppose there's also a way to figure if a clone has arguments
> changed in any way?
>
> Thanks,
> Richard.
>
>> --
>> Eric Botcazou
>>
>>
next prev parent reply other threads:[~2022-10-14 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 12:06 Eric Botcazou
2022-10-13 22:31 ` Jeff Law
2022-10-13 22:53 ` Eric Botcazou
2022-10-14 6:12 ` Richard Biener
2022-10-14 10:27 ` Martin Liška [this message]
2022-10-14 11:59 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd26e228-551d-a7df-bb99-ad4843f9b21f@suse.cz \
--to=mliska@suse.cz \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=mjambor@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).