public inbox for
 help / color / mirror / Atom feed
From: Martin Jambor <>
To: "Martin Liška" <>,
	"Richard Biener" <>,
	"Eric Botcazou" <>
Cc: Jeff Law <>,
Subject: Re: [PATCH] Fix bogus -Wstringop-overflow warning
Date: Fri, 14 Oct 2022 13:59:15 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Fri, Oct 14 2022, Martin Liška wrote:
> On 10/14/22 08:12, Richard Biener wrote:
>> On Fri, Oct 14, 2022 at 12:54 AM Eric Botcazou via Gcc-patches
>> <> wrote:
>>>> Not a fan as it could potentially hide a real issue, but I don't really
>>>> have a better solution.
>>> Thanks.
>>>> I pondered suggesting "access" affect type identity, but the cases where
>>>> that's really important are probably better handled by the "fn spec"
>>>> attribute, leaving "access" strictly impacting diagnostics.
>>> I can expand a bit here, because I tried to change the "access" attribute that
>>> way and this badly breaks the C compiler, for example:
>>> int foo (int n, char m[1][n]);
>>> int foo (int n, char m[1][n]) {}
>>> no longer compiles with an error about different function types.
>> Note in discussion with IPA folks we agreed that IPA cloning that modifies
>> arguments either has to remove access attributes, adjust them or refrain
>> from cloning.
>> Martin - has anything been done to this respect?
> I think it's more for Martin Jambor who's the IPA specialist when it comes
> to parameter manipulation.

They are being dropped since 2af63f0f53a

Adjusting them accordingly is an item buried quite deep in my TODO list.

>> I suppose there's also a way to figure if a clone has arguments
>> changed in any way?

Look whether clone_info::get (node) exists and its param_adjustments is

In theory the param_adjustments could contain description of the very
same signature the original function has but in practice it does not
currently happen and is unlikely to happen ever.


      reply	other threads:[~2022-10-14 11:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13 12:06 Eric Botcazou
2022-10-13 22:31 ` Jeff Law
2022-10-13 22:53   ` Eric Botcazou
2022-10-14  6:12     ` Richard Biener
2022-10-14 10:27       ` Martin Liška
2022-10-14 11:59         ` Martin Jambor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).