public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Yong <10walls@gmail.com>
To: Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org>,
	richard.sandiford@arm.com
Subject: Re: [Patch] gcc.dg/memchr-3.c: fix for LLP64
Date: Wed, 1 Mar 2023 13:41:22 +0000	[thread overview]
Message-ID: <c2801e41-6c8a-d955-73f8-dcfdc32bd504@gmail.com> (raw)
In-Reply-To: <mptmt4zqc8z.fsf@arm.com>

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On 2/27/23 16:55, Richard Sandiford wrote:
> Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>> Attached patch OK?
>>
>>       gcc.dg/memchr-3.c: fix for LLP64
>>
>>               gcc/testsuite/ChangeLog:
>>
>>               PR middle-end/97956
>>               * gcc.dg/memchr-3.c (memchr): fix long to size_t in
>>               prototype.
>>
>>  From 194eb3d43964276beeaea14ebee4b241799cd966 Mon Sep 17 00:00:00 2001
>> From: Jonathan Yong <10walls@gmail.com>
>> Date: Mon, 27 Feb 2023 10:02:32 +0000
>> Subject: [PATCH] gcc.dg/memchr-3.c: fix for LLP64
>>
>> 	gcc/testsuite/ChangeLog:
>>
>> 	PR middle-end/97956
>> 	* gcc.dg/memchr-3.c (memchr): fix long to size_t in
>> 	prototype.
> 
> It looks like the current type signature could have been a deliberate
> part of the test.  I think we should just skip it for LLP64 instead.
> Preapproved if you agree.
> 
> Thanks,
> Richard
> 

Revised, account for the warning in LLP64.



[-- Attachment #2: 0006-gcc.dg-memchr-3.c-Account-for-LLP64-warnings.patch --]
[-- Type: text/x-patch, Size: 935 bytes --]

From 2dbfa538fe11c65914b28f94d066daee789f881a Mon Sep 17 00:00:00 2001
From: Jonathan Yong <10walls@gmail.com>
Date: Mon, 27 Feb 2023 10:02:32 +0000
Subject: [PATCH 6/7] gcc.dg/memchr-3.c: Account for LLP64 warnings

	gcc/testsuite/ChangeLog:

	PR middle-end/97956
	* gcc.dg/memchr-3.c (memchr): Account for LLP64 warnings.

Signed-off-by: Jonathan Yong <10walls@gmail.com>
---
 gcc/testsuite/gcc.dg/memchr-3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/memchr-3.c b/gcc/testsuite/gcc.dg/memchr-3.c
index c38d9cf3349..af1b26ef3ae 100644
--- a/gcc/testsuite/gcc.dg/memchr-3.c
+++ b/gcc/testsuite/gcc.dg/memchr-3.c
@@ -6,7 +6,7 @@
 typedef __INT8_TYPE__  int8_t;
 typedef __INT32_TYPE__ int32_t;
 
-extern void* memchr (const void*, int, long);
+extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" { target llp64 } } */
 
 struct SX
 {
-- 
2.39.2


  reply	other threads:[~2023-03-01 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 10:09 Jonathan Yong
2023-02-27 16:55 ` Richard Sandiford
2023-03-01 13:41   ` Jonathan Yong [this message]
2023-03-02 10:46     ` Richard Sandiford
2023-03-02 13:43       ` Jonathan Yong
2023-03-02 23:52         ` [committed] testsuite: Fix up memchr-3.c test [PR108991] Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2801e41-6c8a-d955-73f8-dcfdc32bd504@gmail.com \
    --to=10walls@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).