From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Yong <10walls@gmail.com>
Cc: Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org>,
richard.sandiford@arm.com
Subject: [committed] testsuite: Fix up memchr-3.c test [PR108991]
Date: Fri, 3 Mar 2023 00:52:26 +0100 [thread overview]
Message-ID: <ZAE2uhyk3ens4RXy@tucnak> (raw)
In-Reply-To: <51b54f05-f6d6-fbb1-9f5a-987e47264a1d@gmail.com>
On Thu, Mar 02, 2023 at 01:43:30PM +0000, Jonathan Yong via Gcc-patches wrote:
> On 3/2/23 10:46, Richard Sandiford wrote:
> > > diff --git a/gcc/testsuite/gcc.dg/memchr-3.c b/gcc/testsuite/gcc.dg/memchr-3.c
> > > index c38d9cf3349..af1b26ef3ae 100644
> > > --- a/gcc/testsuite/gcc.dg/memchr-3.c
> > > +++ b/gcc/testsuite/gcc.dg/memchr-3.c
> > > @@ -6,7 +6,7 @@
> > > typedef __INT8_TYPE__ int8_t;
> > > typedef __INT32_TYPE__ int32_t;
> > > -extern void* memchr (const void*, int, long);
> > > +extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" { target llp64 } } */
> > > struct SX
> > > {
> >
> > OK, thanks.
>
> Thanks, pushed to master branch.
The newly added dg-warning directive was missing the comment argument,
so the target selector was treated as comment and the warning was expected
on all targets when it should be expected only on llp64 targets.
Tested on x86_64-linux -m32/-m64, committed to trunk as obvious:
2023-03-03 Jakub Jelinek <jakub@redhat.com>
PR testsuite/108991
* gcc.dg/memchr-3.c: Add missing comment argument to dg-warning
before target selector.
--- gcc/testsuite/gcc.dg/memchr-3.c.jj 2023-03-02 19:09:45.466594110 +0100
+++ gcc/testsuite/gcc.dg/memchr-3.c 2023-03-03 00:48:04.368348282 +0100
@@ -6,7 +6,7 @@
typedef __INT8_TYPE__ int8_t;
typedef __INT32_TYPE__ int32_t;
-extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" { target llp64 } } */
+extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" "" { target llp64 } } */
struct SX
{
Jakub
prev parent reply other threads:[~2023-03-02 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 10:09 [Patch] gcc.dg/memchr-3.c: fix for LLP64 Jonathan Yong
2023-02-27 16:55 ` Richard Sandiford
2023-03-01 13:41 ` Jonathan Yong
2023-03-02 10:46 ` Richard Sandiford
2023-03-02 13:43 ` Jonathan Yong
2023-03-02 23:52 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAE2uhyk3ens4RXy@tucnak \
--to=jakub@redhat.com \
--cc=10walls@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).