Re: [Patch] gcc.dg/memchr-3.c: fix for LLP64

[Richard Sandiford <richard.sandiford@arm.com>]

Jonathan Yong <10walls@gmail.com> writes:
> On 2/27/23 16:55, Richard Sandiford wrote:
>> Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>>> Attached patch OK?
>>>
>>>       gcc.dg/memchr-3.c: fix for LLP64
>>>
>>>               gcc/testsuite/ChangeLog:
>>>
>>>               PR middle-end/97956
>>>               * gcc.dg/memchr-3.c (memchr): fix long to size_t in
>>>               prototype.
>>>
>>>  From 194eb3d43964276beeaea14ebee4b241799cd966 Mon Sep 17 00:00:00 2001
>>> From: Jonathan Yong <10walls@gmail.com>
>>> Date: Mon, 27 Feb 2023 10:02:32 +0000
>>> Subject: [PATCH] gcc.dg/memchr-3.c: fix for LLP64
>>>
>>> 	gcc/testsuite/ChangeLog:
>>>
>>> 	PR middle-end/97956
>>> 	* gcc.dg/memchr-3.c (memchr): fix long to size_t in
>>> 	prototype.
>> 
>> It looks like the current type signature could have been a deliberate
>> part of the test.  I think we should just skip it for LLP64 instead.
>> Preapproved if you agree.
>> 
>> Thanks,
>> Richard
>> 
>
> Revised, account for the warning in LLP64.
>
>
> From 2dbfa538fe11c65914b28f94d066daee789f881a Mon Sep 17 00:00:00 2001
> From: Jonathan Yong <10walls@gmail.com>
> Date: Mon, 27 Feb 2023 10:02:32 +0000
> Subject: [PATCH 6/7] gcc.dg/memchr-3.c: Account for LLP64 warnings
>
> 	gcc/testsuite/ChangeLog:
>
> 	PR middle-end/97956
> 	* gcc.dg/memchr-3.c (memchr): Account for LLP64 warnings.
>
> Signed-off-by: Jonathan Yong <10walls@gmail.com>
> ---
>  gcc/testsuite/gcc.dg/memchr-3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/memchr-3.c b/gcc/testsuite/gcc.dg/memchr-3.c
> index c38d9cf3349..af1b26ef3ae 100644
> --- a/gcc/testsuite/gcc.dg/memchr-3.c
> +++ b/gcc/testsuite/gcc.dg/memchr-3.c
> @@ -6,7 +6,7 @@
>  typedef __INT8_TYPE__  int8_t;
>  typedef __INT32_TYPE__ int32_t;
>  
> -extern void* memchr (const void*, int, long);
> +extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" { target llp64 } } */
>  
>  struct SX
>  {

OK, thanks.

Richard