From: Richard Sandiford <richard.sandiford@arm.com>
To: Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Jonathan Yong <10walls@gmail.com>
Subject: Re: [Patch] gcc.dg/memchr-3.c: fix for LLP64
Date: Mon, 27 Feb 2023 16:55:24 +0000 [thread overview]
Message-ID: <mptmt4zqc8z.fsf@arm.com> (raw)
In-Reply-To: <de0cc9e3-5c41-2bc4-64fb-37e6902d9ef5@gmail.com> (Jonathan Yong via Gcc-patches's message of "Mon, 27 Feb 2023 10:09:34 +0000")
Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> Attached patch OK?
>
> gcc.dg/memchr-3.c: fix for LLP64
>
> gcc/testsuite/ChangeLog:
>
> PR middle-end/97956
> * gcc.dg/memchr-3.c (memchr): fix long to size_t in
> prototype.
>
> From 194eb3d43964276beeaea14ebee4b241799cd966 Mon Sep 17 00:00:00 2001
> From: Jonathan Yong <10walls@gmail.com>
> Date: Mon, 27 Feb 2023 10:02:32 +0000
> Subject: [PATCH] gcc.dg/memchr-3.c: fix for LLP64
>
> gcc/testsuite/ChangeLog:
>
> PR middle-end/97956
> * gcc.dg/memchr-3.c (memchr): fix long to size_t in
> prototype.
It looks like the current type signature could have been a deliberate
part of the test. I think we should just skip it for LLP64 instead.
Preapproved if you agree.
Thanks,
Richard
>
> Signed-off-by: Jonathan Yong <10walls@gmail.com>
> ---
> gcc/testsuite/gcc.dg/memchr-3.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/memchr-3.c b/gcc/testsuite/gcc.dg/memchr-3.c
> index c38d9cf3349..c1f4e9e10dc 100644
> --- a/gcc/testsuite/gcc.dg/memchr-3.c
> +++ b/gcc/testsuite/gcc.dg/memchr-3.c
> @@ -5,8 +5,9 @@
>
> typedef __INT8_TYPE__ int8_t;
> typedef __INT32_TYPE__ int32_t;
> +typedef __SIZE_TYPE__ size_t;
>
> -extern void* memchr (const void*, int, long);
> +extern void* memchr (const void*, int, size_t);
>
> struct SX
> {
next prev parent reply other threads:[~2023-02-27 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 10:09 Jonathan Yong
2023-02-27 16:55 ` Richard Sandiford [this message]
2023-03-01 13:41 ` Jonathan Yong
2023-03-02 10:46 ` Richard Sandiford
2023-03-02 13:43 ` Jonathan Yong
2023-03-02 23:52 ` [committed] testsuite: Fix up memchr-3.c test [PR108991] Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptmt4zqc8z.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=10walls@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).