* [PATCH] s390: avoid peeking eof after __vector
@ 2024-03-27 6:36 Jiufu Guo
2024-04-17 1:52 ` Jiufu Guo
0 siblings, 1 reply; 3+ messages in thread
From: Jiufu Guo @ 2024-03-27 6:36 UTC (permalink / raw)
To: gcc-patches
Cc: segher, dje.gcc, linkw, bergner, guojiufu, uweigand, krebbel,
pinskia, rguenther, jeffreyalaw
Hi,
Same like PR101168, this patch is need for s390 to
avoid peeking eof after vector keyword.
And similar test case is also ok for s390.
Is this ok for trunk?
Jeff (Jiufu Guo)
PR target/95782
gcc/ChangeLog:
* config/s390/s390-c.cc (s390_macro_to_expand): Avoid empty identifier.
gcc/testsuite/ChangeLog:
* g++.target/s390/pr95782.C: New test.
---
gcc/config/s390/s390-c.cc | 4 +++-
gcc/testsuite/g++.target/s390/pr95782.C | 5 +++++
2 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/g++.target/s390/pr95782.C
diff --git a/gcc/config/s390/s390-c.cc b/gcc/config/s390/s390-c.cc
index 8d3d1a467a8..45f164d978b 100644
--- a/gcc/config/s390/s390-c.cc
+++ b/gcc/config/s390/s390-c.cc
@@ -275,7 +275,9 @@ s390_macro_to_expand (cpp_reader *pfile, const cpp_token *tok)
/* __vector long __bool a; */
if (ident == C_CPP_HASHNODE (__bool_keyword))
expand_bool_p = true;
- else
+
+ /* If there are more tokens to check. */
+ else if (ident)
{
/* Triggered with: __vector long long __bool a; */
do
diff --git a/gcc/testsuite/g++.target/s390/pr95782.C b/gcc/testsuite/g++.target/s390/pr95782.C
new file mode 100644
index 00000000000..daf887fc6fe
--- /dev/null
+++ b/gcc/testsuite/g++.target/s390/pr95782.C
@@ -0,0 +1,5 @@
+// { dg-do compile }
+// { dg-options "-march=z14 -mzvector" }
+
+using vdbl = __vector double;
+#define BREAK 1
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: avoid peeking eof after __vector
2024-03-27 6:36 [PATCH] s390: avoid peeking eof after __vector Jiufu Guo
@ 2024-04-17 1:52 ` Jiufu Guo
2024-04-17 6:09 ` Andreas Krebbel
0 siblings, 1 reply; 3+ messages in thread
From: Jiufu Guo @ 2024-04-17 1:52 UTC (permalink / raw)
To: gcc-patches; +Cc: segher, dje.gcc, linkw, bergner, uweigand, krebbel
Hi,
I would like to ping this patch.
Jeff (Jiufu Guo)
Jiufu Guo <guojiufu@linux.ibm.com> writes:
> Hi,
>
> Same like PR101168, this patch is need for s390 to
> avoid peeking eof after vector keyword.
> And similar test case is also ok for s390.
>
> Is this ok for trunk?
>
> Jeff (Jiufu Guo)
>
> PR target/95782
>
> gcc/ChangeLog:
>
> * config/s390/s390-c.cc (s390_macro_to_expand): Avoid empty identifier.
>
> gcc/testsuite/ChangeLog:
>
> * g++.target/s390/pr95782.C: New test.
>
> ---
> gcc/config/s390/s390-c.cc | 4 +++-
> gcc/testsuite/g++.target/s390/pr95782.C | 5 +++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
> create mode 100644 gcc/testsuite/g++.target/s390/pr95782.C
>
> diff --git a/gcc/config/s390/s390-c.cc b/gcc/config/s390/s390-c.cc
> index 8d3d1a467a8..45f164d978b 100644
> --- a/gcc/config/s390/s390-c.cc
> +++ b/gcc/config/s390/s390-c.cc
> @@ -275,7 +275,9 @@ s390_macro_to_expand (cpp_reader *pfile, const cpp_token *tok)
> /* __vector long __bool a; */
> if (ident == C_CPP_HASHNODE (__bool_keyword))
> expand_bool_p = true;
> - else
> +
> + /* If there are more tokens to check. */
> + else if (ident)
> {
> /* Triggered with: __vector long long __bool a; */
> do
> diff --git a/gcc/testsuite/g++.target/s390/pr95782.C b/gcc/testsuite/g++.target/s390/pr95782.C
> new file mode 100644
> index 00000000000..daf887fc6fe
> --- /dev/null
> +++ b/gcc/testsuite/g++.target/s390/pr95782.C
> @@ -0,0 +1,5 @@
> +// { dg-do compile }
> +// { dg-options "-march=z14 -mzvector" }
> +
> +using vdbl = __vector double;
> +#define BREAK 1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: avoid peeking eof after __vector
2024-04-17 1:52 ` Jiufu Guo
@ 2024-04-17 6:09 ` Andreas Krebbel
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Krebbel @ 2024-04-17 6:09 UTC (permalink / raw)
To: Jiufu Guo, gcc-patches; +Cc: segher, dje.gcc, linkw, bergner, uweigand
On 4/17/24 03:52, Jiufu Guo wrote:
>
> Hi,
>
> I would like to ping this patch.
>
>
> Jeff (Jiufu Guo)
>
> Jiufu Guo <guojiufu@linux.ibm.com> writes:
>
>> Hi,
>>
>> Same like PR101168, this patch is need for s390 to
>> avoid peeking eof after vector keyword.
>> And similar test case is also ok for s390.
>>
>> Is this ok for trunk?
>>
>> Jeff (Jiufu Guo)
>>
>> PR target/95782
>>
>> gcc/ChangeLog:
>>
>> * config/s390/s390-c.cc (s390_macro_to_expand): Avoid empty identifier.
>>
>> gcc/testsuite/ChangeLog:
>>
>> * g++.target/s390/pr95782.C: New test.
Sorry for the delay. This is ok. Thanks!
Andreas
>>
>> ---
>> gcc/config/s390/s390-c.cc | 4 +++-
>> gcc/testsuite/g++.target/s390/pr95782.C | 5 +++++
>> 2 files changed, 8 insertions(+), 1 deletion(-)
>> create mode 100644 gcc/testsuite/g++.target/s390/pr95782.C
>>
>> diff --git a/gcc/config/s390/s390-c.cc b/gcc/config/s390/s390-c.cc
>> index 8d3d1a467a8..45f164d978b 100644
>> --- a/gcc/config/s390/s390-c.cc
>> +++ b/gcc/config/s390/s390-c.cc
>> @@ -275,7 +275,9 @@ s390_macro_to_expand (cpp_reader *pfile, const cpp_token *tok)
>> /* __vector long __bool a; */
>> if (ident == C_CPP_HASHNODE (__bool_keyword))
>> expand_bool_p = true;
>> - else
>> +
>> + /* If there are more tokens to check. */
>> + else if (ident)
>> {
>> /* Triggered with: __vector long long __bool a; */
>> do
>> diff --git a/gcc/testsuite/g++.target/s390/pr95782.C b/gcc/testsuite/g++.target/s390/pr95782.C
>> new file mode 100644
>> index 00000000000..daf887fc6fe
>> --- /dev/null
>> +++ b/gcc/testsuite/g++.target/s390/pr95782.C
>> @@ -0,0 +1,5 @@
>> +// { dg-do compile }
>> +// { dg-options "-march=z14 -mzvector" }
>> +
>> +using vdbl = __vector double;
>> +#define BREAK 1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-17 6:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-27 6:36 [PATCH] s390: avoid peeking eof after __vector Jiufu Guo
2024-04-17 1:52 ` Jiufu Guo
2024-04-17 6:09 ` Andreas Krebbel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).