From: Jeff Law <jeffreyalaw@gmail.com>
To: Kito Cheng <kito.cheng@sifive.com>, "juzhe.zhong" <juzhe.zhong@rivai.ai>
Cc: jiawei <jiawei@iscas.ac.cn>, "kito.cheng" <kito.cheng@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
palmer <palmer@rivosinc.com>,
"christoph.muellner" <christoph.muellner@vrull.eu>,
"philipp.tomsich" <philipp.tomsich@vrull.eu>,
wuwei2016 <wuwei2016@iscas.ac.cn>
Subject: Re: [PATCH] RISC-V: Optimal RVV epilogue logic.
Date: Mon, 14 Nov 2022 20:42:03 -0700 [thread overview]
Message-ID: <f01b8d54-6a92-b433-5ad5-e6a79a7a00cc@gmail.com> (raw)
In-Reply-To: <CALLt3ThBh2vN5PNBt6XS1k0ExOu6OSj4e9oa6y+EBAYQaWjCCg@mail.gmail.com>
On 11/14/22 20:13, Kito Cheng wrote:
> I would suggest add a sperated case and scan-assembly-not to demonstrate
> this patch.
Agreed. One way to do this would be to have new tests which have the
proper dg-directives for testing this issue and #include the original test.
So, something like this:
/* { dg-do compile } */
/* { dg-options "-march=rv32gcv -mabi=ilp32 -mpreferred-stack-boundary=3
-O3 -fno-schedule-insns -fno-schedule-insns2" } */
#include "spill-1.c"
/* Make sure we do not have a useless SP adjustment. */
/* { dg-final { scan-assembler-not "addi sp, sp, 0" } } */
The key thing to know is that the dg directives are parsed by the
framework before preprocessing. So the dg-directives in spill-1.c would
not affect this new test. That requires us to provide our own, both for
how to run the test and what to look for.
Jeff
next prev parent reply other threads:[~2022-11-15 3:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 16:29 jiawei
2022-11-15 1:48 ` Kito Cheng
2022-11-15 2:37 ` jiawei
2022-11-15 2:46 ` juzhe.zhong
2022-11-15 3:13 ` Kito Cheng
2022-11-15 3:42 ` Jeff Law [this message]
2022-11-15 3:30 ` Jeff Law
2022-11-15 10:35 ` Philipp Tomsich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01b8d54-6a92-b433-5ad5-e6a79a7a00cc@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jiawei@iscas.ac.cn \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@rivosinc.com \
--cc=philipp.tomsich@vrull.eu \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).