* [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
@ 2022-07-25 6:55 Dimitrije Milosevic
2022-07-25 7:04 ` Xi Ruoyao
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Dimitrije Milosevic @ 2022-07-25 6:55 UTC (permalink / raw)
To: gcc-patches; +Cc: Djordje Todorovic, xry111
2bfb0fcb51510f22723c8cdfefe [Sanitizer][MIPS] Fix stat struct size for the O32 ABI.
Signed-off-by: Dimitrije Milosevic <dimitrije.milosevic@syrmia.com>.
---
.../sanitizer_common/sanitizer_platform_limits_posix.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
index 89772a7e5c0..75c6cc7f285 100644
--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
@@ -81,9 +81,10 @@ const unsigned struct_kernel_stat64_sz = 104;
const unsigned struct_kernel_stat_sz = 144;
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__mips__)
-const unsigned struct_kernel_stat_sz = SANITIZER_ANDROID
- ? FIRST_32_SECOND_64(104, 128)
- : FIRST_32_SECOND_64(144, 216);
+const unsigned struct_kernel_stat_sz =
+ SANITIZER_ANDROID
+ ? FIRST_32_SECOND_64(104, 128)
+ : FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216);
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__s390__) && !defined(__s390x__)
const unsigned struct_kernel_stat_sz = 64;
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-25 6:55 [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream Dimitrije Milosevic
@ 2022-07-25 7:04 ` Xi Ruoyao
2022-07-27 6:41 ` PING: " Dimitrije Milosevic
2022-07-28 13:43 ` Dimitrije Milosevic
2 siblings, 0 replies; 10+ messages in thread
From: Xi Ruoyao @ 2022-07-25 7:04 UTC (permalink / raw)
To: Dimitrije Milosevic, gcc-patches; +Cc: Djordje Todorovic, Richard Sandiford
LGTM. Requiring permission to push.
> +const unsigned struct_kernel_stat_sz =
> + SANITIZER_ANDROID
> + ? FIRST_32_SECOND_64(104, 128)
> + : FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216);
These values matches sizeof(struct stat) on gcc230, so should be
correct:
xry111@gcc230:~$ cat t.c
#include <stdio.h>
#include <sys/stat.h>
int main()
{
printf("%d\n", sizeof(struct stat));
}
xry111@gcc230:~$ cc t.c -mabi=32 && ./a.out
144
xry111@gcc230:~$ cc t.c -mabi=n32 && ./a.out
160
xry111@gcc230:~$ cc t.c -mabi=64 && ./a.out
216
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 10+ messages in thread
* PING: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-25 6:55 [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream Dimitrije Milosevic
2022-07-25 7:04 ` Xi Ruoyao
@ 2022-07-27 6:41 ` Dimitrije Milosevic
2022-07-27 6:43 ` Xi Ruoyao
2022-07-28 13:43 ` Dimitrije Milosevic
2 siblings, 1 reply; 10+ messages in thread
From: Dimitrije Milosevic @ 2022-07-27 6:41 UTC (permalink / raw)
To: gcc-patches; +Cc: Djordje Todorovic, xry111, richard.sandiford
Gentle ping, requiring someone to push this change, as I do not have commit access. :)
From: Dimitrije Milosevic
Sent: Monday, July 25, 2022 8:55 AM
To: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: Djordje Todorovic <Djordje.Todorovic@syrmia.com>; xry111@xry111.site <xry111@xry111.site>
Subject: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2bfb0fcb51510f22723c8cdfefe [Sanitizer][MIPS] Fix stat struct size for the O32 ABI.
Signed-off-by: Dimitrije Milosevic <dimitrije.milosevic@syrmia.com>.
---
.../sanitizer_common/sanitizer_platform_limits_posix.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
index 89772a7e5c0..75c6cc7f285 100644
--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
@@ -81,9 +81,10 @@ const unsigned struct_kernel_stat64_sz = 104;
const unsigned struct_kernel_stat_sz = 144;
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__mips__)
-const unsigned struct_kernel_stat_sz = SANITIZER_ANDROID
- ? FIRST_32_SECOND_64(104, 128)
- : FIRST_32_SECOND_64(144, 216);
+const unsigned struct_kernel_stat_sz =
+ SANITIZER_ANDROID
+ ? FIRST_32_SECOND_64(104, 128)
+ : FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216);
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__s390__) && !defined(__s390x__)
const unsigned struct_kernel_stat_sz = 64;
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: PING: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-27 6:41 ` PING: " Dimitrije Milosevic
@ 2022-07-27 6:43 ` Xi Ruoyao
2022-07-27 6:52 ` Dimitrije Milosevic
0 siblings, 1 reply; 10+ messages in thread
From: Xi Ruoyao @ 2022-07-27 6:43 UTC (permalink / raw)
To: Dimitrije Milosevic, gcc-patches; +Cc: Djordje Todorovic, richard.sandiford
On Wed, 2022-07-27 at 06:41 +0000, Dimitrije Milosevic wrote:
> Gentle ping, requiring someone to push this change, as I do not have
> commit access. :)
Do you know someone very familiar with MIPS and GCC and capable as a
port maintainer? An active MIPS port maintainer will make the situation
better.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: PING: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-27 6:43 ` Xi Ruoyao
@ 2022-07-27 6:52 ` Dimitrije Milosevic
2022-07-27 12:57 ` Richard Sandiford
0 siblings, 1 reply; 10+ messages in thread
From: Dimitrije Milosevic @ 2022-07-27 6:52 UTC (permalink / raw)
To: Xi Ruoyao, gcc-patches; +Cc: Djordje Todorovic, richard.sandiford
> Do you know someone very familiar with MIPS and GCC and capable as a
> port maintainer? An active MIPS port maintainer will make the situation
> better.
Sadly, no. I agree it would make things easier.
From: Xi Ruoyao <xry111@xry111.site>
Sent: Wednesday, July 27, 2022 8:43 AM
To: Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com>; gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: Djordje Todorovic <Djordje.Todorovic@syrmia.com>; richard.sandiford@arm.com <richard.sandiford@arm.com>
Subject: Re: PING: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
On Wed, 2022-07-27 at 06:41 +0000, Dimitrije Milosevic wrote:
> Gentle ping, requiring someone to push this change, as I do not have
> commit access. :)
Do you know someone very familiar with MIPS and GCC and capable as a
port maintainer? An active MIPS port maintainer will make the situation
better.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: PING: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-27 6:52 ` Dimitrije Milosevic
@ 2022-07-27 12:57 ` Richard Sandiford
0 siblings, 0 replies; 10+ messages in thread
From: Richard Sandiford @ 2022-07-27 12:57 UTC (permalink / raw)
To: Dimitrije Milosevic; +Cc: Xi Ruoyao, gcc-patches, Djordje Todorovic
Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com> writes:
>> Do you know someone very familiar with MIPS and GCC and capable as a
>> port maintainer? An active MIPS port maintainer will make the situation
>> better.
> Sadly, no. I agree it would make things easier.
Yeah, I agree that's what we need. I stepped down from being a MIPS
maintainer over eight years ago and Matthew moved on to other things
several years ago as well. The port has been unmaintained for a long
time now.
For a while I tried to be practical and approve trivial patches, even
though working for an IP company makes that somewhat awkward from a
conflict-of-interest perspective. But it's been so long now since
I worked on MIPS that the technical side is becoming a problem too.
Thanks,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-25 6:55 [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream Dimitrije Milosevic
2022-07-25 7:04 ` Xi Ruoyao
2022-07-27 6:41 ` PING: " Dimitrije Milosevic
@ 2022-07-28 13:43 ` Dimitrije Milosevic
2022-07-28 13:48 ` Martin Liška
2 siblings, 1 reply; 10+ messages in thread
From: Dimitrije Milosevic @ 2022-07-28 13:43 UTC (permalink / raw)
To: gcc-patches; +Cc: Djordje Todorovic, xry111, joseph, macro
Gentle ping, requiring someone to push the change. :)
From: Dimitrije Milosevic
Sent: Monday, July 25, 2022 8:55 AM
To: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: Djordje Todorovic <Djordje.Todorovic@syrmia.com>; xry111@xry111.site <xry111@xry111.site>
Subject: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2bfb0fcb51510f22723c8cdfefe [Sanitizer][MIPS] Fix stat struct size for the O32 ABI.
Signed-off-by: Dimitrije Milosevic <dimitrije.milosevic@syrmia.com>.
---
.../sanitizer_common/sanitizer_platform_limits_posix.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
index 89772a7e5c0..75c6cc7f285 100644
--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
@@ -81,9 +81,10 @@ const unsigned struct_kernel_stat64_sz = 104;
const unsigned struct_kernel_stat_sz = 144;
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__mips__)
-const unsigned struct_kernel_stat_sz = SANITIZER_ANDROID
- ? FIRST_32_SECOND_64(104, 128)
- : FIRST_32_SECOND_64(144, 216);
+const unsigned struct_kernel_stat_sz =
+ SANITIZER_ANDROID
+ ? FIRST_32_SECOND_64(104, 128)
+ : FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216);
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__s390__) && !defined(__s390x__)
const unsigned struct_kernel_stat_sz = 64;
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-28 13:43 ` Dimitrije Milosevic
@ 2022-07-28 13:48 ` Martin Liška
2022-07-29 6:38 ` Dimitrije Milosevic
0 siblings, 1 reply; 10+ messages in thread
From: Martin Liška @ 2022-07-28 13:48 UTC (permalink / raw)
To: Dimitrije Milosevic, gcc-patches; +Cc: macro, Djordje Todorovic, joseph
On 7/28/22 15:43, Dimitrije Milosevic wrote:
> |Gentle ping, requiring someone to push the change. :)|
Sure, I can do that, but please attach output of (git format-patch) as an attachment
to an email. The current email has a weird format I can directly apply with git am.
Cheers,
Martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-28 13:48 ` Martin Liška
@ 2022-07-29 6:38 ` Dimitrije Milosevic
2022-08-01 4:11 ` Martin Liška
0 siblings, 1 reply; 10+ messages in thread
From: Dimitrije Milosevic @ 2022-07-29 6:38 UTC (permalink / raw)
To: Martin Liška, gcc-patches; +Cc: macro, Djordje Todorovic, joseph
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
Thanks Martin! I'm sending out the output from git format-patch as an attachment to this email.
From: Martin Liška <mliska@suse.cz>
Sent: Thursday, July 28, 2022 3:48 PM
To: Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com>; gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: macro@embecosm.com <macro@embecosm.com>; Djordje Todorovic <Djordje.Todorovic@syrmia.com>; joseph@codesourcery.com <joseph@codesourcery.com>
Subject: Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
On 7/28/22 15:43, Dimitrije Milosevic wrote:
> |Gentle ping, requiring someone to push the change. :)|
Sure, I can do that, but please attach output of (git format-patch) as an attachment
to an email. The current email has a weird format I can directly apply with git am.
Cheers,
Martin
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-libsanitizer-Cherry-pick-2bfb0fcb51510f22723c8cdfefe.patch --]
[-- Type: text/x-patch; name="0001-libsanitizer-Cherry-pick-2bfb0fcb51510f22723c8cdfefe.patch", Size: 1599 bytes --]
From 9d7646428bf36449cde380230bcc20fa835857dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dimitrije=20Milo=C5=A1evi=C4=87?=
<dimitrije.milosevic@syrmia.com>
Date: Fri, 29 Jul 2022 08:36:06 +0200
Subject: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from
upstream
2bfb0fcb51510f22723c8cdfefe [Sanitizer][MIPS] Fix stat struct size for the O32 ABI.
Signed-off-by: Dimitrije Milosevic <dimitrije.milosevic@syrmia.com>.
---
.../sanitizer_common/sanitizer_platform_limits_posix.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
index 89772a7e5c0..75c6cc7f285 100644
--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
@@ -81,9 +81,10 @@ const unsigned struct_kernel_stat64_sz = 104;
const unsigned struct_kernel_stat_sz = 144;
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__mips__)
-const unsigned struct_kernel_stat_sz = SANITIZER_ANDROID
- ? FIRST_32_SECOND_64(104, 128)
- : FIRST_32_SECOND_64(144, 216);
+const unsigned struct_kernel_stat_sz =
+ SANITIZER_ANDROID
+ ? FIRST_32_SECOND_64(104, 128)
+ : FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216);
const unsigned struct_kernel_stat64_sz = 104;
#elif defined(__s390__) && !defined(__s390x__)
const unsigned struct_kernel_stat_sz = 64;
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
2022-07-29 6:38 ` Dimitrije Milosevic
@ 2022-08-01 4:11 ` Martin Liška
0 siblings, 0 replies; 10+ messages in thread
From: Martin Liška @ 2022-08-01 4:11 UTC (permalink / raw)
To: Dimitrije Milosevic, gcc-patches; +Cc: macro, Djordje Todorovic, joseph
On 7/29/22 08:38, Dimitrije Milosevic wrote:
> Thanks Martin! I'm sending out the output from git format-patch as an attachment to this email.
You're welcome, pushed as r13-1909-g1efeaf99bd8bdf.
Cheers,
Martin
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-08-01 4:11 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-25 6:55 [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream Dimitrije Milosevic
2022-07-25 7:04 ` Xi Ruoyao
2022-07-27 6:41 ` PING: " Dimitrije Milosevic
2022-07-27 6:43 ` Xi Ruoyao
2022-07-27 6:52 ` Dimitrije Milosevic
2022-07-27 12:57 ` Richard Sandiford
2022-07-28 13:43 ` Dimitrije Milosevic
2022-07-28 13:48 ` Martin Liška
2022-07-29 6:38 ` Dimitrije Milosevic
2022-08-01 4:11 ` Martin Liška
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).