* [PATCH] ppc: testsuite: vec-mul requires vsx runtime
@ 2022-05-03 5:38 Alexandre Oliva
2024-04-22 9:35 ` Alexandre Oliva
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Oliva @ 2022-05-03 5:38 UTC (permalink / raw)
To: gcc-patches; +Cc: David Edelsohn, Segher Boessenkool
vec-mul is an execution test, but it only requires a powerpc_vsx_ok
effective target, which is enough only for compile tests. In order to
To check for runtime and execution environment support, we need to
require vsx_hw. Make that a condition for execution, but still
perform a compile test if the condition is not satisfied.
Regstrapped on ppc64le-linux-gnu, also tested on
x86_64-linux-gnu-x-ppc-vx7r2 (no vsx execution support)
Ok to install? gcc-12? gcc-11?
for gcc/testsuite/ChangeLog
* testsuite/powerpc/vec-mul.c: Run on target vsx_hw, just
compile otherwise.
---
gcc/testsuite/gcc.target/powerpc/vec-mul.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-mul.c b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
index bfcaf80719d1d..11da86159723f 100644
--- a/gcc/testsuite/gcc.target/powerpc/vec-mul.c
+++ b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
@@ -1,4 +1,5 @@
-/* { dg-do run } */
+/* { dg-do compile { target { ! vsx_hw } } } */
+/* { dg-do run { target vsx_hw } } */
/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-mvsx -O3" } */
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ppc: testsuite: vec-mul requires vsx runtime
2022-05-03 5:38 [PATCH] ppc: testsuite: vec-mul requires vsx runtime Alexandre Oliva
@ 2024-04-22 9:35 ` Alexandre Oliva
2024-04-23 6:51 ` Kewen.Lin
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Oliva @ 2024-04-22 9:35 UTC (permalink / raw)
To: gcc-patches
Cc: Rainer Orth, Mike Stump, David Edelsohn, Segher Boessenkool, Kewen Lin
Ping?
https://gcc.gnu.org/pipermail/gcc-patches/2022-May/593947.html
vec-mul is an execution test, but it only requires a powerpc_vsx_ok
effective target, which is enough only for compile tests. In order to
To check for runtime and execution environment support, we need to
require vsx_hw. Make that a condition for execution, but still
perform a compile test if the condition is not satisfied.
Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also tested with
gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install?
for gcc/testsuite/ChangeLog
* gcc.target/powerpc/vec-mul.c: Run on target vsx_hw, just
compile otherwise.
---
gcc/testsuite/gcc.target/powerpc/vec-mul.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-mul.c b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
index bfcaf80719d1d..11da86159723f 100644
--- a/gcc/testsuite/gcc.target/powerpc/vec-mul.c
+++ b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
@@ -1,4 +1,5 @@
-/* { dg-do run } */
+/* { dg-do compile { target { ! vsx_hw } } } */
+/* { dg-do run { target vsx_hw } } */
/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-mvsx -O3" } */
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc: testsuite: vec-mul requires vsx runtime
2024-04-22 9:35 ` Alexandre Oliva
@ 2024-04-23 6:51 ` Kewen.Lin
2024-04-28 7:33 ` Alexandre Oliva
0 siblings, 1 reply; 4+ messages in thread
From: Kewen.Lin @ 2024-04-23 6:51 UTC (permalink / raw)
To: Alexandre Oliva
Cc: Rainer Orth, Mike Stump, David Edelsohn, Segher Boessenkool,
Kewen Lin, gcc-patches
on 2024/4/22 17:35, Alexandre Oliva wrote:
> Ping?
> https://gcc.gnu.org/pipermail/gcc-patches/2022-May/593947.html
>
>
> vec-mul is an execution test, but it only requires a powerpc_vsx_ok
> effective target, which is enough only for compile tests. In order to
> To check for runtime and execution environment support, we need to
> require vsx_hw. Make that a condition for execution, but still
> perform a compile test if the condition is not satisfied.
>
> Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also tested with
> gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install?
>
>
> for gcc/testsuite/ChangeLog
>
> * gcc.target/powerpc/vec-mul.c: Run on target vsx_hw, just
> compile otherwise.
> ---
> gcc/testsuite/gcc.target/powerpc/vec-mul.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/vec-mul.c b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
> index bfcaf80719d1d..11da86159723f 100644
> --- a/gcc/testsuite/gcc.target/powerpc/vec-mul.c
> +++ b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
> @@ -1,4 +1,5 @@
> -/* { dg-do run } */
> +/* { dg-do compile { target { ! vsx_hw } } } */
> +/* { dg-do run { target vsx_hw } } */
> /* { dg-require-effective-target powerpc_vsx_ok } */
Nit: It's useless to check powerpc_vsx_ok for vsx_hw, so powerpc_vsx_ok check
can be moved to be with ! vsx_hw.
OK with this nit tweaked, thanks!
BR,
Kewen
> /* { dg-options "-mvsx -O3" } */
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc: testsuite: vec-mul requires vsx runtime
2024-04-23 6:51 ` Kewen.Lin
@ 2024-04-28 7:33 ` Alexandre Oliva
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Oliva @ 2024-04-28 7:33 UTC (permalink / raw)
To: Kewen.Lin
Cc: Rainer Orth, Mike Stump, David Edelsohn, Segher Boessenkool,
Kewen Lin, gcc-patches
On Apr 23, 2024, "Kewen.Lin" <linkw@linux.ibm.com> wrote:
>> -/* { dg-do run } */
>> +/* { dg-do compile { target { ! vsx_hw } } } */
>> +/* { dg-do run { target vsx_hw } } */
>> /* { dg-require-effective-target powerpc_vsx_ok } */
> Nit: It's useless to check powerpc_vsx_ok for vsx_hw, so powerpc_vsx_ok check
> can be moved to be with ! vsx_hw.
> OK with this nit tweaked, thanks!
Thanks, here's what I'm pushing momentarily...
ppc: testsuite: vec-mul requires vsx runtime
vec-mul is an execution test, but it only requires a powerpc_vsx_ok
effective target, which is enough only for compile tests. In order to
check for runtime and execution environment support, we need to
require vsx_hw. Make that a condition for execution, but still
perform a compile test if the condition is not satisfied.
for gcc/testsuite/ChangeLog
* gcc.target/powerpc/vec-mul.c: Run on target vsx_hw, just
compile otherwise.
---
gcc/testsuite/gcc.target/powerpc/vec-mul.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-mul.c b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
index bfcaf80719d1d..aa0ef7aa45acc 100644
--- a/gcc/testsuite/gcc.target/powerpc/vec-mul.c
+++ b/gcc/testsuite/gcc.target/powerpc/vec-mul.c
@@ -1,5 +1,5 @@
-/* { dg-do run } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
+/* { dg-do compile { target { { ! vsx_hw } && powerpc_vsx_ok } } } */
+/* { dg-do run { target vsx_hw } } */
/* { dg-options "-mvsx -O3" } */
/* Test that the vec_mul builtin works as expected. */
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-28 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 5:38 [PATCH] ppc: testsuite: vec-mul requires vsx runtime Alexandre Oliva
2024-04-22 9:35 ` Alexandre Oliva
2024-04-23 6:51 ` Kewen.Lin
2024-04-28 7:33 ` Alexandre Oliva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).